From: lg.zevlg@gmail.com
To: Eli Zaretskii <eliz@gnu.org>
Cc: dick.r.chiang@gmail.com, 44466@debbugs.gnu.org
Subject: bug#44466: 27.1; quail input fails at read-only boundary
Date: Sun, 8 Nov 2020 20:07:46 +0400 [thread overview]
Message-ID: <B940A149-D796-4BBC-9311-4AAB62FD89CF@gmail.com> (raw)
In-Reply-To: <83tutz6gdb.fsf@gnu.org>
> 8 нояб. 2020 г., в 19:02, Eli Zaretskii <eliz@gnu.org> написал(а):
>
>
>>
>> From: Evgeny Zajcev <lg.zevlg@gmail.com>
>> Date: Sun, 8 Nov 2020 09:42:23 +0300
>> Cc: dick.r.chiang@gmail.com, 44466@debbugs.gnu.org
>>
>>> When an input method is used in a read-only buffer, Emacs barfs
>>> because it doesn't allow inserting text into such a buffer. It
>>> doesn't insert the untranslated character, as what your patch did.
>>>
>>>> Possible we need to check front-stickyness of the char at point along with 'read-only property:
>>>>
>>>> ..
>>>> (and (get-char-property (point) 'read-only)
>>>> (get-char-property (point) 'front-sticky)))
>>>
>>> Does this solve the problem in this case?
>>
>> Yes, because this mimics what is done in
>> verify_interval_modification() function from textprop.c.
>
> Any reason why pressing a key on a button should disregard the active
> input method? What if the button needs the user to type the character
> which the input method would produce? AFAIU, the patch we installed a
> year ago makes this impossible.
The reason is the same as for read-only buffers, making single char bindings work. For example if you change input method in image-mode and press “q” key this will kill buffer, because correct command is executed.
Writable buffer might have read-only region with local-keymap installed with single char binding. If input method is applied, then instead of executing corresponding command you will get “text is read-only” error, because self-insert command is executed.
>
>> Possibly the best solution would be to make
>> verify_interval_modification() visible from elisp side and use it in
>> quail-input-method to check for writability at point.
>
> I think this would be overkill.
—
lg
next prev parent reply other threads:[~2020-11-08 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 13:48 bug#44466: 27.1; quail input fails at read-only boundary dick
2020-11-07 13:47 ` Eli Zaretskii
2020-11-07 22:24 ` Evgeny Zajcev
2020-11-08 3:29 ` Eli Zaretskii
2020-11-08 6:42 ` Evgeny Zajcev
2020-11-08 15:02 ` Eli Zaretskii
2020-11-08 16:07 ` lg.zevlg [this message]
2020-11-08 16:18 ` Eli Zaretskii
2020-11-08 19:50 ` lg.zevlg
2020-11-14 13:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B940A149-D796-4BBC-9311-4AAB62FD89CF@gmail.com \
--to=lg.zevlg@gmail.com \
--cc=44466@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.