all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Perry Smith <pedz@easesoftware.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: emacs-devel <emacs-devel@gnu.org>, casouri@gmail.com
Subject: Re: treesit-query-validate
Date: Sat, 17 Dec 2022 14:26:17 -0600	[thread overview]
Message-ID: <B8402C18-4B6C-49CE-8CC8-14CF243E6612@easesoftware.com> (raw)
In-Reply-To: <875ye9u91p.fsf@thornhill.no>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]



> On Dec 17, 2022, at 13:25, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
> 
> 
> Hi, Perry!
> 
> Perry Smith <pedz@easesoftware.com> writes:
> 
>> I must not know how this function is intended to be used.
>> 
>> What I use to do is go to *scratch*, type in my query and hit C-j and
>> that use to work.  But now it puts *scratch* into view-mode and errors
>> off — this is after the message "QUERY is valid” comes out.
>> 
>> This change was at commit 4bccb7b211e465310a34493dea8a66ce395956fc.
>> 
>> I’m perfectly happy changing my mean and ugly ways :-) but how is this
>> function suppose to be used?
> 
> I usually just do it in the minibuffer, but yes this is a bug.
> 
>> 
>> It might be that the (view-mode) is nested too far out. ?
> 
> Yep, you are completely correct.  Can you test this patch, Perry?
> 
> If reported back positive, can you apply, Yuan?

I can test it but I have no permissions for the official repository.




[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-12-17 20:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 18:43 treesit-query-validate Perry Smith
2022-12-17 19:25 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
2022-12-17 20:26   ` Perry Smith [this message]
2022-12-17 20:34     ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
2022-12-17 20:56       ` treesit-query-validate Perry Smith
2022-12-17 21:06         ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
2022-12-17 23:34           ` treesit-query-validate Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B8402C18-4B6C-49CE-8CC8-14CF243E6612@easesoftware.com \
    --to=pedz@easesoftware.com \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.