From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: abort in `make-frame' Date: Thu, 22 Jul 2004 15:26:20 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <200407202347.i6KNl3V16313@raven.dms.auburn.edu> <200407221316.i6MDGZd12093@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (Apple Message framework v618) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1090502916 24465 80.91.224.253 (22 Jul 2004 13:28:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 22 Jul 2004 13:28:36 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 22 15:28:12 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BndcJ-0004HE-00 for ; Thu, 22 Jul 2004 15:28:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bndf9-0004RR-IR for ged-emacs-devel@m.gmane.org; Thu, 22 Jul 2004 09:31:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bndez-0004RL-KB for emacs-devel@gnu.org; Thu, 22 Jul 2004 09:30:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bndex-0004R3-Rr for emacs-devel@gnu.org; Thu, 22 Jul 2004 09:30:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bndex-0004R0-PR for emacs-devel@gnu.org; Thu, 22 Jul 2004 09:30:55 -0400 Original-Received: from [195.54.107.73] (helo=mxfep02.bredband.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bndbe-0005Su-MO; Thu, 22 Jul 2004 09:27:31 -0400 Original-Received: from coolsville.localdomain ([213.115.26.74] [213.115.26.74]) by mxfep02.bredband.com with ESMTP id <20040722132729.IWDK23867.mxfep02.bredband.com@coolsville.localdomain>; Thu, 22 Jul 2004 15:27:29 +0200 In-Reply-To: <200407221316.i6MDGZd12093@raven.dms.auburn.edu> Original-To: Luc Teirlinck X-Mailer: Apple Mail (2.618) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25877 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25877 > * widget.c (EmacsFrameDestroy): Don't abort if normal_gc > is 0. > > This also fixes the immediate problem (by simply removing the call to > `abort'), but if I understood Jan's message correctly, causes some > other problems. So I guess your patch is superior. I tested that it > works by reverting to Rev1.70 of widget.c (that is, the one just > before Jan's patch). There is no need to revert my change. There is no reason to abort just because normal_gc is 0. x_free_gcs, which EmacsFrameDestroy calls just after the abort, checks for this also. Jan D.