From: JD Smith <jdtsmith@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Popup-menu signals quit when Aborted
Date: Sat, 1 Feb 2020 11:41:40 -0500 [thread overview]
Message-ID: <B5D28AA1-9022-416F-8BC4-76BA6AF88BB2@gmail.com> (raw)
In-Reply-To: <jwvmua29ud9.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]
> On Feb 1, 2020, at 10:55 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> `x-popup-menu` is setup to handle mouse events specially when “aborting” the
>> menu by clicking off of it:
>>
>>> If the user gets rid of the menu without making a valid choice, for
>>> instance by clicking the mouse away from a valid choice or by typing
>>> keyboard input, then this normally results in a quit and
>>> ‘x-popup-menu’ does not return. But if POSITION is a mouse button
>>> event (indicating that the user invoked the menu with the mouse) then
>>> no quit occurs and ‘x-popup-menu’ returns nil.
>
> I wasn't aware (or if I was, I forgot about it in the mean time) of
> this oddity.
>
>> This seems sensible.
>
> I'm glad you find it so, because I can't figure out the underlying logic
> of this oddity. Can you explain why you think it's sensible?
It seems sensible to me that if a mouse-event generates a popup menu, and it is “gotten rid of” by the user by clicking off the menu, that this should NOT signal a quit and ring the bell as if some kind of error has occurred. This is what `x-popup-menu` appears to implement, but its higher-level interface `popup-menu` inhibits this sensible feature by “normalizing” positions.
I encountered this using minions mode. Its popup menu for minor modes is very useful, but sometimes you just want to take a quick look at what modes are set, and not alter anything. But clicking off the menu to get rid of it signals ‘quit and rings the bell. Reading the note above in `x-popup-menu` I considered passing a mouse event would be a reliable fix. But since `popup-menu` strips event information, the only remaining possibility is to trap the quit:
(condition-case nil
(popup-menu map)
(quit nil)))
This seems rather heavy-handed. You can try a simple example (click off the menu):
(let ((menu-bar (make-sparse-keymap "Dismiss Menu")))
(define-key menu-bar [testing] '(menu-item "Nothing" nil))
(popup-menu menu-bar))
[-- Attachment #2: Type: text/html, Size: 3986 bytes --]
next prev parent reply other threads:[~2020-02-01 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 14:51 Popup-menu signals quit when Aborted JD Smith
2020-02-01 15:14 ` Eli Zaretskii
2020-02-01 15:55 ` Stefan Monnier
2020-02-01 16:41 ` JD Smith [this message]
2020-02-01 16:47 ` Stefan Monnier
2020-02-01 21:58 ` JD Smith
2020-02-01 16:48 ` Eli Zaretskii
2020-02-01 21:58 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B5D28AA1-9022-416F-8BC4-76BA6AF88BB2@gmail.com \
--to=jdtsmith@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.