From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.bugs Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" Date: Thu, 2 May 2024 07:47:31 -0400 Message-ID: References: <45C35B69-6DA8-4212-BD87-50B2A3959A86@gmail.com> <86h6fo3e7e.fsf@mail.linkov.net> <86cyqaezhc.fsf@mail.linkov.net> <86ttjle92p.fsf@mail.linkov.net> <86zft8676h.fsf@mail.linkov.net> <86r0ekn0o0.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34360"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70576@debbugs.gnu.org, Eli Zaretskii To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 02 13:49:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2Uw1-0008hZ-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 May 2024 13:49:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2Uvd-0007de-3J; Thu, 02 May 2024 07:48:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2UvZ-0007cG-6J for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 07:48:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2UvY-0004cf-Q3 for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 07:48:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2Uvu-0001lf-8s for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 07:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: JD Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2024 11:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70576 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70576-submit@debbugs.gnu.org id=B70576.17146504976782 (code B ref 70576); Thu, 02 May 2024 11:49:02 +0000 Original-Received: (at 70576) by debbugs.gnu.org; 2 May 2024 11:48:17 +0000 Original-Received: from localhost ([127.0.0.1]:43291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2UvA-0001lK-Rq for submit@debbugs.gnu.org; Thu, 02 May 2024 07:48:17 -0400 Original-Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]:57551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Uv6-0001l8-Lw for 70576@debbugs.gnu.org; Thu, 02 May 2024 07:48:15 -0400 Original-Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-36c72d287f8so1811355ab.2 for <70576@debbugs.gnu.org>; Thu, 02 May 2024 04:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714650465; x=1715255265; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/7wVkSw34x+e5RumE0GpmaHdtTWYQPx0EhkJwwxkP5M=; b=JodsAXFZHA4ulI2+Arz+FUHe9UuFeWTqkwUwTzr0EP9XS9cWBuX/w1rK0M6ecmLIuy +owKIXX4tRZ2DAwX4iNh4nXVrvy5iR5qFfKHIWc3aAJSlRi3absMrupGGg1TYO0yqfJn WOQnhPGXhoSleRklnLTNA0CwkWpBudHWl8lGNcBD9tawhQ0goiNBE4A36xCGsh1ODa7Q mjKQyCOIPELbkrr84o65boADaA3P7nU6w+d6tN0LHt4lQRII1B2p79S6Wol6PL+yFlYy tEMkoRCOJpNmRic+1mmepIdTaEKfKcHyt6nxJG3i5cHycIS27VLtAIyYtspalOcF8UUa Q5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714650465; x=1715255265; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/7wVkSw34x+e5RumE0GpmaHdtTWYQPx0EhkJwwxkP5M=; b=gwixLS3on0KXqLHbLKRaxtK6nP8P7w2GphbwcFkFPytl+7ViPadOyekyoX6dPKZu20 HhrB4xgBf/iKAnZTHnv410qIc8ESsk+6cpXNeDuryLUOkXoPpSHXZG2RsatJH5u5N2fR npTuYi63g2mmqlS1v5kIIggD7U8ouSXbU8ag/EIdQ6KtxF8Xw4DSXfqtpE3HA61kinlt mEollffU+FhUfMUiDkm2FBA5nV1uSQuTds2mOmQYphugeYCZqTzgcvRC+wlGaokFZsll jD2D1OUy3QDYkdu090JzuB+n2Oz56FYllypN6h8AqYPkltSyLYIvkSRzrPWVaLxX4hQk TOlw== X-Gm-Message-State: AOJu0Yyd4A3jO07X3+RJjh4FCDd/oOIeJsdd4jIHGdum1L7RhVkey7+N x1JAkM+mWKOtBtsZC9xXq1W3LgW98JT0upyton0vNGyIONQCp+5+ X-Google-Smtp-Source: AGHT+IFCraoV+jVZPgh/tMWZbI9loypbfhUPvHgbuhFbe/f5DDCEIeL4nrzR6LrMj+O/NjNyzAB+rQ== X-Received: by 2002:a05:6e02:1fce:b0:36c:4aba:10be with SMTP id dj14-20020a056e021fce00b0036c4aba10bemr2443547ilb.10.1714650463052; Thu, 02 May 2024 04:47:43 -0700 (PDT) Original-Received: from smtpclient.apple (cm-24-53-187-34.buckeyecom.net. [24.53.187.34]) by smtp.gmail.com with ESMTPSA id q7-20020a056e0220e700b003698fc3a541sm176619ilv.80.2024.05.02.04.47.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2024 04:47:42 -0700 (PDT) In-Reply-To: <86r0ekn0o0.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.500.171.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284312 Archived-At: Thanks for working on this. I'm sorry I didn't have a chance to test = the patch, it looks good. I don't think a disable variable is necessary = for now, since most repeat maps are self-defined. > On May 2, 2024, at 3:16=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> Cc: 70576@debbugs.gnu.org >> From: Juri Linkov >> Date: Thu, 02 May 2024 09:48:06 +0300 >>=20 >> close 70576 30.0.50 >> thanks >>=20 >>>>> (defvar-keymap expreg-repeat-map >>>>> :doc "Repeat map for `expreg' actions." >>>>> :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . = "contract"))) >>>>> "\\" 'expreg-expand >>>>> "|" 'expreg-contract) >>>>=20 >>>> If a hint is missing for a command, it should just have its key = mentioned. >>>> It looks like your idea would require changes to defvar-keymap. Do = you >>>> want to propose a patch? We'd need some way to pass the hints in; = perhaps >>>> the macro could set a property on the command symbol as you = initially >>>> proposed. >>>=20 >>> Alright, let's add this to defvar-keymap. Please try the following = patch. >>=20 >> Thanks for the feature request. This is pushed now. >=20 > Thanks, but please also update the ELisp manual and add an entry to > NEWS about this change.