bug#2870: 23.0.91; Cursor face not changing

bug#2870: 23.0.91; Cursor face not changing

[Chong Yidong]

> Although I am able to configure the cursor face using the usual
> custumization tool, the real colors/face doesn't change.
>
> While the customization tool added to my .emacs the line:
>    '(cursor ((t (:background "wheat" :foreground "black"))))
>
> under the faces configuration command, when emacs starts I get back
> the original cursor colors (that are just annoying because I can't see
> the character behind the cursor).
>
> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
> MacOS/NS.

I can't reproduce this, so it's likely a bug on NS.  Adrian, can you
reproduce it?

bug#3434: 23.0.91; Cursor face not changing

[Adrian Robert]

On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:

>> Although I am able to configure the cursor face using the usual
>> custumization tool, the real colors/face doesn't change.
>>
>> While the customization tool added to my .emacs the line:
>>    '(cursor ((t (:background "wheat" :foreground "black"))))
>>
>> under the faces configuration command, when emacs starts I get back
>> the original cursor colors (that are just annoying because I can't  
>> see
>> the character behind the cursor).
>>
>> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
>> MacOS/NS.
>
> I can't reproduce this, so it's likely a bug on NS.  Adrian, can you
> reproduce it?

I cannot.


Nikolaj Schumacher added later that:

> The same seems to happen for the region face.  The background color
> reverts to ns_selection_color sometime after the custom variables are
> read.  (It works when reading the custom settings again, later.)

I looked at the code and cannot see how this could be happening.  The  
region face is set to ns_selection_color in ns-win.el, but this  
should be overridden by .emacs read later.  This should have been  
cleared up by David Reitter's changes around 2009-03-14, though since  
the ChangeLog entries are incomplete it is difficult to be certain  
when the last broken code was removed.

Anyway, if you still observe these in a recent build let me know and  
I'll go on a more thorough witch-hunt.


thanks,
Adrian

bug#4194: 23.0.91; Cursor face not changing

[Nikolaj Schumacher]

Sorry for the delay. I checked this again using a build from today.

On 2009-05-31, at 17:27, Adrian Robert wrote:

> On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:
>
>>> Although I am able to configure the cursor face using the usual
>>> custumization tool, the real colors/face doesn't change.
>>
>> I can't reproduce this, so it's likely a bug on NS.  Adrian, can you
>> reproduce it?
>
> I cannot.

Setting the background color seems to work now. The foreground color,  
inverse-video, and others don't stick.

> Nikolaj Schumacher added later that:
>
>> The same seems to happen for the region face.  The background color
>> reverts to ns_selection_color sometime after the custom variables are
>> read.  (It works when reading the custom settings again, later.)
>
> I looked at the code and cannot see how this could be happening.   
> The region face is set to ns_selection_color in ns-win.el, but this  
> should be overridden by .emacs read later.  This should have been  
> cleared up by David Reitter's changes around 2009-03-14, though  
> since the ChangeLog entries are incomplete it is difficult to be  
> certain when the last broken code was removed.
>
> Anyway, if you still observe these in a recent build let me know and  
> I'll go on a more thorough witch-hunt.

I've looked at this further, and it seems to work with an empty .emacs.
It fails with my configuration, because I set the frame's background  
color like this:

   (setq default-frame-alist
         '((background-color . "#040420")
           (foreground-color . "wheat")))

If I don't set the background-color, I get my customized region face.

If I manually evaluate the line after the initial frame was created,  
any additional frame uses the default ns_selection_color for the  
region. The first frame and customize-face keep my color.


Nik

bug#4194: 23.0.91; Cursor face not changing

[Glenn Morris]

Version: 24.1

Nikolaj Schumacher wrote:

> Setting the background color seems to work now. The foreground color,
> inverse-video, and others don't stick.

In Emacs 24, the doc for the cursor face will say:

  Currently, only the `:background' attribute is meaningful; all
  other attributes are ignored.

With regards to the region face:

> This bug is easily fixed by changing the following line in ns-win.el:
>
> (set-face-background 'region "ns_selection_color")

This line was removed from ns-win some time ago, so I imagine this is
fixed too.

Please open a new report if there are still issues in the latest version.

bug#3434: 23.0.91; Cursor face not changing

[Luke Renn]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

> I looked at the code and cannot see how this could be happening.  The
> region face is set to ns_selection_color in ns-win.el, but this
> should be overridden by .emacs read later.

It probably should, but it doesn't seem to.

This bug is easily fixed by changing the following line in ns-win.el:

(set-face-background 'region "ns_selection_color")

To:

(if (not (face-attribute 'region :background))
    (set-face-background 'region "ns_selection_color"))

Tested and confirmed on a git checkout from 8/14.

The real fix may be to change when ns-win.el runs, but I didn't look into that.

Thanks,

Luke

[-- Attachment #2: Type: text/html, Size: 765 bytes --]