bug#16425: 24.3.50; Regression: mouse-face not working

bug#16425: 24.3.50; Regression: mouse-face not working

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]

On Emacs, built from HEAD (NS port):

Emacs -Q
(insert (propertize "text text" 'mouse-face '(:background "red")))

Now however over the inserted text with the mouse.

It should be highlighted in red, but nothing happens.
Worked fine in Emacs 23, and earlier versions of 24.


You can see this in customization buffers as well - buttons do not get highlighted as they should.  But notice that this does not affect the buttons surrounding the text (which change color) - just the actual text.





In GNU Emacs 24.3.50.1 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
 of 2014-01-12 on momo
Repository revision: 
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<escape> x r e p o r t - e m <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind cocoa ns multi-tty emacs)


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 203 bytes --]

bug#16425: 24.3.50; Regression: mouse-face not working

[Eli Zaretskii]

> From: David Reitter <david.reitter@gmail.com>
> Date: Sun, 12 Jan 2014 13:31:31 -0500
> 
> Emacs -Q
> (insert (propertize "text text" 'mouse-face '(:background "red")))
> 
> Now however over the inserted text with the mouse.
> 
> It should be highlighted in red, but nothing happens.
> Worked fine in Emacs 23, and earlier versions of 24.

Could this be NS version of bug #15913?  Could you (or someone with
access to NS) please try a similar fix as was done in revisions 115130
and 115281?

bug#16425: 24.3.50; Regression: mouse-face not working

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Jan 12, 2014, at 1:43 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> ould this be NS version of bug #15913?  Could you (or someone with
> access to NS) please try a similar fix as was done in revisions 115130
> and 115281?

Done, but on dice.

Even as is, ns_update_window_end calls reset_mouse_highlight, which implies the fix that was done to Win.

I thought we might have to add mouse_face_defer, like so:

  /* If a row with mouse-face was overwritten, arrange for
     frame_up_to_date to redisplay the mouse highlight.  */
  if (hlinfo->mouse_face_defer || mouse_face_overwritten_p)
    {
 	...
	}

But that still doesn't fix it.

Unlike in the bug you cite, I don't see a flicker at all.

(I do see flicker when moving the mouse over highlighted buttons while a region is selected, but I haven't managed to determine all the necessary conditions for this.)


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 203 bytes --]

bug#16425: 24.3.50; Regression: mouse-face not working

[Jan Djärv]

Hello.

12 jan 2014 kl. 19:43 skrev Eli Zaretskii <eliz@gnu.org>:

>> From: David Reitter <david.reitter@gmail.com>
>> Date: Sun, 12 Jan 2014 13:31:31 -0500
>> 
>> Emacs -Q
>> (insert (propertize "text text" 'mouse-face '(:background "red")))
>> 
>> Now however over the inserted text with the mouse.
>> 
>> It should be highlighted in red, but nothing happens.
>> Worked fine in Emacs 23, and earlier versions of 24.
> 
> Could this be NS version of bug #15913?  Could you (or someone with
> access to NS) please try a similar fix as was done in revisions 115130
> and 115281?

115281 is in xdisp.c, so it is generic.  I tried inserting the code for 115130, but it did not help.
mouse_face_overwritten_p is false in this case.  Forcing it to true did not help.

I'll bisect tomorrow.

	Jan D.

bug#16425: 24.3.50; Regression: mouse-face not working

[Jan Djärv]

Hi. 

Turns out the macfont backend didn't handle mouse face correctly. Fix checked in. 

     Jan D. 

> 12 jan 2014 kl. 20:48 skrev Jan Djärv <jan.h.d@swipnet.se>:
> 
> Hello.
> 
> 12 jan 2014 kl. 19:43 skrev Eli Zaretskii <eliz@gnu.org>:
> 
>>> From: David Reitter <david.reitter@gmail.com>
>>> Date: Sun, 12 Jan 2014 13:31:31 -0500
>>> 
>>> Emacs -Q
>>> (insert (propertize "text text" 'mouse-face '(:background "red")))
>>> 
>>> Now however over the inserted text with the mouse.
>>> 
>>> It should be highlighted in red, but nothing happens.
>>> Worked fine in Emacs 23, and earlier versions of 24.
>> 
>> Could this be NS version of bug #15913?  Could you (or someone with
>> access to NS) please try a similar fix as was done in revisions 115130
>> and 115281?
> 
> 115281 is in xdisp.c, so it is generic.  I tried inserting the code for 115130, but it did not help.
> mouse_face_overwritten_p is false in this case.  Forcing it to true did not help.
> 
> I'll bisect tomorrow.
> 
>    Jan D.
> 
> 
>