From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: Pretest next week Date: Wed, 28 Jan 2009 21:25:38 +0200 Message-ID: References: <87y6x4ue2u.fsf@cyd.mit.edu> <87mydjv4bd.fsf@cyd.mit.edu> <08054F25-1F90-4795-9FFE-01363F6900CE@gmail.com> <497E6D32.9000707@gnu.org> <87tz7kawln.fsf@cyd.mit.edu> <4980268C.9020104@gnu.org> <3765D6BE-634B-4D1E-AF8B-7822957F88C7@gmail.com> <6634D95E-39A0-410C-8F28-065D997D5208@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233170756 13974 80.91.229.12 (28 Jan 2009 19:25:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2009 19:25:56 +0000 (UTC) Cc: Chong Yidong , Jason Rumney , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 28 20:27:08 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LSG40-0004UL-Aq for ged-emacs-devel@m.gmane.org; Wed, 28 Jan 2009 20:27:06 +0100 Original-Received: from localhost ([127.0.0.1]:43138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSG2g-0003ho-2Y for ged-emacs-devel@m.gmane.org; Wed, 28 Jan 2009 14:25:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSG2c-0003hj-1Q for emacs-devel@gnu.org; Wed, 28 Jan 2009 14:25:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSG2a-0003hW-E2 for emacs-devel@gnu.org; Wed, 28 Jan 2009 14:25:37 -0500 Original-Received: from [199.232.76.173] (port=49664 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSG2a-0003hT-BH for emacs-devel@gnu.org; Wed, 28 Jan 2009 14:25:36 -0500 Original-Received: from nf-out-0910.google.com ([64.233.182.191]:33762) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LSG2Y-0000Zk-Ii; Wed, 28 Jan 2009 14:25:34 -0500 Original-Received: by nf-out-0910.google.com with SMTP id c7so1453569nfi.26 for ; Wed, 28 Jan 2009 11:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:in-reply-to:references :mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; bh=7Yvi9Onbhg4sw9dxIEQJ9HbUIta3S1pzZPKW4Od8mzY=; b=atF1K+v/ZXbX7OhnttBNu6Uh/Fdl+T9d8v/R3Zed4AbPsrot0hHpeR7thXMlQjTKju th7OMhWXizV/BgIlZdmDyjpjDfnn5qjS3gf5A5gIAmHPuadL8aDILmAXf1x8rNnRTvUm X3xYaP5Z/MgMs/huQLr8NJH2tVIXVxQd0ws6s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=in-reply-to:references:mime-version:content-type:message-id:cc :content-transfer-encoding:from:subject:date:to:x-mailer; b=l0gainw2xm4P5B5DCRux0u33vvVUSSPCmrJbhfyioqaxWgcTWgmsoZWmvngyUmg4tF Os6Dcr0355HAbSNv601stRS6M/KA+SL8n2iG3KYtkxq6xkVI1AKzgXpI5oHK6fI67+Sh xkppj1mHoC8ImokwaIUVTOfGqj+VSSqktfdVE= Original-Received: by 10.223.105.139 with SMTP id t11mr541648fao.11.1233170730752; Wed, 28 Jan 2009 11:25:30 -0800 (PST) Original-Received: from ?192.168.1.101? (i036133.gprs.dnafinland.fi [87.95.36.133]) by mx.google.com with ESMTPS id 5sm251189eyf.42.2009.01.28.11.25.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 28 Jan 2009 11:25:30 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108334 Archived-At: On Jan 28, 2009, at 7:40 PM, Stefan Monnier wrote: >> As it turns out, this isn't needed. SIGALRM is triggering >> alarm_signal_handler() in atimer.c correctly, but run_timers() >> never gets >> called under SYNC_INPUT. I don't fully understand why or where >> the problem >> is here. But undefining SYNC_INPUT gets poll_for_input() called >> (and hence >> Ctrl-g detected) even in tight loops, with no ill effects so far. > > I wrote SYNC_INPUT specifically for X11 input handling. From what you > say above, there is apparently a bug in the way it handles SIGALRM. > > Apparently the QUIT macro should check pending_atimers somehow. Yes, adding else if (pending_atimers) \ do_pending_atimers(); \ at the end of QUIT allows poll_timer() to fire under SYNC_INPUT and Ctrl-g to be detected, with no apparent other ill effects (in very limited testing). > If so, we should probably create a new > var `pending_signals', which should always reflect > "pending_timers || interrupt_input_pending" I'm not sure if the extra 0-comparison would significantly add to overhead but I guess code size could take a hit. Though maybe the part of QUIT above (when there is a quit_flag) could also be reduced to a function call to slim things down?