* bug#6690: 24.0.50; tmm-get-keymap is broken
@ 2010-07-21 15:12 Drew Adams
2010-08-01 23:43 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2010-07-21 15:12 UTC (permalink / raw
To: 6690
emacs -Q
In several of the `cond' branches the variable `str' is not defined, so
it is nil from the `let' default initialization.
Then this code raises an error "Wrong type argument: stringp, nil",
since `str' is not a string:
(unless (eq km 'ignore)
(let ((binding (where-is-internal km nil t)))
(when binding
(setq binding (key-description binding))
;; Try to align the keybindings.
(let ((colwidth (min 30 (- (/ (window-width) 2) 10))))
;; STR is nil - so cannot use `string-width' or `concat'.
(setq str
(concat str
(make-string (max 2 (- colwidth
(string-width str)
(string-width binding)))
?\s)
binding))))))
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-07-19 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6690: 24.0.50; tmm-get-keymap is broken
2010-07-21 15:12 bug#6690: 24.0.50; tmm-get-keymap is broken Drew Adams
@ 2010-08-01 23:43 ` Stefan Monnier
2014-02-03 23:45 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2010-08-01 23:43 UTC (permalink / raw
To: Drew Adams; +Cc: 6690
> emacs -Q
> In several of the `cond' branches the variable `str' is not defined, so
> it is nil from the `let' default initialization.
> Then this code raises an error "Wrong type argument: stringp, nil",
> since `str' is not a string:
> (unless (eq km 'ignore)
> (let ((binding (where-is-internal km nil t)))
> (when binding
> (setq binding (key-description binding))
> ;; Try to align the keybindings.
> (let ((colwidth (min 30 (- (/ (window-width) 2) 10))))
> ;; STR is nil - so cannot use `string-width' or `concat'.
> (setq str
> (concat str
> (make-string (max 2 (- colwidth
> (string-width str)
> (string-width binding)))
> ?\s)
> binding))))))
Thanks for the report. Indeed, the code is brittle in this regard.
I could easily work around the problem by checking `str' before taking
its width (concat should work just fine with nil), but before I do that,
I'd like to make sure the result (which would basically treat a nil as
equivalent to "") is right, so could you give some example where the
problem gets triggered (in all "reasonable" cases I can think of, str
ends up being non-nil since otherwise it means the menu entry would
have a valid command and a valid shortcut, but no name).
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6690: 24.0.50; tmm-get-keymap is broken
2010-08-01 23:43 ` Stefan Monnier
@ 2014-02-03 23:45 ` Lars Ingebrigtsen
2014-02-04 3:00 ` Drew Adams
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-03 23:45 UTC (permalink / raw
To: Stefan Monnier; +Cc: 6690
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I'd like to make sure the result (which would basically treat a nil as
> equivalent to "") is right, so could you give some example where the
> problem gets triggered (in all "reasonable" cases I can think of, str
> ends up being non-nil since otherwise it means the menu entry would
> have a valid command and a valid shortcut, but no name).
More information was requested three years ago, but no further progress
has been made. Is this bug still present in Emacs 24.3?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6690: 24.0.50; tmm-get-keymap is broken
2014-02-03 23:45 ` Lars Ingebrigtsen
@ 2014-02-04 3:00 ` Drew Adams
0 siblings, 0 replies; 4+ messages in thread
From: Drew Adams @ 2014-02-04 3:00 UTC (permalink / raw
To: Lars Ingebrigtsen, Stefan Monnier; +Cc: 6690
> More information was requested three years ago, but no further
> progress has been made. Is this bug still present in
> Emacs 24.3?
More precisely, Stefan said:
> Indeed, the code is brittle in this regard.
> I could easily work around the problem by checking `str'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> before taking its width (concat should work just fine with nil),
> but before I do that, I'd like to make sure the result (which
> would basically treat a nil as equivalent to "") is right...
I have no way to determine that more that he does (and did).
Sorry, it's been 3 years and I don't have anything more to offer
about this. If you don't want to make the code less brittle and
fix the case where the value is nil, so be it.
Personally, I don't use tmm anyway. It's possible that I
happened to notice this problem when looking at the code.
Or perhaps I ran into it while experimenting with the code.
I really don't know.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-04 3:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-21 15:12 bug#6690: 24.0.50; tmm-get-keymap is broken Drew Adams
2010-08-01 23:43 ` Stefan Monnier
2014-02-03 23:45 ` Lars Ingebrigtsen
2014-02-04 3:00 ` Drew Adams
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.