From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Tue, 29 May 2012 12:06:48 -0700 Message-ID: References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1338318469 3761 80.91.229.3 (29 May 2012 19:07:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 May 2012 19:07:49 +0000 (UTC) Cc: cyd@gnu.org, 1169@debbugs.gnu.org To: "'Johan =?UTF-8?Q?Bockg=C3=A5rd'?=" , "'Lars Magne Ingebrigtsen'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 29 21:07:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZRlh-00010B-2b for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 May 2012 21:07:45 +0200 Original-Received: from localhost ([::1]:50680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZRlg-0000vn-O6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 May 2012 15:07:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZRlc-0000v2-TF for bug-gnu-emacs@gnu.org; Tue, 29 May 2012 15:07:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZRlb-0004iw-62 for bug-gnu-emacs@gnu.org; Tue, 29 May 2012 15:07:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZRlb-0004ht-2S for bug-gnu-emacs@gnu.org; Tue, 29 May 2012 15:07:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SZRmw-0006RE-1E for bug-gnu-emacs@gnu.org; Tue, 29 May 2012 15:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 May 2012 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1169 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 1169-submit@debbugs.gnu.org id=B1169.133831852224722 (code B ref 1169); Tue, 29 May 2012 19:09:01 +0000 Original-Received: (at 1169) by debbugs.gnu.org; 29 May 2012 19:08:42 +0000 Original-Received: from localhost ([127.0.0.1]:48735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZRmb-0006Qg-6Z for submit@debbugs.gnu.org; Tue, 29 May 2012 15:08:41 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:19816) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZRmY-0006QU-PC for 1169@debbugs.gnu.org; Tue, 29 May 2012 15:08:39 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4TJ77Jk011784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 May 2012 19:07:07 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4TJ76JG008773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 May 2012 19:07:06 GMT Original-Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4TJ75uH009890; Tue, 29 May 2012 14:07:05 -0500 Original-Received: from dradamslap1 (/10.159.177.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 29 May 2012 12:07:05 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehq251b9.fsf@gnu.org> Thread-Index: Ac09wtKbCr0DveHCSUK8Z7FK5IC+pQACTEGw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60476 Archived-At: > This change breaks the highlighting code in `help-make-xrefs' which > assumes that a list of key bindings produced by > substitute-command-keys > (in `documentation') ends with an extra blank line: > > (while (re-search-forward "^key +binding\n\\(-+ +\\)-+\n\n" > nil t) > (let ((col (- (match-end 1) (match-beginning 1)))) > (while > (and (not (eobp)) > ;; Stop at a pair of blank lines. > (not (looking-at "\n\\s-*\n"))) > > Example: > emacs -Q > C-h m > C-x o > M-> > > Note the highlighted "or"s in the last two paragraphs. So maybe a different fix is needed. Some fix for 1169 is needed, in any case. But the visual change I see from a build from 2011-07-11 and a build from 2011-07-18 (and later builds) is that function names are now links (which is generally a good thing). Isn't that a separate thing (feature) from the fix for bug #1169? That function-name highlighting can sometimes be "off" - highlighting the word `or' as if it was intended as the function `or', seems a separate problem from `substitute-command-keys' adding an extra newline char. No?