From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59662: 29.0.50; [PATCH] Add treesit--indent-defun Date: Fri, 02 Dec 2022 22:19:21 +0100 Message-ID: References: <5B538888-E454-4F75-B3B8-AB20E10B3E89@gmail.com> <83o7sniokt.fsf@gnu.org> <56840149-5EB9-4C22-841F-45F410BFC885@thornhill.no> <83edtjimyo.fsf@gnu.org> <875yet975l.fsf@thornhill.no> <87y1rp7dw2.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35186"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59662@debbugs.gnu.org, casouri@gmail.com, eliz@gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 22:21:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1DT6-0008sC-22 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 22:21:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1DSy-0008EQ-32; Fri, 02 Dec 2022 16:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1DSw-0008EA-VA for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1DSw-0007MI-N9 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1DSw-0001Sp-J0 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: "Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 59662@debbugs.gnu.org, casouri@gmail.com, Eli Zaretskii Original-Received: via spool by 59662-submit@debbugs.gnu.org id=B59662.16700160035572 (code B ref 59662); Fri, 02 Dec 2022 21:21:02 +0000 Original-Received: (at 59662) by debbugs.gnu.org; 2 Dec 2022 21:20:03 +0000 Original-Received: from localhost ([127.0.0.1]:48946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1DRy-0001Rm-Dw for submit@debbugs.gnu.org; Fri, 02 Dec 2022 16:20:02 -0500 Original-Received: from out-53.mta0.migadu.com ([91.218.175.53]:11601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1DRv-0001RL-Mi for 59662@debbugs.gnu.org; Fri, 02 Dec 2022 16:20:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670015998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ta57AbVJQWdvhC8nEh452/9Dkg57u6OltnmT03RA0Ng=; b=X7DTbHdplyAF4alKN1sbP04VF6cKhSFimpXAQT2jU0bjWckMUCBAq2XohiPse1hbb+OALU LyeUOCmehrpMTHtoCQ2/lGBqcdosnd5J1PhQ2zCA76oexJmJ2w3St9f/g83i1oanGqu+5E CoMrexBpM+2mUvsM+Tig5A5CtvOLTaxj8Rzcz2LvkFxEmSPY4a/FS2Tzn3VecSgANdItXv QeYXipec9OvU/alhvMU8u/BnKNauvzXYJaqb13+jNnLqc4+Evq93EjBkkvyUm9eohVx6zq xzLMBIY6hMFfK0aGNeI7gzVXrlZtpwH28H2tUXyDHNY4UUiA7MFRJWyBuLQe7Q== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249787 Archived-At: On 2 December 2022 22:09:55 CET, "Daniel Mart=C3=ADn" wrote: >Theodor Thornhill writes: > >> Right - thanks=2E However, this makes me wonder - should we really be >> setting mark here? I see that c-indent-defun does not, and it feels >> weird that indenting adds to the mark ring=2E What do you think? My >> first patch used >> >> (indent-region >> (treesit-node-start node) >> (treesit-node-end node)) >> >> Which behaves similarly to c-indent-defun=2E >> >> See attached patch=2E > >I don't have a strong opinion, but if we can indent without setting the >mark, I think it'd be a cleaner command=2E Specially if c-indent-defun >doesn't set the mark either=2E Yeah, we don't need to set the mark=2E Thanks for the feedback :) Theo