From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default Date: Sat, 7 Jan 2023 17:31:16 -0800 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26444"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Kangas , 60511@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 08 02:32:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEKXr-0006gQ-GB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Jan 2023 02:32:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEKXd-0003El-Lg; Sat, 07 Jan 2023 20:32:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEKXa-0003Eb-MS for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 20:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEKXa-0005nr-Ef for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 20:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEKXZ-0003dL-Tb for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 20:32:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jan 2023 01:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60511 X-GNU-PR-Package: emacs Original-Received: via spool by 60511-submit@debbugs.gnu.org id=B60511.167314148613928 (code B ref 60511); Sun, 08 Jan 2023 01:32:01 +0000 Original-Received: (at 60511) by debbugs.gnu.org; 8 Jan 2023 01:31:26 +0000 Original-Received: from localhost ([127.0.0.1]:59417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEKX0-0003ca-7H for submit@debbugs.gnu.org; Sat, 07 Jan 2023 20:31:26 -0500 Original-Received: from mail-pl1-f171.google.com ([209.85.214.171]:34730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEKWy-0003cK-6q for 60511@debbugs.gnu.org; Sat, 07 Jan 2023 20:31:24 -0500 Original-Received: by mail-pl1-f171.google.com with SMTP id v23so875904plo.1 for <60511@debbugs.gnu.org>; Sat, 07 Jan 2023 17:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=SRKq/52utqhoWW4iA/v2FsLax6uMK0yON4SaHYK2DwY=; b=FdqeUJeTYFiCOEdhBwBU8UDRQyJJBTELmUD1eyk+zm9JNnmXDktzg+ZyCSh+4pA8GW jY08aiVDo8AJNF2bLGrBXlhXNSGpkwrTkdiK0NpM8HeST8BJlTmH1XpteuBHoXgiWHHm l4+f99/yqinwETSM/DCDoqIlqs+FtalQIsHptH9zexViS+9TSnAj1MpkN/BXfmFvDr9B 82bGcrxZ5hmJVKQ5+6iHfvPD7hFd3ZxHa7ewAf9u1kMKWFhWA3Je9PqgbV8n9r27r3Cm zKmiSJVDMbIfWZyWZ3F0XIRfvgGhcckqe3o55XR2vzp68/Nq5iMJCb1siWqEwhyaOcs+ 0vnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SRKq/52utqhoWW4iA/v2FsLax6uMK0yON4SaHYK2DwY=; b=5LfXmYEJlnKwlkDZ4hG4OrOmxkqMQxzLsbMyj97X/Sx909x3NeTXL8vEwvmvIuJc1a NjWyagvJA6N5tR2ZQE60kt60zebkRIMpQr2D+cS5xI5mPEu4pClje8bD07JxkiZuw8OI kdOiJYqFU4oym0xTy3ERu2nQPmgkE57oijS70+j222ZMzR68X67cLP5HqPplM7fm5Db+ NjxIXtiMiB9bT9AZawnS2ZylYCuOj5nlnuTo8U/ezL/QlosuDQ413p0n1bSY+Jhg8RuE s8x5iHDfXCWtKEF5Qdc1i2CmW/mItaVrugs1gJBeVmbir4xMvDV9SEl0RjNxv+4r0Frt jZ/A== X-Gm-Message-State: AFqh2kpB4nM8m9N0oOGvDGxDy7xl0w8ArIhOzincjYQiGHEUGeDQlNOs UAaGvaGqFsji5fopa3+v5SE= X-Google-Smtp-Source: AMrXdXuhxk1V5A5/gHWUoh1IrE7WMci42xj6d4yu86IQu5ohdtHki9gyRKmoC7Ht5jBQ02JzvG4Jkw== X-Received: by 2002:a17:90a:7788:b0:226:f2a0:8723 with SMTP id v8-20020a17090a778800b00226f2a08723mr3633137pjk.42.1673141478125; Sat, 07 Jan 2023 17:31:18 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id t11-20020a17090a448b00b00226f49eca92sm1646408pjg.28.2023.01.07.17.31.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jan 2023 17:31:17 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252858 Archived-At: Juri Linkov writes: >>>> This currently emits a warning if the ruby grammar is not = installed: >>>> >>>> (treesit-ready-p 'ruby) >>>> >>>> I think it should *not* emit a warning, as no other predicates in = Emacs >>>> do (e.g. `featurep', `integerp', etc.). >>>> >>>> It could have an optional flag to emit a warning, if there's a = strong >>>> need for that. But personally, I'd rather see a new function for = that. >>>> >>>> I also don't see much need for the `message' symbol as the second >>>> argument, so I'd simplify the API by dropping that part. It's = currently >>>> unused in our tree. >>> >>> Like the argument NOERROR of `require', the argument QUIET of = `treesit-ready-p' >>> could do the same. >> >> Maybe rename it to treesit-check-readiness? > > I think treesit-ready-p already is a good name. > We just need to support more values in its argument QUIET, > with a new value that does nothing in case of an error, > and just returns nil. It already has such option: if QUIET is t, treesit-ready-p returns nil = and don=E2=80=99t emit anything. I can make treesit-ready-p not emit any warning by default, and change the quiet parameter to WARN, and accept either 'warn or =E2=80=98message. Basically: (treesit-ready-p lang) =3D> t/nil (treesit-ready-p lang 'warn) =3D> t/emit warning (treesit-ready-p lang 'message) =3D> t/message Eli, WDYT? Yuan