From: Yuan Fu <casouri@gmail.com>
To: Noah Peart <noah.v.peart@gmail.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>, Eli Zaretskii <eliz@gnu.org>,
67031@debbugs.gnu.org
Subject: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements
Date: Fri, 24 Nov 2023 19:48:43 -0800 [thread overview]
Message-ID: <B1C2751D-AC6E-481D-B509-140325D3DA85@gmail.com> (raw)
In-Reply-To: <D77A3FBE-D79B-4A5D-9333-7D9BD264FF16@gmail.com>
> On Nov 24, 2023, at 7:46 PM, Yuan Fu <casouri@gmail.com> wrote:
>
>
>
>> On Nov 20, 2023, at 10:13 AM, Noah Peart <noah.v.peart@gmail.com> wrote:
>>
>> Sorry, ignore the previous patch. A couple additional rules were needed to handle
>> "while" and "else".
>>
>> On Mon, Nov 20, 2023 at 10:07 AM Noah Peart <noah.v.peart@gmail.com> wrote:
>> Here is an updated patch with the added "else_clause" and indentation test for
>> statements without braces.
>>
>> On Mon, Nov 20, 2023 at 4:55 AM Noah Peart <noah.v.peart@gmail.com> wrote:
>> Yea, I'm using the same. But, would it be useful to have a way to set that when
>> running tests without needing to temporarily add set `treesit-extra-load-path` in
>> the test file?
>>
>> On Sun, Nov 19, 2023 at 5:38 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
>> On 19/11/2023 08:08, Eli Zaretskii wrote:
>>>> Date: Sun, 19 Nov 2023 03:24:49 +0200
>>>> Cc:casouri@gmail.com,67031@debbugs.gnu.org
>>>> From: Dmitry Gutov<dmitry@gutov.dev>
>>>>
>>>> On 19/11/2023 02:12, Noah Peart wrote:
>>>>> Yea, I can do that.
>>>>>
>>>>> Is there a recipe for running the tests with a tree-sitter library path?
>>>> You mean with the default tree-sitter librayr path overridden? I'm not sure.
>>> Why would an ERT test need that? We are supposed to test Emacs with
>>> the otherwise installed system features. As tree-sitter grammars are
>>> not part of Emacs, there should be no need to tell Emacs to use a
>>> grammar library other than the one installed on the system. Right?
>>
>> We have a way to override that with the variable
>> treesit-extra-load-path, so it follows that some users will take
>> advantage of it to add extra directories.
>>
>> I'm using ~/.emacs.d/tree-sitter/ myself.
>> <typescript-ts-mode-indentation.patch>
>
> That’s great! Is there anything else blocking us from applying this patch? Does Noah have the copyright assignment?
Never mind, just saw the follow-up. My email client’s threading has been messed up and some messages ended up in different threads :-(
Yuan
next prev parent reply other threads:[~2023-11-25 3:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 1:29 bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements nvp
2023-11-15 13:40 ` Eli Zaretskii
2023-11-16 1:18 ` Dmitry Gutov
2023-11-18 10:05 ` Eli Zaretskii
2023-11-19 0:12 ` Noah Peart
2023-11-19 1:24 ` Dmitry Gutov
2023-11-19 6:08 ` Eli Zaretskii
2023-11-19 7:19 ` Noah Peart
2023-11-19 13:38 ` Dmitry Gutov
2023-11-20 12:55 ` Noah Peart
2023-11-20 18:07 ` Noah Peart
2023-11-20 18:13 ` Noah Peart
2023-11-20 22:28 ` Dmitry Gutov
2023-11-21 3:27 ` Eli Zaretskii
2023-11-21 4:41 ` Noah Peart
2023-11-21 11:44 ` Eli Zaretskii
2023-11-21 14:09 ` Dmitry Gutov
2023-11-21 14:23 ` Eli Zaretskii
2023-11-21 14:27 ` Dmitry Gutov
2023-11-25 3:46 ` Yuan Fu
2023-11-25 3:48 ` Yuan Fu [this message]
2023-11-19 4:26 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1C2751D-AC6E-481D-B509-140325D3DA85@gmail.com \
--to=casouri@gmail.com \
--cc=67031@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.