From: Chad Brown <yandros@MIT.EDU>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org, "Randal L. Schwartz" <merlyn@stonehenge.com>
Subject: Re: recent commit broke src/dired.c on OSX
Date: Sun, 25 Jul 2010 13:12:26 -0700 [thread overview]
Message-ID: <B1AA71C7-71B2-4E64-B2C9-821C2AC440D1@mit.edu> (raw)
In-Reply-To: <AANLkTinviMWF8Wo24CJhs9PrD8jp4ZeoJsvN22bJ_S=u@mail.gmail.com>
I think Randal was on to something before; on my system, it's necessary to remove the declaration of opendir() from dired.c (it conflicts with the definition in <dirent.h>).
The resulting build gives warnings:
dired.c: In function ‘Ffile_attributes’:
dired.c:1016: warning: comparison is always false due to limited range of data type
dired.c:1016: warning: comparison is always false due to limited range of data type
dired.c:1020: warning: comparison is always false due to limited range of data type
dired.c:1020: warning: comparison is always false due to limited range of data type
dired.c:1068: warning: comparison is always false due to limited range of data type
dired.c:1068: warning: comparison is always false due to limited range of data type
but seems to run. I haven't had a chance to test it extensively yet.
It seems that Darwin's dirent.h prototype is:
DIR *opendir(const char *)
which conflicts with dired.c's unconditional (ifndef MSDOS) declaration:
extern DIR *opendir(char *)
I have to run of now and help a friend move, but I can try to dig into this a little more when I return this evening, if it will help.
Thanks,
*Chad
next prev parent reply other threads:[~2010-07-25 20:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 17:23 recent commit broke src/dired.c on OSX Randal L. Schwartz
2010-07-25 17:30 ` Juanma Barranquero
2010-07-25 17:40 ` Randal L. Schwartz
2010-07-25 17:51 ` Juanma Barranquero
2010-07-25 17:58 ` Randal L. Schwartz
2010-07-25 18:04 ` Juanma Barranquero
2010-07-25 20:12 ` Chad Brown [this message]
2010-07-25 20:39 ` Juanma Barranquero
2010-07-26 2:46 ` Chad Brown
2010-07-26 3:12 ` Chad Brown
2010-07-26 3:43 ` Juanma Barranquero
2010-07-26 8:44 ` David Kastrup
2010-07-26 9:58 ` Juanma Barranquero
2010-07-26 6:02 ` Jan Djärv
2010-07-26 6:33 ` Jan Djärv
2010-07-26 16:58 ` Eli Zaretskii
2010-07-27 21:40 ` Chad Brown
2010-07-27 23:18 ` Juanma Barranquero
2010-07-27 23:28 ` Óscar Fuentes
2010-07-28 0:16 ` Juanma Barranquero
2010-07-28 0:33 ` Óscar Fuentes
2010-07-28 0:45 ` Juanma Barranquero
2010-07-28 0:54 ` Óscar Fuentes
2010-07-28 0:58 ` Juanma Barranquero
2010-07-28 6:32 ` Jan Djärv
2010-07-25 20:44 ` Eli Zaretskii
2010-07-29 18:21 ` Randal L. Schwartz
2010-07-29 19:11 ` Jan Djärv
2010-07-29 19:19 ` Randal L. Schwartz
2010-07-29 19:29 ` Chad Brown
2010-07-29 20:09 ` Jan Djärv
2010-07-29 20:37 ` Óscar Fuentes
2010-07-29 21:07 ` Jan Djärv
2010-07-29 21:17 ` Óscar Fuentes
2010-07-29 23:19 ` Chad Brown
2010-07-25 20:50 ` Dan Nicolaescu
2010-07-25 20:54 ` Juanma Barranquero
2010-07-25 20:59 ` Eli Zaretskii
2010-07-25 21:26 ` Jan Djärv
2010-07-25 21:32 ` Jan Djärv
2010-07-25 17:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1AA71C7-71B2-4E64-B2C9-821C2AC440D1@mit.edu \
--to=yandros@mit.edu \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.