From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Date: Sat, 6 Apr 2013 19:00:57 -0700 Message-ID: References: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1365300105 19485 80.91.229.3 (7 Apr 2013 02:01:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Apr 2013 02:01:45 +0000 (UTC) Cc: 14153@debbugs.gnu.org To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 07 04:01:48 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOevT-0004bF-Qu for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2013 04:01:47 +0200 Original-Received: from localhost ([::1]:32921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOevT-0006FF-Fn for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2013 22:01:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOevN-0006Ew-05 for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 22:01:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOevL-0001KH-3U for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 22:01:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOevL-0001K5-0W for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 22:01:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UOeyc-00034K-98 for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 22:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2013 02:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14153-submit@debbugs.gnu.org id=B14153.136530027811764 (code B ref 14153); Sun, 07 Apr 2013 02:05:02 +0000 Original-Received: (at 14153) by debbugs.gnu.org; 7 Apr 2013 02:04:38 +0000 Original-Received: from localhost ([127.0.0.1]:37569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOeyC-00033g-PD for submit@debbugs.gnu.org; Sat, 06 Apr 2013 22:04:38 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:22274) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOeyA-00033V-8T for 14153@debbugs.gnu.org; Sat, 06 Apr 2013 22:04:35 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r37217LA001822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 7 Apr 2013 02:01:08 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r37216xx022348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 7 Apr 2013 02:01:07 GMT Original-Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r37216Tu017757; Sun, 7 Apr 2013 02:01:06 GMT Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Apr 2013 19:01:06 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac4zKU2qR5wxoWbkQ0WBOmwgSleQYgACXVPw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73228 Archived-At: > > Each such function should accept 4 args, as follows: > > > CHOICE - the string to insert in the buffer, > > BUFFER - the buffer in which the choice should be inserted, > > MINI-P - non-nil if BUFFER is a minibuffer, and > > BASE-SIZE - the number of characters in BUFFER before > > the string being completed. > > Duh, sorry indeed, could you please update this docstring to > match the code? Sorry, I don't know what the new code parameters mean. S?he who changes the signature is best placed to update the spec/doc of that signature. > > But `crm--choose-completion-string' expects these args: > > (CHOICE BUFFER BASE-POSITION &rest IGNORED) > > Which is indeed the correct calling convention nowadays. How do you deal with older code that calls with a MINI-P parameter? It's one thing to ignore old parameters that you don't need anymore. It's quite another thing to change the signature so much that old calls provoke errors. This is apparently not about some particular function such as `crm--choose-completion-string'. It is about `choose-completion-string-functions', which has been around a long time and is a general purpose hook. Anyway, since you've changed the code, please change the doc string accordingly, whatever that might mean/entail. Thx. If you really need help with the wording, then communicate the meaning (content), and I will be glad to suggest wording.