bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[ndame]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

I was working on a big text data file and I used flush-lines and instead of it saying
nothing it would have been nice to know how many lines were flushed by it.

The same goes for keep-lines. It should say in a message how many lines it flushed
while keeping the matching lines.

[-- Attachment #2: Type: text/html, Size: 307 bytes --]

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[Noam Postavsky]

# closing accidental dupe
forwarded 39908 https://debbugs.gnu.org/39907
close 39908
severity 39907 wishlist
quit

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[Eli Zaretskii]

> Date: Wed, 4 Mar 2020 16:42:40 +0000 (GMT)
> From: ndame <emacsuser@freemail.hu>
> 
> I was working on a big text data file and I used flush-lines and instead of it saying
> nothing it would have been nice to know how many lines were flushed by it.
> 
> The same goes for keep-lines. It should say in a message how many lines it flushed
> while keeping the matching lines.

Upgrade to Emacs 27, this happens there already.

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[ndame]

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

>  Upgrade to Emacs 27, this happens there already.

Great, sorry for the noise then. This report can be closed.

[-- Attachment #2: Type: text/html, Size: 133 bytes --]

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[Juri Linkov]

tags 39907 notabug
close 39907 28.0.50
quit

>>  Upgrade to Emacs 27, this happens there already.
>
> Great, sorry for the noise then. This report can be closed.

Thanks for the report, closed.

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[ndame]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

 >  Upgrade to Emacs 27, this happens there already.

I checked the news, but it only mentions flush-lines.

It is also useful for keep-lines to say how many lines it removed, instead
of saying nothing.

[-- Attachment #2: Type: text/html, Size: 246 bytes --]

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[Juri Linkov]

>  >  Upgrade to Emacs 27, this happens there already.
>
> I checked the news, but it only mentions flush-lines.
>
> It is also useful for keep-lines to say how many lines it removed, instead
> of saying nothing.

keep-lines can't say how many lines it removed, because it doesn't know the number.
And reimplementing it to count the number of removed lines will make it slower.

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[ndame]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

 
> keep-lines can't say how many lines it removed, because it doesn't know the number.
> And reimplementing it to count the number of removed lines will make it slower.

keep-lines has two delete-region calls in two separate cases. Even counting only
these deletions and saying "x deletions were performed" is more informative than
saying nothing. It doesn't have to say "number of lines".

I guess most users use it to remove whole lines most of the time, so the match
is usually not split across lines, therefore the number of deletions in these cases is
equal to the number of deleted lines.

 

[-- Attachment #2: Type: text/html, Size: 721 bytes --]

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[Noam Postavsky]

ndame <emacsuser@freemail.hu> writes:

> I guess most users use it to remove whole lines most of the time, so the match
> is usually not split across lines, therefore the number of deletions in these cases is
> equal to the number of deleted lines.

That would apply to flush-lines (and I think the current counting code
does make that assumption), but not keep-lines.  For keep-lines, if
matches don't span lines, then the number of lines is equal to the
number of lines kept, rather than lines deleted.  And there is less
usefulness in reporting lines kept, since the user can see that directly
(or use M-= (count-words-region)).

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[ndame]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

> For keep-lines, if
> matches don't span lines, then the number of lines is equal to the
> number of lines kept, rather than lines deleted. And there is less
> usefulness in reporting lines kept,

I agree, that's why I suggested keep-lines should also count and report
the number of deletions performed which can be useful info.

This is easy to do by incrementing a counter at the two delete-region calls
in keep-lines.

[-- Attachment #2: Type: text/html, Size: 504 bytes --]

bug#39908: 26.2; flush-lines and keep-lines should say how many lines were flushed

[Noam Postavsky]

ndame <emacsuser@freemail.hu> writes:

> report the number of deletions performed which can be useful info.
>
> This is easy to do by incrementing a counter at the two delete-region calls
> in keep-lines.

No, you are mistaken.  For keep-lines, the number of deletions is equal
to the number of kept lines.  Only for flush-lines the number of
deletions is the same as the number of deleted lines (in both cases,
assuming all matches are on single lines).