all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: Noah Peart <noah.v.peart@gmail.com>
Cc: 71209@debbugs.gnu.org, Dmitry Gutov <dmitry@gutov.dev>
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Date: Sat, 01 Jun 2024 01:09:34 +0000	[thread overview]
Message-ID: <AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev> (raw)
In-Reply-To: <CAPVBTScr+MC=TBjACN9F1iD=q4OoMFfmJYhu6VU8RmeAEhnpBg@mail.gmail.com>

On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart@gmail.com> wrote:
> > it seems we already highlight this when at treesit-font-lock-level 4?
> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't
> they be getting `font-lock-variable-name-face` in the 'definition feature?
> 

Indeed, thanks. Could someone please install the patch? Thanks in advance.

Seems like c++-ts-mode will need to get updated too, as with:
for (const auto& i : things) {}
i gets font-lock-variable-use-face. I wonder if any other ts modes
have similar issues.





  parent reply	other threads:[~2024-06-01  1:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-26 12:41 bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Noah Peart
2024-05-28  2:46 ` Randy Taylor
2024-05-30 13:25   ` Noah Peart
2024-05-30 23:23     ` Dmitry Gutov
2024-06-01  1:09     ` Randy Taylor [this message]
2024-06-01  1:42       ` Noah Peart
2024-06-01  1:50         ` Noah Peart
2024-06-01 14:13           ` Dmitry Gutov
2024-06-01  1:51         ` Dmitry Gutov
2024-06-01  1:56           ` Noah Peart
2024-06-01  1:59             ` Dmitry Gutov
2024-06-01  2:04               ` Noah Peart
2024-06-01 14:13         ` Dmitry Gutov
2024-06-15  7:56           ` Eli Zaretskii
2024-06-27  7:38             ` Eli Zaretskii
2024-06-27  9:29               ` Noah Peart
2024-07-06  7:46                 ` Eli Zaretskii
2024-07-20  9:42                   ` Eli Zaretskii
2024-08-04  7:52                     ` Eli Zaretskii
2024-06-01  1:56       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AdChXDjyAulWCxyswxNe-7IMxwPnhNsGnE-QxJ3BN3-HqbU3GhOFti8yQLH_D-euvftZoKEHO6Bvwb1gXojFkT4JhTstpo8Ad-Dqp7nhebE=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=71209@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=noah.v.peart@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.