From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cyril Arnould Newsgroups: gmane.emacs.bugs Subject: bug#63251: AW: bug#63251: 28.2; vhdl-mode contribution Date: Sat, 6 May 2023 12:53:23 +0000 Message-ID: References: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Reto Zimmermann , Eli Zaretskii To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , "63251@debbugs.gnu.org" <63251@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 14:54:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvHQe-0001yH-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 14:54:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvHQM-0003nH-6W; Sat, 06 May 2023 08:54:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHQI-0003my-J8 for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 08:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvHQH-0007Ly-Vt for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 08:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvHQH-0007P9-Re for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 08:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Cyril Arnould Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63251 X-GNU-PR-Package: emacs Original-Received: via spool by 63251-submit@debbugs.gnu.org id=B63251.168337761428429 (code B ref 63251); Sat, 06 May 2023 12:54:01 +0000 Original-Received: (at 63251) by debbugs.gnu.org; 6 May 2023 12:53:34 +0000 Original-Received: from localhost ([127.0.0.1]:59642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHPp-0007OS-Ji for submit@debbugs.gnu.org; Sat, 06 May 2023 08:53:34 -0400 Original-Received: from mail-vi1eur05olkn2106.outbound.protection.outlook.com ([40.92.90.106]:35557 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvHPl-0007OD-Ly for 63251@debbugs.gnu.org; Sat, 06 May 2023 08:53:31 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8GxanQy6aF3Q2N68/B8/DUd5WZydtlNsehDkC9B3YCzLr91VTVobq1bRtxF+7nsFiI1OTTMmjmL82j2eazj2KVxMWgUpDsFuv43ZdjCSWRI/io9ilZN79z4NKh0WTiQG/gtrkky04Qc53x8bNbmjetoELd5C+q/4Rc2P/fzmEY5HUBwz9rRINclYl0rnEAHzo9YdQR6AQApOWuTPLmWDKXlUl5Lo0IXAA9OjuEnAOpQ/U9SqEpCcxuFU94TrHUrJ0naJFnW28taRWG5LJ0zpUhy8Qt+5vOzybwUc3iHTBBXrESheUqhKxDhhhHqAxa3j0QsKg2sm2wbw62zVyFpuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUI8MaA8WIImuqewLVlQkSyXRq8aAZ0ISE0z232r/gQ=; b=lJtSKvZt52R4u9JWSz9vW7ujCI9oK1Rl7yssoUXvpTXktkILTOUIdXMOf+f+3fVJPa3P01bn3eD1h4QG7UBrQIvDYaJv4ql5q4FhD5PUTFFLG5gpssfBG0O64neFWZs4YPCaF2KFANyoq0VeKjRNOFEBXDcqTKvlmMr7AKoE6umMQiiv9Nh5xAG7w1/jrkFc61OoIvuZSAx40Ni/CJgjrCsCBUxA9yvbukUwpCqEnEaWLZis4VLEB3yEJR22mm8Oz+FkuKIqOVBiS+lQHDOJ5T2386dMcz6lPZfLoKT6wyHFgCVHxjA1lloS5uIidfnYxosDOGsFvQLuglgkEKbQqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rUI8MaA8WIImuqewLVlQkSyXRq8aAZ0ISE0z232r/gQ=; b=CWXh2rshgdZ6Il8mOEHwCvFGm3njDE2FnOBbRwsJLoFPU9C9rzJud05lWn1He5GsJaf7BgD5xW8YrUlMxn4d9k7V0ZV+tCp3xQJbcxVXyZvT5WaDzmxTM32af1jaYglLkw3CEzBuWjNXzkHeLHQVwHgEOQurWRXyQFW9dX709RTfeQGTTnt6o2sbgmTZdFW4miHkbKWX68Y3hG61WaSIzeah6Yk2mWtXIK1k/wdu3OKCdIs+0kTpCr+DvoHpVVgNJ2xZJHwWDikV+Rnvxu+RkoQyQWQsh+H9vAem5g7NereIIWzyIAbxDJdwXwcU2XXa5C44dngo/L+SVKZ7A81lQA== Original-Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by DU2PR10MB7908.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:49b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29; Sat, 6 May 2023 12:53:23 +0000 Original-Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.029; Sat, 6 May 2023 12:53:23 +0000 Thread-Topic: bug#63251: 28.2; vhdl-mode contribution Thread-Index: AQHZf/xS6WFPgZRzfky0YujufV2RU69NM2m0 In-Reply-To: <564BC9FB-248F-4973-9D8C-C1DA7D3D60C6@gmail.com> Accept-Language: de-CH, en-US Content-Language: de-CH x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [SrhmvkJE0F4pv0cuXANA+Sg+8xBWd5jH] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|DU2PR10MB7908:EE_ x-ms-office365-filtering-correlation-id: e5e98ca1-0f51-4401-c5dd-08db4e30e051 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3fFSunFZ4sdTU15ddcJ9xhtS/fYClAsMHA1pwJ+Av77t06l7lX7bwaX55sZGrhd9C9lWnLayPp1z4XDZ1x7WSa1fv5LzvvCClFpvDpk4kIk1eVp9dKZ1dtJ+MF+PLV703Z0DzNYXMD87NdeJ3X8VgBcwldypQvEtwiEc2NoSu6v0gWS3yD97lt+VareQCqRrhgguRgoo52SqfYy47e/7NfOONw/j8PGx+lST5SFIrsgq6By0fMAnBi10B20qFoAkydvfH0Yev5jheReg+Ka04HPbZ0bB/asYx1BGe43f+oPMT3MoStmbenqpphIAS5OwT64udq/ikPWDsLKRqokwrvUhESddGObgHQX4sKI/HjLfIx9Cz0zLet8527VHtUwnWHL8GAC469elwIBdv2/w6ZgvrIxiDGT7weDUgl4tsJ5y6gKOLTooPXQ3ui809vGfLHjHTSv0XdKcFb4sITwIiZlM7iviqO1R1V3IQM0vMi5nWlcK3dKZ3vJZIeMalkr1331/8WoQcxEDLpZWWwHJgwgXn4irlVW/IlyJmxFAdlqWx78yXqQGxU0upJspG8iH x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: JiwSuQR9Mxmeg5ul01i6jAz9Y8rrVcaw/mbdOpjJfVK6tSdgXuR+FxgBfpGUpEGoSMun6Cq7DBMx0Rko5DBlY9MCOrLHYVCEoWzjo/AKhSsQrV0dSi7wDcfFE/l8UDkkvp3jqlXPyfNyOqz9x5a4KfkoUKDGnOgz3TpxQNUUeefWLiFWWUSSUp54NhEbMR1QEM/R3FdZzTn/BKWA79OnwTmfSzsrKz9XLJYLnjukjFRlfIlyO/3/audvKZ4ZuI57rIffTN2MqEHStMZxCqfML9yv+ZhglW/qbphp+hsdjoF2/esSU+CBl5VbmXCel/zT8+SJskMY56jTHPu7fi/J9x6pYUjdcJHguM//8MFqW+DGtrg12CjE993oD2+6XtqABssuRTI6Nv4xQswKvoBY7IJEGzj6E2i/1lqY5GsbnRmySaW2R7sK4MQ75ioyv9y0voxT8qsFauKyy/ESl8JBXyE2A64pI2UnS77TY+qFyu8VzKCqxqxlRFEHeMCflFkaqPJBKE79p/pPAJJmU52j4T21Q2ROMxYZ2RbE/1UrvHBK4JumPAm9IkKpAkLr02u/is3tylUbxnhS2aQqUAXF/Doi9MRxZdIbNPgrq6CVV2iKwVhKb9wWRu+Y/dakAf6Juk2So8Sp40Y0Ogs2WlxZ00FV6G1bsDeOndloByXWpUjZ8zkGOeCQsKZ0ZTu6tv0hkbWAnVJ/Q54ZQe8Z21o6eWSvMhMUZHZ79gp8A4y47ZMdSRevXuUPxDpUT9 xfyZNhO3rVI7KXJZBm/EPWDrT9NaHnWnJhu2yAMErCjCeqZuLwk5xltbKf5T6yHHdqHKsDjH6yHigH4DIZIQXhgpf4vMZLMsqk X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: e5e98ca1-0f51-4401-c5dd-08db4e30e051 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2023 12:53:23.1580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR10MB7908 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261191 Archived-At: --_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Forgot to hit =ABReply to all=BB Oh, did not realize that. Yes, the (2 . 3) is important, it=92s the TYPE that determines whether the message is highlighted as an INFO, WARNING or ERROR. From compilation-error-regexp-alist: Each elt has the form (REGEXP FILE [LINE COLUMN TYPE HYPERLINK HIGHLIGHT...]). TYPE is 2 or nil for a real error or 1 for warning or 0 for info. TYPE can also be of the form (WARNING . INFO). In that case this will be equivalent to 1 if the WARNING=92th subexpression matched or else equivalent to 0 if the INFO=92th subexpression matched, or else equivalent to 2 if neither of them matched. See =91compilation-error-face=92, =91compilation-warning-face=92, =91compilation-info-face=92 and =91compilation-skip-threshold=92. I=92ll try to take a look into modifying the type of the vhdl-compiler-alist. Von: Mattias Engdeg=E5rd Gesendet: Samstag, 6. Mai 2023 11:22 An: 63251@debbugs.gnu.org Cc: Reto Zimmermann; Eli Zaretskii; Cyril Arnould Betreff: bug#63251: 28.2; vhdl-mode contribution > Following bug#62508, I've taken a bit of a closer look at the compiler > regexp for ModelSim. I've modified it so that it can differentiate > between Errors, Warnings and Notes when highlighting. I also make use of > Xilinx Vivado at work, for which I've added a new compiler entry: Sorry, but computer says no. The modified vhdl-compiler-alist value does no= t match its declared type. You can easily check this by running `M-x customize-variable vhdl-compiler-= alist`; it will show the contents as a single big text field and say (misma= tch). If the value matches the type, it would have shown the value structurally. Another check is to run `make -C test test-custom-opts`, which checks the v= alues of all defcustom variables in Emacs. In this case it seems to be the `(2 . 3)` values at the end of the error me= ssage sublists. Remove them and the value matches the type. If those (2 . 3) are important, perhaps you want to change the type instead= but you would have to maintain compatibility somehow. I see there is a lot= of code dealing with changes to the type of that variable in vhdl-mode.el. --_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Forgot to hit =ABReply to all=BB

 

Oh, did not realize that. Yes, the (2 . 3) is import= ant, it=92s the

TYPE that determines whether the message is highligh= ted as an

INFO, WARNING or ERROR. From compilation-error-regex= p-alist:

 

Each elt has the form (REGEXP FILE [LINE COLUMN TYPE= HYPERLINK

HIGHLIGHT...]).

 

TYPE is 2 or nil for a real error or 1 for warning o= r 0 for info.

TYPE can also be of the form (WARNING . INFO). = In that case this

will be equivalent to 1 if the WARNING=92th subexpre= ssion matched

or else equivalent to 0 if the INFO=92th subexpressi= on matched,

or else equivalent to 2 if neither of them matched.<= o:p>

See =91compilation-error-face=92, =91compilation-war= ning-face=92,

=91compilation-info-face=92 and =91compilation-skip-= threshold=92.

 

I=92ll try to take a look into modifying the type of= the

vhdl-compiler-alist.

 

 

Von: Mattias Engdeg=E5rd
Gesendet: Samstag, 6. Mai 2023 11:22
An: 63251@debbugs.gnu.org
Cc: Reto Zimmermann; Eli Zaretskii; Cyril Arnou= ld
Betreff: bug#63251: 28.2; vhdl-mode contribution

 

> Following bug#62= 508, I've taken a bit of a closer look at the compiler
> regexp for ModelSim. I've modified it so that it can differentiate
> between Errors, Warnings and Notes when highlighting. I also make use = of
> Xilinx Vivado at work, for which I've added a new compiler entry:

Sorry, but computer says no. The modified vhdl-compiler-alist value does no= t match its declared type.

You can easily check this by running `M-x customize-variable vhdl-compiler-= alist`; it will show the contents as a single big text field and say (misma= tch).
If the value matches the type, it would have shown the value structurally.<= br>
Another check is to run `make -C test test-custom-opts`, which checks the v= alues of all defcustom variables in Emacs.

In this case it seems to be the `(2 . 3)` values at the end of the error me= ssage sublists. Remove them and the value matches the type.
If those (2 . 3) are important, perhaps you want to change the type instead= but you would have to maintain compatibility somehow. I see there is a lot= of code dealing with changes to the type of that variable in vhdl-mode.el.=



 

--_000_AS4PR10MB6110567EEC8E92D7B2EEA49BE3739AS4PR10MB6110EURP_--