From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cyril Arnould Newsgroups: gmane.emacs.devel Subject: AW: emacs-29 a2d4cd06f45: Improve VHDL mode highlighting Date: Tue, 9 May 2023 11:51:29 +0000 Message-ID: References: <168326553347.14898.7329669431232347477@vcs2.savannah.gnu.org> <20230505054533.D680AC1BECD@vcs2.savannah.gnu.org> <87mt2e9c0e.fsf@gmx.de> <83h6slc438.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_000_AS4PR10MB611014566862DBAE7311B343E3769AS4PR10MB6110EURP_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11227"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Eli Zaretskii , Michael Albinus , Reto Zimmermann , =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 09 14:04:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwM5E-0002ly-UD for ged-emacs-devel@m.gmane-mx.org; Tue, 09 May 2023 14:04:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwM4Y-0002kM-78; Tue, 09 May 2023 08:04:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwLsc-0005x3-Tc for emacs-devel@gnu.org; Tue, 09 May 2023 07:51:42 -0400 Original-Received: from mail-am6eur05olkn2040.outbound.protection.outlook.com ([40.92.91.40] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwLsa-0003kz-In; Tue, 09 May 2023 07:51:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ofs1HJDa6hZpjrnmYSAmWNnYEtjfE0OgELHHGSrouyx+sw9fSix3jElIy+DfDV3QJ1/C2WwFIVWO1XzEqjjTzAXb30F4LKl0cBftcvhtZO1Vn3jFWozITDUwrwjnuJQyN0+9JSDYzzB4lRSCyF6KF930KXnY/Oj/GRIgO98RzPJfAn3Weals4IMHHq3IDWBeYzPKBIWaPB8Rah/pPsCL0L6cWpjH0RSlSyTYkzzvvu5rhaGMNF9CVBRNXMp6B8q2vpl3bmfROWYG1LsLcbGU2Sgbsvx/qTd5FzPfZ0h/RXXh4/G3icUlGBCzuBv+Z2uhT9JUMM/s12IPSlzox0p6lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=86bHMBqZhvhqeebSJS2kMrRP8jneyXsrUsNMzIYXxAo=; b=M5vDPStk3/as5UvTchAx8UQ4sNl+J1JcR3QF4F4CEClo+Wb4MhNK9vIeLvqhd6DfmUlARMOfnouK2bDwWbj5s/rmBLTk6sn/IFIMmWgC6h8uDbQIjiLJ9XKEco0A/DJV+4SJEG4hgChoHJJuqqece5e35H43eL8I3AJ8M7sleKuAR9U0fziupPYP+1Z7vR5gtQHsuBFN1PGrGVV97VWIRj5EQlDZp4CLALEFsskmuNR/yEoCfQ9eVVRo4cUWyEQn4TvDIXL0e7Ewl8rh/cPnvvtFTajVCM5WJqDYblkeL5SB4k/PPiFMmazxWXssWPZCCACOWFf8FlBLq/zqdvziIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86bHMBqZhvhqeebSJS2kMrRP8jneyXsrUsNMzIYXxAo=; b=qHxV5mQ5KbTQOhUsi8FlM8zYNxs6jJCavd0VvNmquiuRkZpSj4xGmJjHzTzj0ecZCtg3DwpXnRWT0sDs1UZ573HMrGrI5tHD6vtUfKciQFDXEANjxCJbjjPjXFI0uAmKZggcRmWidlzG/UAeeNRdaTkYTfg3hCWk3wcmTQ4iL+cuo1WiATaY4Zw1a6w9P7JR9oL08qx1oIj8Illuynxt/SI0s+YWBfedmnAaZE7nX91CZpE8PfM0g4FDEGcANvZ7uUIWWwTngxjN0BVlbadL4ajarIY/OxD1QpAp0Y5jcQX5wbbeu98aU3vP/l6aeGCzMtU2h8HYTZGhLNS8rdSjQg== Original-Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:582::17) by PR3PR10MB4062.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 11:51:29 +0000 Original-Received: from AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1]) by AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM ([fe80::18ab:4656:4a13:e7e1%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023 11:51:29 +0000 Thread-Topic: emacs-29 a2d4cd06f45: Improve VHDL mode highlighting Thread-Index: AQHZgktVd1JJAYcKTUGvrY2L9gaaYK9RmDjygAA1s3Q= In-Reply-To: <83h6slc438.fsf@gnu.org> Accept-Language: de-CH, en-US Content-Language: de-CH x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [VtjMuyInYzKA/OKJU3lmwJJ29wrJ3I9Y] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS4PR10MB6110:EE_|PR3PR10MB4062:EE_ x-ms-office365-filtering-correlation-id: d4e60873-e22c-428b-f669-08db5083b9c3 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NPDiV+WK+oxHzCdhMdp+/hTWRomKItA5z8ef0gYN7L6cL4PZKpIJhOEq7/Rs4zvR1e9ylkt10Oq6rVGX9Wh/3rU28hH1RcPdHQGEQvRvkAD05v3sXqKweWDFwp9rpKI2Jiad8oD56G7UkS0PUuPXpDrv1qjbhpI9dab4w4jZvBeS1GLtqi0Y9w0IYhfvCmwxJEoEdAWNbPtqwSHwPhUJ6VdcNgIt6c27tJIKsytTjxZI1Ylh1dkJ1Sy07h6yc1wuJsuydXQS+XCFUh0YK/DOcpkfnMSvg4lKVQ68AlPJIogcDCJripheHSkxvhIBVnt4tQ8OUS3M8up+wyGM6kRN61EQ1ZGAy5dRgOTRCw2QAgL0VymoPCwazPYY+hdwDIPG88WB5ygTn8pGS35VFurBQus+4u6YVbl4scN5coNVMvH0TxPPELL8hrAa69a5At6+U9t2+NlsWjUYxlrDpQHuKiXxpJ7KBnZVer+t4h7OpoaIjoU8U0BSzdHRtZinU7szvTvSC/Qlmrm0XEWM3mr1UiZp/5XUnHG83g6/bzZcJ9qKUMSxit2DqmfIy1cU3nUK x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?5r56SNJ+FVyeU1/VDVREPieb2n+dledlQdWu1QcqBiNgsy5z6JpJw570Xo?= =?iso-8859-1?Q?2cjqndsT/LMvpYVqMxzNtiDjW+FSatSmYrFI30QZENjgrt2FITVXk3VR5A?= =?iso-8859-1?Q?sHbEwZ4OWWTmb1HUEIn8WslG2VilHf5Uc29kYLFdAcBb4uXd/uX+BUhcnc?= =?iso-8859-1?Q?h9nA5TTf3RQIzDqMYhom81UvCrlIHsuB6oUMXpqShkfc0tCJ/8F5MTqbRl?= =?iso-8859-1?Q?8LokBhxCgOzzxckMPYExYXpRiyc1oSieIs/Djg0H1inSrZ+rTUq5qkbtjN?= =?iso-8859-1?Q?cSoIduq1v+SBTrQY20BCqR7SwPtmnGWtSAQnvYJmFe4EtxhpP2cyfAplR6?= =?iso-8859-1?Q?nJU7TcbzKDbJCyOjW1AxSKcx658zxkyfGfQllxZg5RQnRJgjnStF9lkBcZ?= =?iso-8859-1?Q?tT2TL8PfL7WUc1eWk4GTt/J3V6lloCNLI5GZ3RPuHfFRf4PV7fUd2Cylt7?= =?iso-8859-1?Q?/eGQlGKNKKsYbz+q8HzHQ9EjWypOSu4UZR1yXYIwQSDFvN0McmMoUqopnE?= =?iso-8859-1?Q?GjI4CXwc91W9ZUlKvcBt1RE3sVYyVRCgQQLeu4gd51hUbPxoSuk/UeyqQA?= =?iso-8859-1?Q?8J3yEkS3QAjBdKvxfc/KKfrzq+QHfwKpUOlz76lDZSfAakMa6SbOgZHgTQ?= =?iso-8859-1?Q? X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6110.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d4e60873-e22c-428b-f669-08db5083b9c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 11:51:29.0165 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB4062 Received-SPF: pass client-ip=40.92.91.40; envelope-from=cyril.arnould@outlook.com; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 09 May 2023 08:03:59 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306005 Archived-At: --_000_AS4PR10MB611014566862DBAE7311B343E3769AS4PR10MB6110EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > Cyril, are you done discussing this, or do I need to wait some more? I was actually hoping to get Reto's and/or your input on two points, the first one being: > Since this introduces changes in the vhdl-compiler type, I guess > it would be appropriate to increment the vhdl-version number? I've seen that on Reto's website, the latest vhdl-version number is 3.38.4, while in the emacs repository it's at 3.38.1. I'm not sure if this is intentional or if it simply hasn't been tracked in emacs. If development is not intended to diverge, we could skip ahead to 3.38.5 or 3.39.1. The second point is that we now have two solutions for backwards compatibility code. There's my original solution which is a slight modification of already established backwards compatibility code. Alternatively, there's the solution elaborated with Mattias which should be safer but is less tested. If using a more "experimental" solution is no problem then we can go ahead with the new approach. --_000_AS4PR10MB611014566862DBAE7311B343E3769AS4PR10MB6110EURP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> Cyril, are you done discussing this, or = do I need to wait some more?

I was actually hoping to get Reto's and/or yo= ur input on two
points, the first one being:

> Since this introduces changes in the vhd= l-compiler type, I guess
> it would be appropriate to increment the= vhdl-version number?

I've seen that on Reto's website, the latest vhdl-version number
is 3.38.4, while in the emacs repository it's= at 3.38.1. I'm not
sure if this is intentional or if it simply h= asn't been tracked
in emacs. If development is not intended to d= iverge, we could
skip ahead to 3.38.5 or 3.39.1= .

The second point is that we now have two solutions for backwards
compatibility code. There's my original solution which is a
slight modification of already established backwards
compatibility code. Alternatively, there's the solution
elaborated with Mattias which should be safer but is less
tested. If using a more "experimental&qu= ot; solution is no problem
then we can go ahead with the new approach.

--_000_AS4PR10MB611014566862DBAE7311B343E3769AS4PR10MB6110EURP_--