highlight-sexp-mode add-hook with (highlight-sexp-mode 0)

highlight-sexp-mode add-hook with (highlight-sexp-mode 0)

[Heime]

I am using highlight-sexp-mode with the following in my init file

(add-hook 'emacs-lisp-mode-hook 'highlight-sexp-mode)

But then I also call  

(if highlight-sexp-mode (highlight-sexp-mode 0))

Yet when I load an ".el" file, I still get "highlight-sexp-mode" activated.

Re: highlight-sexp-mode add-hook with (highlight-sexp-mode 0)

[Emanuel Berg]

Heime wrote:

> (if highlight-sexp-mode (highlight-sexp-mode 0))

Better to use `when' here in terms of Lisp.

Note that not all minor modes have variables, that should have
generated an error if so in this case so I don't think that's
it tho. (Example: `auto-save-mode', only a function.)

And actually there's no real need to check if something is
enabled if you just want to disable it, just disable it.

To disable stuff from Lisp, -1 is more clear than 0.

However ... that's a lot said about such a small thing,
without saying why it doesn't work.

-- 
underground experts united
https://dataswamp.org/~incal

Re: highlight-sexp-mode add-hook with (highlight-sexp-mode 0)

[Eli Zaretskii]

> Date: Wed, 26 Oct 2022 21:55:23 +0000
> From: Heime <heimeborgia@protonmail.com>
> 
> I am using highlight-sexp-mode with the following in my init file
> 
> (add-hook 'emacs-lisp-mode-hook 'highlight-sexp-mode)
> 
> But then I also call  
> 
> (if highlight-sexp-mode (highlight-sexp-mode 0))
> 
> Yet when I load an ".el" file, I still get "highlight-sexp-mode" activated.

Crystal ball says you do the latter too early, or in the wrong buffer.

Re: highlight-sexp-mode add-hook with (highlight-sexp-mode 0)

[Heime]

------- Original Message -------
On Thursday, October 27th, 2022 at 5:43 AM, Eli Zaretskii <eliz@gnu.org> wrote:


> > Date: Wed, 26 Oct 2022 21:55:23 +0000
> > From: Heime heimeborgia@protonmail.com
> > 
> > I am using highlight-sexp-mode with the following in my init file
> > 
> > (add-hook 'emacs-lisp-mode-hook 'highlight-sexp-mode)
> > 
> > But then I also call
> > 
> > (if highlight-sexp-mode (highlight-sexp-mode 0))
> > 
> > Yet when I load an ".el" file, I still get "highlight-sexp-mode" activated.
> 
> 
> Crystal ball says you do the latter too early, or in the wrong buffer.

Because I do 

(if highlight-sexp-mode (highlight-sexp-mode 0))

in my init file.  Sounds that the procedure should be to remove the mode hook
if I want to disable the capture of files by "highlight-sexp-mode" if a mode hook
had already been activated.