From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Mon, 20 Sep 2021 17:01:22 +0200 Message-ID: References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20146"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Ihor Radchenko , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 17:27:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSLCM-0004xK-J2 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 17:27:15 +0200 Original-Received: from localhost ([::1]:45436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSLCK-0005ls-Q3 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 11:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSKnX-0005MY-Bp for emacs-devel@gnu.org; Mon, 20 Sep 2021 11:01:37 -0400 Original-Received: from mail-db8eur05olkn2028.outbound.protection.outlook.com ([40.92.89.28]:8288 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSKnN-0001Oy-Hr for emacs-devel@gnu.org; Mon, 20 Sep 2021 11:01:33 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y71JKxGMfLiX7gal2iDQmEsUK1T6hpSNSBte06ng5cdr4ujFEhOsCSbfa6L/V7g7eSjFoeJM5RKxqRF/PbY4cTBufggUg4bheH9J1hmw3dE7nhXG9zb9fEsaNeB4wOasEgWXRA6pblpZL5yNjMQLQU4tJfdILCcZAKTzzYqEx90h/xyxUHhJ72YvShFQvgYBE6CXPFazbJdoSgBImMchz30fT3bx5JXpxdqHKXCzN4OHGRi/ove7ZZDFRopYUQLZmm7HLYLDaRvxrgQU5eRQJe0EaMUtB1fGl3UkaV9ATJqEN7k0ZFOpBp7xKKJF9FLCFCa321iCu2yfFxfBvCTNxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oUSViiBhjugr8V6o2aFw6TyzS1PTSv8/qY2KmURRTzY=; b=Ypu64+X06lSG73HcrsNWQ1aRi0g2U0haPDLVH8hmG2zaK92ss0XcDbsGhfNIo+Tu/2cMJ2/reoVSw9lb4Y92lMG7JdIXmFlFi+2IPf59qznU5ST6v/CspW4utTiGWJsndlDwqALmMjOyG/dT+pVBrk6XFCPR6vtODKn9jEJGRzLK00Wq98JxaVzcw9xcOQ534yafsDG4fkcryNGmxT2PnNi1hrqQVadk8VgxTIWZD0ycAkZhGWxN6ru3d7U04/oM7SDnsxtzfCsSofBbcnZai4ZpeEq+x4emTwCQ36oFPH8P+DJabU/CqynOUHTuJSnUZZgutKFXzlyfYcNmqoKWFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oUSViiBhjugr8V6o2aFw6TyzS1PTSv8/qY2KmURRTzY=; b=XRw59DUG0f9Z4XjqE8J/3cMgt0Mj9ELCmorAQoGBbiW0iXI3QDP8WyHpt4geDOq/jzPLzipP5WvfAX0smNS1oCIZ0Q/KXZLsAQE1zvWwU217AG+nDyxqEOrmvEEUNq6+wQQBm+HF3Cvn2kxKmzStKmF/yr//2HXfOJYkgyCFV8YEhItSKZqoax0OhB4TdZv1mlA0B+NSyTHw7CqoESuSIEy75CG4L9LFam2maJD090UQT8NePDc7Xk6eqmhvng9aajqUsqjHgScI5SK9Y9FOgfIZAv1UyFAakko/8yNvx3yx4Jp7/4dduqK2o4ascTVxGBfKEqx/+JmWI/WvS5nOWA== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM0PR09MB4388.eurprd09.prod.outlook.com (2603:10a6:20b:162::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Mon, 20 Sep 2021 15:01:23 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c55c:ece5:bed2:a9dc%9]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 15:01:23 +0000 In-Reply-To: (Stefan Kangas's message of "Mon, 20 Sep 2021 00:43:00 -0700") X-TMN: [gohYj5O93Cs/7w/7Zz8g585DGFGHO+8J] X-ClientProxiedBy: AS8PR05CA0012.eurprd05.prod.outlook.com (2603:10a6:20b:311::17) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87y27rl29p.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by AS8PR05CA0012.eurprd05.prod.outlook.com (2603:10a6:20b:311::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 15:01:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 740be840-dc8d-47b1-f1ee-08d97c4782d9 X-MS-TrafficTypeDiagnostic: AM0PR09MB4388: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hTmuZgM1v8JPvm0+XHR02bIR2HVbHO30ss0PB8ngXkDeP/M4BYe4IfY+l+G8nXqdPc+r3Ui91BG+38zTQDqdAdYtYmgFSKr5UaFRBn+UiX+4AFlyRCjLR9Rn+mZeEKm5vhSTc+BGG1Cj4yKCuG7fxDSUqnkprt/SX8PvKC4wMxK7wFQiWQvvTdZoAcw+bmXqFapwTeOemPM73c+g+Nst4e5Ya1uE2dZ0H5UT754xh3sE/xMA8O4Rbm8BDenYi3Nl/h4/ctp1Vj4SoZ5AwLncF+140JgkMjwxfv9O1xkmQUtST+RogUTaYGrZVXYupFz9C5ZReghcpSLrXqd+8mCIF4Vg9Fi/i5Nx+nmhtY9WGJ0/my2Vr/RIBK50ucrt4oYWxVhVKJNlqHCgq9OsorClbjzOAOVVBpgUyrDRnCC0daZQu2c5++zg40NGpseM1Ajo X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nv6ULCYjejBsMvOO4r6ToXYYtZNXIZTCEEddOke1upBE17bLD2sMnFMVrrJWDfHjixo/09GdtLv0L9q7vRlyqvTLE18CGhKJm9iACrt+BlG44PoV4RDHKiqujKJcHHtcsxih5aGwc0rjjXjb84Obxw== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 740be840-dc8d-47b1-f1ee-08d97c4782d9 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 15:01:23.3083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR09MB4388 Received-SPF: pass client-ip=40.92.89.28; envelope-from=arthur.miller@live.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275140 Archived-At: Stefan Kangas writes: > Ihor Radchenko writes: > >> Consider scenario when you are editing some-file.el and narrowed the >> buffer to a defun A. Then, you need to examine source code of another >> function B also defined in some-file.el. >> >> Opening help buffer for B is easy - f with point at the B's >> call. However, without source code being shown in the help buffer, if I >> try to hit s, the narrowing is removed and the point is moved to a >> function definition. Not convenient. > > I'm not arguing against the new feature here, but is the above a bug? > > It seems to me that `help-view-source' should respect the users > narrowing, for example by querying to open a new indirect buffer or > something in that case. Is that a bug in my patch or in the original help functionality? I am not working with files buffers if they are open. I insert file from the disk, at least I hope that is the way how insrt-file-content works, into a temporary buffer, and I work solely in that temporary buffer, when I am done I copy buffer-string into the help buffer. Otherwise if it does screw up user's narrowing, than it is a bug, at least not-intended behaviour. I would than appreciate a tip what is the cause so I can fix it.