Re: Proposal: ls-lisp.el handle --group-directories-first flag

[Arthur Miller <arthur.miller@live.com>]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Arthur Miller <arthur.miller@live.com>
>> Cc: emacs-devel@gnu.org
>> Date: Fri, 16 Jul 2021 15:20:58 +0200
>> 
>> > Doesn't it work to let-bind ls-lisp-dirs-first?
>> 
>> I don't know about that one. ls-lisp--insert-directory effectively
>> ensures that switches are passed further the line as a string of
>> chars. The flag is lost in the first step and can't be passed further
>> on.
>
> Which flag is lost and why?

Ok, I take my words back, it is actually not lost. I was to fast didn't
reallize --group-directories-first was just converted with rest to a
list of chars.

Doesn't it mean that ls-lisp could potentialy recieve flags that user
didn't ment to use?

> I'm still missing something, because I don't see how this is different
> from just let-binding ls-lisp-dirs-first.

Since --group-directories-first is still there, then let bind works fine
:-).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ls-lisp.patch --]
[-- Type: text/x-patch, Size: 2170 bytes --]

--- ../emacs/lisp/ls-lisp.el	2021-06-06 23:11:38.317648694 +0200
+++ ./ls-lisp.el	2021-07-16 16:54:51.413276991 +0200
@@ -682,24 +682,27 @@
 	       (ding) (sit-for 2))))	; to show user the message!
   (if (memq ?F switches)		; classify switch
       (setq file-alist (mapcar 'ls-lisp-classify file-alist)))
-  (if ls-lisp-dirs-first
-  ;; Re-sort directories first, without otherwise changing the
-  ;; ordering, and reverse whole list.  cadr of each element of
-  ;; `file-alist' is t for directory, string (name linked to) for
-  ;; symbolic link, or nil.
-      (let (el dirs files)
-	(while file-alist
-	  (if (or (eq (cadr (setq el (car file-alist))) t) ; directory
-                  (and (stringp (cadr el))
-                       (file-directory-p (cadr el)))) ; symlink to a directory
-	      (setq dirs (cons el dirs))
-	    (setq files (cons el files)))
-	  (setq file-alist (cdr file-alist)))
-	(setq file-alist
-	      (if (memq ?U switches)	; unsorted order is reversed
-		  (nconc dirs files)
-		(nconc files dirs)
-		))))
+  (let ((dirs-first (or ls-lisp-dirs-first
+                        (string-match "groupdirectoriesfirst" (concat
+                                                               switches))))) 
+    (if dirs-first
+        ;; Re-sort directories first, without otherwise changing the
+        ;; ordering, and reverse whole list.  cadr of each element of
+        ;; `file-alist' is t for directory, string (name linked to) for
+        ;; symbolic link, or nil.
+        (let (el dirs files)
+	  (while file-alist
+	    (if (or (eq (cadr (setq el (car file-alist))) t) ; directory
+                    (and (stringp (cadr el))
+                         (file-directory-p (cadr el)))) ; symlink to a directory
+	        (setq dirs (cons el dirs))
+	      (setq files (cons el files)))
+	    (setq file-alist (cdr file-alist)))
+	  (setq file-alist
+	        (if (memq ?U switches)	; unsorted order is reversed
+		    (nconc dirs files)
+		  (nconc files dirs)
+		  )))))
   ;; Finally reverse file alist if necessary.
   ;; (eq below MUST compare `(not (memq ...))' to force comparison of
   ;; t or nil, rather than list tails!)