From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Patch: debug-instrumented predicate Date: Mon, 04 Oct 2021 17:20:28 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 04 17:22:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXPnF-0001FH-6g for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 17:22:18 +0200 Original-Received: from localhost ([::1]:56222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXPnE-0008NQ-7a for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 11:22:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXPll-0006wA-HI for emacs-devel@gnu.org; Mon, 04 Oct 2021 11:20:45 -0400 Original-Received: from mail-oln040092073029.outbound.protection.outlook.com ([40.92.73.29]:4174 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXPle-00061K-3V for emacs-devel@gnu.org; Mon, 04 Oct 2021 11:20:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RKE9Sl6qJVoXWHZCs34CCOFvAv+sOmrPG+CuGqXARjxELUJ1+G0X3MdIzfHFVqcIX3vz4ngRzz7H9R0olLyTevmMSGEw40pD7HGKNUPZ2nNQ4SU0czABDl4l5qXNP4NxKrWV5BYu5mRwXm7j5w+z0COUzFW01qGWpUkZMmQ5QV4SVZjNBQitZbeLGuZMhoYCxhps9bNk4rJYFCfa6UdmDrqLbBsEckubqe0qUWd4KT4C38gTgb4i2W8cyBNbRggkC/EuQL30MWJcgbtel1qXa0n6LhdujRbeuiWEiaLwmSUanCzov3KC25svsI1rkudON9i+md7H9z0n+216nfN8vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CweF6kmPeJ/ikc3be7pRKSD+GQPnZT3XBXal1skCV94=; b=Zcknunkp+xuGAQ5iP/E1UHdwpHzGyel3bzKVEzqabRqHnREQ67hD/oZKhpwPyAiU2WQiN97n/rApIUtwS1j9zoSCPWObVY61K7r8lok38tFmU0WzZUGTwZe6uYICwU3A+OKfv8OACQijfYes0JGJznsOR8tFe1PQIWsvaS6WD7ZxwKDT7SQ+1MBKJGaplvMrMuD95KOfwCJ8QxCaRwg7cQt/bHyrCFYHHgy+BR7zV25yCZnAwnyAgzSG3x+Fo+DEDS1zttqQGLb6q4dYSRwfr4sMUkB+tnZFx+wse0uD4kDwC+f2kHi3K9qxkKUJKa6xoSW4SKyB/xCztYXb596THA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CweF6kmPeJ/ikc3be7pRKSD+GQPnZT3XBXal1skCV94=; b=bGrsqxobdwAA+JVXD7a1VTtuXKsajAXEu3AyC+CQw7RUcoJoylI1VrCq/02PevWvF1S5neWrB3197dw6g9kUSjQeZNJtGnyYLDcYfhm0gBObXga6ktAYFkoZH1bQ8Cv8inaiAo+564VJxmTKU9r+hhVSuVsnX74O6fVtPCGr8S7vj7bt8F5qJNZUes46WreRs71aa+3cU3pnk1T+P7X8DjHB+u99H7Hn5wHpRzCofD+5gcU6QgHrxyEfs5RZVBkP+ikiZhmgB1X4OUZeSCsY7CxP2wk2x1P6y/ePiC8O3Y0vq+hTXxeYsXJYxKripHRKyjiiO82zREEplb6lPF/ZcA== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AM4PR0902MB1763.eurprd09.prod.outlook.com (2603:10a6:200:8d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Mon, 4 Oct 2021 15:20:29 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::c05b:e2ca:5b8a:56d2%9]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 15:20:29 +0000 X-TMN: [6a+B+GHLcMD7+PGyqCVqZEFrDAvWhgxD] X-ClientProxiedBy: AM6P193CA0082.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::23) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87o884stoj.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by AM6P193CA0082.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 15:20:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00e69369-9240-4ebd-c295-08d9874a7fc2 X-MS-TrafficTypeDiagnostic: AM4PR0902MB1763: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gg5RRu3gl2l8hXgmFC/XBniFsmxSWpUFpVQThi3ryNnpXAdgnn+KqFajWQqGA+c4ZZMJgzrbZkqh1JqZKTxregXpWfKxxJdWLEXbG/xCLLfJK1IIsNs+omCaxvEHkTBncgoq699NA6bUeNV4jVUKPoePd5vbY6L8ksaCtk1MbDq0wqi6KGcnjtsC9Ha27lnQjkLYIF+oi71HBSUGw3by/b22/UJFTdsQYgAJgGphzYNvBrgtiVN2bVg7AEUUcNWpVVB8kE0YuNr5r6jHHtf9dcy3hLfhPMgOKjvypdiTOt+49+lcZ7a72Es9w6b1cD10p02RmA2/kpJrPsVndq0WocUGRLfqdClsC40gaILWNUNf9Ah7g5bj6WnBWsnv23n9XXUapkZdV40M75i+eEYxMr62Ib3Cq3v2VSDD85ZSg1YcYmRpqMNM96Ohnu9xANTN X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e4JgrmU6cE33D0M4kdGCYWpxFcAFP6in4744UsTgeA8I6KT/7FAP/x+FZAUs7xW4Cg1HhZXXNSgzsvMl7As9osdeI49bUgORxyLkpP9VZByUzhhLoFRsCd6vl2xmImn4yXL3eVc6UmvZzStHXw407A== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-72e6e.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 00e69369-9240-4ebd-c295-08d9874a7fc2 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 15:20:29.4029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0902MB1763 Received-SPF: pass client-ip=40.92.73.29; envelope-from=arthur.miller@live.com; helo=EUR04-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276211 Archived-At: --=-=-= Content-Type: text/plain For tooling purpose I would like to have a reliable check to see if a symbol is instrumented for debugger or not. I have seen that internal code in debug.el uses advice 'debug--implement-debug-on-entry' for instrumented symbols, but I am not sure if it can be used as a stable check long-term. Suggested patch uses it, but if it is considered internal and subject of change, please add a way to have a stable predicate. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Debug-Instrumented-Predicate.patch >From 16574a7f6f9e2797fe68e06508189daafbb8c005 Mon Sep 17 00:00:00 2001 From: Arthur Miller Date: Mon, 4 Oct 2021 15:48:13 +0200 Subject: [PATCH 2/2] Debug Instrumented Predicate * lisp/emacs-lisp/debug.el (debug-instrumented-p): New function. --- lisp/emacs-lisp/debug.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 0592db85df..8d7e150362 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -683,6 +683,10 @@ debug-on-entry '((depth . -100))) function) +(defun debug-instrumented-p (function) + "Whether FUNCTION has been instrumented for debug." + (advice-member-p #'debug--implement-debug-on-entry function)) + (defun debug--function-list () "List of functions currently set for debug on entry." (let ((funs '())) -- 2.33.0 --=-=-=--