From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Info-mode patch Date: Mon, 03 Jul 2023 00:43:15 +0200 Message-ID: References: <86fs6ertto.fsf@mail.linkov.net> <86wmzpqva6.fsf@mail.linkov.net> <867cropyh3.fsf@mail.linkov.net> <86mt0kulli.fsf@mail.linkov.net> <86wmzmzs1s.fsf@mail.linkov.net> <86edluyxhl.fsf@mail.linkov.net> <86bkgxfm34.fsf@mail.linkov.net> <86zg4gddtf.fsf@mail.linkov.net> <86v8f2xkr4.fsf@mail.linkov.net> <835y72noo4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7316"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Juri Linkov , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 03 04:24:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qG9Et-0001hg-7N for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jul 2023 04:24:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qG9E4-0007Qu-5q; Sun, 02 Jul 2023 22:23:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG5mu-00029U-EI for emacs-devel@gnu.org; Sun, 02 Jul 2023 18:43:24 -0400 Original-Received: from mail-vi1eur05olkn2099.outbound.protection.outlook.com ([40.92.90.99] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG5ms-0000vD-6k; Sun, 02 Jul 2023 18:43:23 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=im5yaaHhkuM8jGXRDBb7lfxUlZHX9m3eaSySm23+/vvliAh0eCN9Q6nP0JEG5ydbQhAj11/Rd4H6ymCSbOqKVWlX/grq99AEjxyOEAkRccnxNjJD7soR6z8rqlkKyIwCEiDcV72WDjj4e4Qe+n4sj5HTm9Y1bBfT6XwhNhNhs10Gs4A/MQkCeyiqcw1pZg9bzheBDGeEKPfU+uz6kLNl4hpbylkYwnhrm+J96yfcp8i6TjQW5kq9hEPy22pN1XdQdLt+NFXcIXp0j1ViGU+Tu2puhqCJsAQsC8HOg0tC2UOrNdPyi/R8WeL2qvm07/dxqYw1KVMBE3RN3gR17AZpQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ULfLXkoPL2spWtJTJ846eMIzSa8lCMOu/C+/s0Mbi4=; b=a/iTghudDEAAEWFrP51h3DcOPl2/kI8qaE9AHGxXEgsqya2sN4vkSx9aX3yqOHyfianA0V6R0Y36UOX2jlKr2VSPjvXNTA3MMTbFkReKxtqZ+lhYYAwWIRrYH81IlUhuCWD6qK9+t2rXe7i9t2L16q1q3oBmc2VVxlFxnSJJE7qRinOZvBzwPF1a4l+23/BVfqrkDcHZzr1+VP5TnOeuZJSea1VAiQPhcUdGsVDYM5Q3aCO1xSp4icT0o9l9UwksVmN8vg5EI4ha1LjCANQOQw/IyT7MqJhCpDHwK85ySnSdnhIkleMCpBVV9igNo1R/ti2yB+9j2r8nvhuDRXbvOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ULfLXkoPL2spWtJTJ846eMIzSa8lCMOu/C+/s0Mbi4=; b=XG5a7Mq8DufEj0c0rxFCkAzObJiVOTwCX7ACx3NbEeStAHMi+zyQzLXk4QhiTlmtuKtX67f5rlm8gvvTJOMabyCwmXDJ9/LlB/4oU6hgKK11Xe53sR2uWzwwVoQGDJ9Z03Yc2rp45MABKu+a9XDEdvrmR6EhDUkeVyroUCH7zcVb6UJlR6B4kVvxeDYLpr9UtDlNdAqGGjdcX7/nUZaHll4nkPvexs9M4cOM1uRVLWM8XzAsItnkQ2MhHixcj+qt2DNLanQ/VDC23AkXn0vmGQ2mNm/wnLD9yA2Aylnkr8y6LfTHFCd+MlD9z2SC6nzEfFFyNQvpa8jrhh4fhkZTrA== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by AS8PR09MB4600.eurprd09.prod.outlook.com (2603:10a6:20b:29d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Sun, 2 Jul 2023 22:43:19 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::4a5f:42f9:d78f:2021]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::4a5f:42f9:d78f:2021%4]) with mapi id 15.20.6544.024; Sun, 2 Jul 2023 22:43:19 +0000 In-Reply-To: <835y72noo4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Jul 2023 14:38:51 -0400") X-TMN: [ysleZ1v15PF7EmpmvZGVqt1XKdEj5jLL] X-ClientProxiedBy: BE1P281CA0158.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:67::7) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <82r0pqszng.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR09MB4977:EE_|AS8PR09MB4600:EE_ X-MS-Office365-Filtering-Correlation-Id: 2dab5ea2-74f5-43ec-fa94-08db7b4dbb50 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bMvu1AXIVU8c30t/SSc183txq7fBoP+pF/xu73mrYA+7o5xLWMofYsD9BZmX/Fi+gN+t294A32mN8OTqDpBPPnKm6IV744gCKBzyB9Eh6ElXX/JJl2IX2E4eJ3QcVJpTwDV+F5T+/w1o9+SO4siQj+MTv43fzLv3JgAiwD8rSODXA0mO+5HFG42qz9cL6bsMbNNKhRupjY6cdMMnzRkd24WHJ5MK+bJRZ9g+zp3lAVPuQR6Pit01dFntFluemp/UjhVt5q0bpe57YZMGxwctdeko7Ayk0r+sWd867VaV79sOwkvK/jLGUY/m54WlgJ7Xxpx6gvaaLMcuWDN/gMk6A3iMa6ENBZcNYHvVsoJFC4g5z2Y45shKPFYlhzfHIjOzAJAL08z+awpyDdK76sS49zuMsxbBt7G8AWH+8umDMDeB6XF2uujTaC/Qb40bMjaEioCapFoxDGCf7AfnFwBc8nH2W/BxCx2EVn7joSU0SWRn/kMnJxup5e2XNe3Hq/cYa1xAz5l5h/wtnTW0cAIMl0IefxGc5c0Y33/M2xLlqq0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vMWaqKGq+lPnGLM+rZYCeLt1SQC2JyOv3LFf+5i4qWC153dg8DiMSx3Fe+g3?= =?us-ascii?Q?0EZpAHfFXxwyLV8C75iaoIslHlslCc6gOqcVRYgEyjZ+wKOoPZWlHauAFyqZ?= =?us-ascii?Q?7Rv1bFkswLSrPH53b3DeRsacQ4IGIRJzrcARaBjcL3dxVh4NTJkQ21Nxn/HU?= =?us-ascii?Q?BKjshzdttE9hrq8L7cqMoCXfQyW+Tlox3s//nlU0euSloXfhiZOunQ6l82pO?= =?us-ascii?Q?sHriot45HJtwH+uc2kt6bhWlUaeGequRI84D+YO+EKC6FJm6dpczLvFLdkfU?= =?us-ascii?Q?uOXMAtlLwszHuVdc6BTyCWGE+G+DJzjEUjHuXkvPxX/knK3oUq24keuJrcOG?= =?us-ascii?Q?v1KPk3bGGRmQk4vjpZFSLVOJCofPPFEI8bny+bEkiDqH4v10Qx0Vpyx1LmCr?= =?us-ascii?Q?if2zGD38bHEuvI76BKknfwOU0DHDCTLZhvGatkjEh5V7xc/OnXT/9gqiVJV0?= =?us-ascii?Q?5XAWEAMeOnAbjyNPmj61LgxMrofamD25RubDq251N/XZWcfJ9mtoD01oARjj?= =?us-ascii?Q?x7rnvdXzFcQSGy4K11xXfrU1W3i2E8b1puSUXNzyKFncB/tJKg9eLCOx0456?= =?us-ascii?Q?fU3TW/x/bBmD9CFXvdwxlgDO2eAiAecNYD6eL/AYs+vYrLEBaUdCAYsVyLLS?= =?us-ascii?Q?+f X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-64da6.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 2dab5ea2-74f5-43ec-fa94-08db7b4dbb50 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2023 22:43:19.2901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR09MB4600 Received-SPF: pass client-ip=40.92.90.99; envelope-from=arthur.miller@live.com; helo=EUR05-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 02 Jul 2023 22:23:38 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307378 Archived-At: Eli Zaretskii writes: >> From: Juri Linkov >> Cc: emacs-devel@gnu.org >> Date: Sun, 02 Jul 2023 20:53:51 +0300 >>=20 >> It seems you found a bug in 'key-valid-p'! >> And indeed it returns nil: >>=20 >> (key-valid-p " ") > > Why is it a bug? " " has no meaning, > since it isn't a mouse event. Is "remap" a mouse event? I am not familiar with the work behind the new defvar-keymap, I was just looking at the existing code and expected it to be consistent with the old vector syntax, since some other constructs seems to= work with it. It would be also nice if everything was in the same definition. It= is not necessary, but nice. Just an opinon. #+begin_src emacs-lisp (defvar-keymap Info-mode-map :doc "Keymap containing Info commands." :repeat t :suppress t "." #'Info-beginning-of-buffer "SPC" #'Info-scroll-up "S-SPC" #'Info-scroll-down "C-m" #'Info-follow-nearest-node "" #'Info-next-reference "S-TAB" #'Info-prev-reference "" #'Info-prev-reference "1" #'Info-nth-menu-item "2" #'Info-nth-menu-item "3" #'Info-nth-menu-item "4" #'Info-nth-menu-item "5" #'Info-nth-menu-item "6" #'Info-nth-menu-item "7" #'Info-nth-menu-item "8" #'Info-nth-menu-item "9" #'Info-nth-menu-item "0" #'undefined "?" #'Info-summary "]" #'Info-forward-node "[" #'Info-backward-node "<" #'Info-top-node ">" #'Info-final-node "b" #'Info-beginning-of-buffer "d" #'Info-directory "e" #'Info-end-of-buffer "f" #'Info-follow-reference "g" #'Info-goto-node "G" #'Info-goto-node-web "h" #'Info-help ;; This is for compatibility with standalone info (>~ version 5.2). ;; Though for some time, standalone info had H and h reversed. ;; See . "H" #'Info-describe-mode "i" #'Info-index "I" #'Info-virtual-index "l" #'Info-history-back "L" #'Info-history "m" #'Info-menu "n" #'Info-next "p" #'Info-prev "q" #'Info-quit-window "r" #'Info-history-forward "s" #'Info-search "S" #'Info-search-case-sensitively "M-n" #'clone-buffer "t" #'Info-top-node "T" #'Info-toc "u" #'Info-up ;; `w' for consistency with `dired-copy-filename-as-kill'. "w" #'Info-copy-current-node-name "c" #'Info-copy-current-node-name ;; `^' for consistency with `dired-up-directory'. "^" #'Info-up "," #'Info-index-next "DEL" #'Info-scroll-down " " #'goto-line-relative "" #'Info-mouse-follow-nearest-node "" 'mouse-face "" #'Info-history-back "" #'Info-history-forward) #+end_src By the way, as a last thing, is this a bug (found it while I was parsing Info-mode-map and generated wrappers for commands in it some time ago): (insert (pp Info-mode-map)) (keymap #^[nil nil keymap #^^[3 0 nil nil nil nil nil nil nil nil nil Info-next-reference nil nil ni= l Info-follow-nearest-node nil nil nil nil nil nil nil nil nil nil nil nil = nil =09 I have removed rest of printed code for the brewity for the mail, but if you eval above and place the cursor somewhere after the "keymap", or before the= char table, and then try to read the subtype with: (char-table-subtype (read (current-buffer))) Then Emacs dumps core in version 26 up to current master. Emacs 25 actually= ends up in debugger instead of crashing: Debugger entered--Lisp error: (wrong-type-argument char-table-p=20 #^^[3 0 nil nil nil nil nil nil nil nil nil Info-next-reference nil nil nil= Info-follow-nearest-node nil nil nil nil nil nil nil nil nil nil nil nil n= il (keymap (110 . clone-buffer) (9 . Info-prev-reference)) nil nil nil nil = Info-scroll-up nil nil nil nil nil nil nil nil nil nil nil Info-index-next = negative-argument beginning-of-buffer nil undefined Info-nth-menu-item Info= -nth-menu-item Info-nth-menu-item Info-nth-menu-item Info-nth-menu-item Inf= o-nth-menu-item Info-nth-menu-item Info-nth-menu-item Info-nth-menu-item ni= l nil Info-top-node nil Info-final-node Info-summary nil nil nil nil nil ni= l nil nil describe-mode Info-virtual-index nil nil Info-history nil nil nil= nil nil nil Info-search-case-sensitively Info-toc nil nil nil nil nil nil = Info-backward-node nil Info-forward-node Info-up nil nil nil beginning-of-b= uffer Info-copy-current-node-name Info-directory end-of-buffer Info-follow-= reference Info-goto-node Info-help Info-index nil nil Info-history-back Inf= o-menu Info-next nil Info-prev Info-exit Info-history-forward Info-search I= nfo-top-node Info-up nil Info-copy-current-node-name nil nil nil nil nil ni= l nil Info-scroll-down]) #^^[3 0 nil nil nil nil nil nil nil nil nil Info-next-reference nil nil nil= Info-follow-nearest-node nil nil nil nil nil nil nil nil nil nil nil nil n= il (keymap (110 . clone-buffer) (9 . Info-prev-reference)) nil nil nil nil = Info-scroll-up nil nil nil nil nil nil nil nil nil nil nil Info-index-next = negative-argument beginning-of-buffer nil undefined ...])) char-table-subtype( #^^[3 0 nil nil nil nil nil nil nil nil nil Info-next-reference nil nil nil= Info-follow-nearest-node nil nil nil nil nil nil nil nil nil nil nil nil n= il (keymap (110 . clone-buffer) (9 . Info-prev-reference)) nil nil nil nil = Info-scroll-up nil nil nil nil nil nil nil nil nil nil nil Info-index-next = negative-argument beginning-of-buffer nil undefined ...]) eval((char-table-subtype (read (current-buffer))) nil) eval-expression((char-table-subtype (read (current-buffer))) nil) funcall-interactively(eval-expression (char-table-subtype (read (current-= buffer))) nil) call-interactively(eval-expression nil nil) command-execute(eval-expression) Not of crucial importance, but perhaps of inerest to know if it is not alre= ady known. Perhaps it is known? I found it some time ago, but was testing today= with different Emacs versions, and found now it seems to appear first in version= 26.