From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Info-mode patch Date: Mon, 26 Jun 2023 22:17:26 +0200 Message-ID: References: <86fs6ertto.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 27 04:23:02 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDyM9-00093M-Ax for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Jun 2023 04:23:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDyLI-0005Fn-Lh; Mon, 26 Jun 2023 22:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDseS-0000fA-Do for emacs-devel@gnu.org; Mon, 26 Jun 2023 16:17:32 -0400 Original-Received: from mail-vi1eur04olkn2016.outbound.protection.outlook.com ([40.92.75.16] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDseQ-0002m6-Mo for emacs-devel@gnu.org; Mon, 26 Jun 2023 16:17:32 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crBw05AdAsqm0PVEcxznvHdULbeJDUFMmj7+QRtC3BZvKDQiTKXwfLSqIgIiazVogfgNHBN4SoBXCKogRisuCj0TvnZK9/l4U47ljeR3YHR6M7ydhz5ITOUhDU7bCR+etvux9yCX0PmluwlPsVxb4BHb3jbGh26XV5iDpSscjRQhcyXWfNznyIddLxWzoKu0h324MLdJcZvhGFzqKShjOXlDYrXYC0guFcC8DqZDPaEelia9AWwtgjMk1N4KAf2U4+GbBN9ePnwia7NYdJnGlbdr172rlZZUwMTrZ99d2CXIhbMV5Xoq0+IpXN1WIxt3RLL4EM0kBzoQfQAsW1j0kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HkLKGHqasNCZBPy6a3nH7M14tvDPB9eRuD+QYYAqcr4=; b=l/BjfdEzAK9byt81GCUlpihmyRsXqS+j8HGs3UyRqUmluxxBoGIHtGRQvOK4KbtEJCu/FhoiuWClniPZU23FYS8G+kgeGjQS1AEeahhBCkFRz2SC0yrAM7Rv+xrDM0mBbMTS+rFbZtBZoRxO9hg9S/A2S84kBfUlBDXoSH62/aorVVId5BLnfT6i7vl4LxgER5tjdCjR+T7JUtfqUmG3jy5qOfIrZ7ilJycrlpPTOx56ZXcFbps++2QA9uUT8Hj/yv4ZSXU2h+yttkonsnan/FMrDAVHRvYG5dO1Lh9ncW+DgOxoV3l2Q3m9ck8LpOcVR36y3j1dmqW1NBo5CuecTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HkLKGHqasNCZBPy6a3nH7M14tvDPB9eRuD+QYYAqcr4=; b=aAtajijUiWAC6tplpOlT0mDCd1rfLIuwv+jz3ap1Ki3gEuPVV6xUdKEdcytttABSPKgvnxeTn5tfC9CCAoPKqXQtcnX5X0Ar49G95W6+fNJyHIFhUJuSxMb/ogCTOqIid3orRVEQU4hNH+7O/R4gfAt8vWttV6G+ZzJ0W/nUpeMnITkSrmwz+tNO4fioAIMrz/OrfOAv+h2/kvEIVHSYNtlE6pUUeza0EdtaEmeu9AaUO563cHhih735KjRyn7Blz1eyjkvCgnaVZOfSy8UPf+N0r8nAJ1vmpXLyAEKQw6bB7PoTIJuJPo0/6+lDe39w2rRgqjR2TXhrZmUSwIS+7w== Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) by GV1PR09MB5778.eurprd09.prod.outlook.com (2603:10a6:150:9e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Mon, 26 Jun 2023 20:17:28 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::4a5f:42f9:d78f:2021]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::4a5f:42f9:d78f:2021%4]) with mapi id 15.20.6521.026; Mon, 26 Jun 2023 20:17:27 +0000 In-Reply-To: <86fs6ertto.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 26 Jun 2023 20:56:19 +0300") X-TMN: [24u4pG+r+fzcLWnmrq/gpnY9DZV+gi5x] X-ClientProxiedBy: BE1P281CA0240.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8c::9) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <82h6quhtbd.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR09MB4977:EE_|GV1PR09MB5778:EE_ X-MS-Office365-Filtering-Correlation-Id: 147cb690-de5a-408d-eaab-08db76825c97 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VvAcbiNJTxqIvP5kbAKy4IrD66XW+YoD0k771P2ptPEcWkvYmuSmUY0mZX32Fqaqm0yqm14Zi3jeuLJ4TG4dXJa+KtDgKTTuZJjTqEUep/+xBzd3b9Jr+GbXfU6mYQVrxjvYxZg6Nqx/Eah1jJOstu/NaRXH06nXqdbwaOJdo3En1F5IjXBrqLqW5kcMzp+FUJuLk71m5GXcC18eWOJKMBYfxjhpRXEZSMDSA9M3I3dJjr8xU/oZLmH5VJMkXP7426TFZgd8VfY/0bj9sPYE8eb7i6cCynfIOJwfOWDVjJIzeJfPdtw/0gKEJqg6ud+4q9R/Hg+HBw8kpHbjIlQduvv2YqiX7K90rAXXnn1TCWjj/LTay0BbZI8tlKtFvyWKeaNebNO9JfOYLRuYf0Y3jC6SrmycIfCbOrSLbNi29XKlLpWGHeax9vWnNbHZ3HfDuRBHpsuFWb/1OI17NZWqf7aDGhUUHguMpz3zlEJVN7+qKCzdFJywO+4JqscQ8i61i3Js6vyMtzRTW9Ib/jG3nXzjRK/j0srHzXLWEG1/025NpZkpWdV4MBHQqmyIACsl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LRsPRcaIK9OnlltrVH4xrbApgmn8u9YHqFr/fE5Y2UJwbun8trLanxMklH2Q?= =?us-ascii?Q?Y+hqrwLm/8NDlEtHxbyL5R8Y/mVeBi7gnGWDWBKKs7R/sV4+KQpafPz/7232?= =?us-ascii?Q?hg0tb/aGRsJEzxQmKVHo7LCteR66kn4tlxlnmWVjc17Spv4UdEzabLeDFaem?= =?us-ascii?Q?z//d43kCIZZ6iRaX0ut1+ltsxIN15oX6K7iHwx00CKS7l18Qxq5lK8mqforo?= =?us-ascii?Q?TFNrbFVks0DSuVlOpaNLcww8FucA1+5pyl/q7b9V3ZngpwAEHEg3II8A1vi/?= =?us-ascii?Q?LDCWoO5G5EdxMlzCgUwGGGJfkaEP0jAJWX4kfROR+rGMQQTn4IbEaF6qbv0E?= =?us-ascii?Q?bVtvylGnYg6deXDP8yPYYk0YKnarEUMa5lQa15wvUD3nHVKFq77kedb2plF0?= =?us-ascii?Q?V13P1LF1Mc1l02Iru5bScyDrxDYoBqZIfcRCjLIRr8YxTI9xL5VPm1Ayh5e4?= =?us-ascii?Q?W64vnYeU7aNc7POro58Rl+fPZL90GnBV7AMZfJUf8corEoiBoJuxwv6J8UrX?= =?us-ascii?Q?CXLwUCKZ0vxz/KnJP9UHFXFMlyIb+4nVfdoQMUhxDcQ0frwsrGVcgNIaUCFs?= =?us-ascii?Q?K2/lmwqG5O1Dks1OltNi+d0lwlprflqufVBF+IXZD4Tb3yEyEJHKzjdlyPlV?= =?us-ascii?Q?JJ X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-64da6.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 147cb690-de5a-408d-eaab-08db76825c97 X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4977.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 20:17:27.9162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR09MB5778 Received-SPF: pass client-ip=40.92.75.16; envelope-from=arthur.miller@live.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 26 Jun 2023 22:22:06 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307248 Archived-At: Juri Linkov writes: >> -(defun Info-directory () >> +(defun Info-directory (&optional window) >> "Go to the Info directory node." >> (interactive) >> - (Info-find-node "dir" "top")) >> + (with-selected-window (or window (info-window)) >> + (Info-find-node "dir" "top"))) > > I wonder why you modified a lot of commands instead of implementing > a non-intrusive approach of creating standard wrapper commands like > > (defun Info-directory-other-window (&optional window) > "Go to the Info directory node in another window." > (interactive) > (with-selected-window (or window (info-window)) > (Info-directory))) Can you control on which frame the input goes when prompted by original function with a wrapper approach? I changed quite few prompts a wrapped stuff with both with-current-buffer, and with-selected-frame to achive that. I don't think I could do that if I wrapped stuff. But what do I know, perhaps there is some way? Also I didn't wanted to change API. Not that I believe that there are many 3rd party packages for Info and Help modes, and that people actually customize those, but anyway. Wrappers would be a new API, which all require at least some documentation etc.