From: Arthur Miller <arthur.miller@live.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Patch: debug-instrumented predicate
Date: Mon, 04 Oct 2021 21:25:26 +0200 [thread overview]
Message-ID: <AM9PR09MB49770BBDADD9111B50C8A91B96AE9@AM9PR09MB4977.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <jwvv92ckbc3.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 04 Oct 2021 12:24:13 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I have seen that internal code in debug.el uses advice
>> 'debug--implement-debug-on-entry' for instrumented symbols, but I am not sure if
>> it can be used as a stable check long-term. Suggested patch uses it, but if it
>> is considered internal and subject of change, please add a way to have a stable
>> predicate.
>
> Can you give us a concrete use case?
Concrete use-case would be to offer a user some kind of gui to instrument or remove
instrumentation for debug/edebug/profile/trace.
Helpful.el is the one package I know off that offer a button for debeg/edebug
and trace in style of enable/disable.
I have re-implemented helpful in terms of built-in help infrastructure and am
using those functions I posted as patches when toggling on/off above mentioned
instrumentation.
I would prefer to use a stable API instead of something based on internal
implementation that can change without notice.
I don't think it is unimeganble that someone else might develop some other tool
that might work with profiling, debugging etc and might need to know if
instrumentation for a function is on or off.
next prev parent reply other threads:[~2021-10-04 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 15:20 Patch: debug-instrumented predicate Arthur Miller
2021-10-04 16:24 ` Stefan Monnier
2021-10-04 19:25 ` Arthur Miller [this message]
2021-10-04 20:00 ` Stefan Monnier
2021-10-04 21:58 ` Arthur Miller
2021-10-04 22:14 ` Stefan Monnier
2021-10-04 22:56 ` Arthur Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR09MB49770BBDADD9111B50C8A91B96AE9@AM9PR09MB4977.eurprd09.prod.outlook.com \
--to=arthur.miller@live.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.