From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: Native compiler - passing command line options to C compiler Date: Mon, 30 Aug 2021 17:00:08 +0200 Message-ID: References: <83bl5fkvky.fsf@gnu.org> <83v93njc3x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23289"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 30 17:01:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKin8-0005rn-TS for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 17:01:43 +0200 Original-Received: from localhost ([::1]:34872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKin7-0003s4-DE for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 11:01:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKils-00033V-U8 for emacs-devel@gnu.org; Mon, 30 Aug 2021 11:00:24 -0400 Original-Received: from mail-vi1eur06olkn2013.outbound.protection.outlook.com ([40.92.17.13]:9600 helo=EUR06-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKilj-0001cm-NG; Mon, 30 Aug 2021 11:00:24 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EoM+y+tKgefEsxeXjBOMiyBxMlQUrKhR7i+/mRXRHZFtA56H6M9snHvDk0mEGDOzeQcRkmXgV+U27y+cS7KPDX7kwhr/zwsmpiI0yNyEgkthkdsQh/N6v/g97JGIrI8UmGsuLVcZfRBMctJgvpVmLwof6K0PpPC4ZCm2pxxc5zO/KStICZeHWoefIOmFILxg+3LirzQGki7KvXijpoAv7I2EwZjuyEabFZVEa8zwZGQsDllOTiygcm+krEze0LU+jp1dROMUWJNnpEpgpao9sd1RDB/pput+NIh+oI4O1jpiPvIJHgz7RnH0JwOGyjb4kzZa/ApiW69bF/RIlUoYcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XujALSb42WNG4E4wVRDWfRO6Y5ctMhzQGjIO/J+qJN4=; b=oNoVhDOtQHO9FIoOWhEoc8tpMisIcOeeWTLNVhW8ZdugoAIJOHi2Ni+VX5zfB1Q+UKmUpmNDTN7/g4gPMigRCOOSvjvI9Kru9HapgpNQUvfDptX/Jm2MfNNHpH+1X/12CpnBKHYgQpGp26DLU7M1scw801rYpGHIB4PVJBEsjeRQU4fNSD1wHdKNaYDwtTs5R5ndfE0KGkluni6e548NYbiljVSEQMQXNpyAdFQj2FDY7sB4EHM0T9YTGcGmHqvDVThGwEfvmcz9pUEe9hW7Y9OnHc09JrWXf8/cDMl37ULts3VClbg9St22isxrhxY1tsrF5FWrUhpBAgrJnTN9XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XujALSb42WNG4E4wVRDWfRO6Y5ctMhzQGjIO/J+qJN4=; b=LSiimAYiSGz+iGuRbDz6nsqZB/kOM1LIB0z1gs20Xd8+Pt3WlVgzrOIRD0JBImSbOBpjZt76QtVI0H6szghmdKBJiF0L1Ya/qKMgOE9yYuAKOGqJiVtGVQfWByQRnFXaYgZveAoUD21LCkIsFKkyVUJKVDyR0EkIuDR/FszPnbRgvzONZ1X0Ni2FWN9oVPydKeelmyxxsjf+ZiqR6tPOzokJU9rerl6JEdmlIMdKTY8M4ptKsEuKEFFdWusxpxqrsVClzOX0fxriPqVsVG3GQMrdjhxl1Eq2RkPW/ZWm17b5s+bFv1t0EPxKAlqeC3dkDdqzV8XgX9PHnDtAdubnaQ== Original-Received: from DB8EUR06FT042.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc35::4f) by DB8EUR06HT141.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc35::337) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Mon, 30 Aug 2021 15:00:09 +0000 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2a01:111:e400:fc35::4a) by DB8EUR06FT042.mail.protection.outlook.com (2a01:111:e400:fc35::204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 15:00:09 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:2AF8B7D0ED186C4D3198186B65E3FDB3C8608F529E2F4E0B1EC0514B1AEEBA42; UpperCasedChecksum:4326F6CB9182D6FBAB7FE1FD0E76A984B26D2267009B7F6B23484458BDBC8D11; SizeAsReceived:7605; Count:46 Original-Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::35f2:ac79:ee50:c46c]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::35f2:ac79:ee50:c46c%8]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 15:00:09 +0000 In-Reply-To: (Andrea Corallo's message of "Mon, 30 Aug 2021 14:28:18 +0000") X-TMN: [ekCcINpR5c86l3tLvpR5xSg1HoPjvNaR] X-ClientProxiedBy: AM6PR01CA0054.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::31) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <87fsur9dvr.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (81.232.177.30) by AM6PR01CA0054.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Mon, 30 Aug 2021 15:00:09 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 49e8d4a5-ab00-42f7-6be7-08d96bc6dc44 X-MS-TrafficTypeDiagnostic: DB8EUR06HT141: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p/MTWyeTTtufZ/9eYo8bp9vx11CVlDyNNEl59vnwZmvxViBWAm3vEbJ9zIkhGDBCvIFymf3liAJKZzEppXEySh1jrXVg8Dys/4Xaj5IhPdCQWUpn/rG2w+HbA0HPHpgDhs8NkmbiTL9Uhl3eX3o++GaMU//OE3IeJJqFizIBKG9QZE2CKSAepqiPBktBh5gRBgezF41MrKx+zq75WhRSBlanU3CXI5HS9TibN0HsQ0zsoYH5Qfb4SSbBkvNNGNKPDkr/Qx8TgCDEDs6GHkDkuVBtc6r3WX1JRaDCHt+4jWRHkDpLcbMkNxzIpkRcEJFbKuQKw8VD3P37hcM452ifBqOudswt8lDQt5BtgwiMHje3ND12yzSOaJK6TJds/PBKcaMzOTZGB9LJPzX6LvZp5PBvyCEnfZRL6Fkdxmu9eej/8YFN4yWpbxWlxkGb+CRK X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: z/hTgrRJow3V+LpGc3YqGZ0KuRs4ATp8t8ShyhnZx0kxev6x71h283kcG9IzJbRLn+pRdGPipYTgdYT+zjh7/s4ofb3CkrCteX8D74eIMo1VxtbfIMIQq2XRVZGZoUNUycFcTYGEzDpojbp77AExrQ== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49e8d4a5-ab00-42f7-6be7-08d96bc6dc44 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 15:00:09.6109 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB8EUR06FT042.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR06HT141 Received-SPF: pass client-ip=40.92.17.13; envelope-from=arthur.miller@live.com; helo=EUR06-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273503 Archived-At: Andrea Corallo writes: > Eli Zaretskii writes: > >>> From: Andrea Corallo >>> Cc: Arthur Miller , emacs-devel@gnu.org >>> Date: Mon, 30 Aug 2021 12:59:45 +0000 >>> >>> I think this "defined (WINDOWSNT)" should be there so that compiling on >>> Windows the check over "gcc_jit_context_add_command_line_option" it is >>> always compiled even in case the libgccjit.h provided at compile time >>> does not define >>> 'LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option'. >>> >>> A newer version of the shared library including the entry point might be >>> provided later on and will be used at runtime. >> >> You cannot use a libgccjit.dll of a version for which Emacs was not >> compiled, unless it is binary-compatible. If Emacs was linked against >> libgccjit.dll that didn't support >> gcc_jit_context_add_command_line_option, then it would not work to >> install a newer version of the DLL that does. > > Okay, I thought on Windows worked differently and we could handle the > case of a symbol not available at compile time but at runtime. In the > light of this we can probably perform some more clean-up. So does that mean that windows check is not needed in add_driver_options as well?