RE: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

["Vincent Belaïche" <vincent.b.1@hotmail.fr>]

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Dear John,


Well, I must admit that I am a naughty boy that has not filed any bug before making this fix. I of course did some basic tests before comitting and it was OK.


The bug description is as follows:


Using the ``string within round bracket'' kind of printer definition (round bracketing meaning left alignment) for a local printers does not work because the ses-local-printer-compile function does not handle this case.


IMHO taking this bug fix is not risky and that would make the local printer feature more complete. The alternative fix would be to document that in this release local printers cannot be defined this way, but it seems so simpler to fix the lisp than to obfuscate documentation...


   Vincent.


PS : I'll try to join this discussion thread which you mention when I can find it, sorry I have to go to bed now (tired)...

________________________________
De : Emacs-devel <emacs-devel-bounces+vincent.b.1=hotmail.fr@gnu.org> de la part de John Wiegley <jwiegley@gmail.com>
Envoyé : lundi 1 août 2016 18:26:50
À : emacs-devel@gnu.org
Cc : Vincent Belaïche
Objet : Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter.

>>>>> "VB" == Vincent Bela?che <vincentb1@users.sourceforge.net> writes:

VB> branch: emacs-25
VB> commit 8a38e948b039516e70176ebe20c5349e2ade6ac5
VB> Author: Vincent Belaïche <vincentb1@users.sourceforge.net>
VB> Commit: Vincent Belaïche <vincentb1@users.sourceforge.net>

VB>     Fix local printer set to left aligned string formatter.

VB>     * lisp/ses.el (ses-local-printer-compile): Add missing case for
VB>                   left-aligned string formatter.

Hello Vincent,

Can you please include which bug this is fixing, so that I may verify that it
was indeed on our release blocking list?  We're at RC1 now, so any change --
however small -- requires great scrutiny.

Alternatively, please link to the discussion thread where Eli gave the OK to
commit this to emacs-25.

Thanks!
--
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2


[-- Attachment #2: Type: text/html, Size: 3851 bytes --]