bug#36550: Small bug fix in recentf.el

["Linus Källberg" <linus.kallberg@outlook.com>]

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Den 2019-07-09 kl. 15:04, skrev Lars Ingebrigtsen:
> Linus Källberg <linus.kallberg@outlook.com> writes:
> 
>> Okay, makes sense. I just thought it looked a bit weird that the first
>> character on the next line is highlighted as well. At first I thought
>> something more serious was broken in Emacs, that's why I looked into it.
> 
> Oh, I didn't catch that the first character on the next line is
> highlighted.  That does indeed seem like a bug.
> 
>> A middle ground would be to move the newline but put a single space
>> before "%]" (or set :button-suffix " "), to keep the behavior described
>> in the commit message. But it's no big deal in any event :-)
> 
> Could you propose a patch that avoids the highlight on the next line?

On second thought, I don't think the real problem is in recentf.el, but 
rather in the implementation of widgets and/or faces. It makes sense to 
keep recentf.el as it is.

I'm probably not qualified to fix the bug, at least in a timely manner, 
but I did some experimenting and came up with an MWE, which is attached 
to this e-mail. Hopefully it can be of some help.

Best regards,
Linus Källberg

[-- Attachment #2: widgets-mwe.el --]
[-- Type: text/plain, Size: 1568 bytes --]

(require 'widget)

(eval-when-compile
  (require 'wid-edit))

(defun widget-example ()
  "Create the widgets from the Widget manual."
  (interactive)
  (switch-to-buffer "*Widget Example*")
  (kill-all-local-variables)
  (let ((inhibit-read-only t))
    (erase-buffer))
  (remove-overlays)

  (widget-insert "Move the mouse over the links below to trigger the highlighting.\n\n")

  (widget-insert "This one looks normal:\n\n")
  (widget-create 'link "with brackets, w/o newline")

  (widget-insert "\n\nThis one looks okay, except that preferably, the whole first line\n"
                 "shouldn't be highlighted, only the text:\n\n")
  (widget-create 'link "with brackets, with newline\n")

  (widget-insert "\n\nThis one, which uses roughly the same parameters as are used in the\n"
                 "recentf dialog, looks really strange because the first character on the\n"
                 "next line is highlighted as well:\n\n")
  (widget-create 'link :button-suffix "" :button-prefix "" "w/o brackets, with newline\n")
  (widget-insert "A <- this character shouldn't be highlighted.")

  (widget-insert "\n\nThis one looks normal:\n\n")
  (widget-create 'link :button-suffix "" :button-prefix "" "w/o brackets, w/o newline")

  (widget-insert "\n\nThis one should look the same as the previous one, but it doesn't\n"
                 "because it is followed by EOF instead of a newline:\n\n")
  (widget-create 'link :button-suffix "" :button-prefix "" "w/o brackets, w/o newline")

  (widget-setup))

(widget-example)