all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: arthur miller <arthur.miller@live.com>
To: T.V Raman <raman@google.com>, "akrl@sdf.org" <akrl@sdf.org>
Cc: "monnier@iro.umontreal.ca" <monnier@iro.umontreal.ca>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: Suggest: Byte-Compile package-quickstart on a separate thread?
Date: Mon, 28 Dec 2020 23:47:39 +0000	[thread overview]
Message-ID: <AM0PR06MB6577CBEFD9DEC2AFC215543F96D90@AM0PR06MB6577.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <24554.21310.267903.605613@retriever.mtv.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]

Since byte compiled quickstart file is  there just to speed up Emacs startup time a bit, it is well, not of some crucial importance to byte-compile it immediately. Isn't an idle-timer sufficient? Just so it gets it compiled at some-time before Emacs starts again. And if compilation fails Emacs can output a message to *Messages* buffer. Would that be sufficient?


-------- Originalmeddelande --------
Från: "T.V Raman via Emacs development discussions." <emacs-devel@gnu.org>
Datum: 2020-12-28 22:52 (GMT+01:00)
Till: akrl@sdf.org
Kopia: emacs-devel@gnu.org, monnier@iro.umontreal.ca, raman@google.com
Ämne: Re: Suggest: Byte-Compile package-quickstart on a separate thread?

I buy your first argument. The second not so much so though it's moot
given the first argument.
Andrea Corallo writes:
 > "T.V Raman" <raman@google.com> writes:
 >
 > > "T.V Raman" via "Emacs development discussions." <emacs-devel@gnu.org>
 > > writes:
 > > Here's a small patch  that uses make-thread:
 > >
 > > git diff package.el
 > >
 > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
 > > index bc450b09d0..104c2d8e71 100644
 > > --- a/lisp/emacs-lisp/package.el
 > > +++ b/lisp/emacs-lisp/package.el
 > > @@ -4108,7 +4108,7 @@ package-quickstart-refresh
 > >  ;; no-update-autoloads: t
 > >  ;; End:
 > >  "))
 > > -    (byte-compile-file package-quickstart-file)))
 > > +    (make-thread #'byte-compile-file package-quickstart-file)))
 >
 > I think this patch might have also the following two issues:
 >
 > - Doing intense computation in a Lisp thread usually make the system
 >   extremely unresponsive, and it does it certanly if the code does not
 >   yield.  As the byte compiler never yields the 'blocking' effect should
 >   be the same as running in the main thread, this because this Lisp
 >   thread is never preempted.
 >
 > - What about if the file being compiled is loaded before the byte
 >   compilation is completed?  This is another tricky part that has to be
 >   addressed (as we had to do in the native compiler).
 >
 > Regards
 >
 >   Andrea

--
♉Id: kg:/m/0285kf1  🦮♉

--
♉Id: kg:/m/0285kf1  🦮♉


[-- Attachment #2: Type: text/html, Size: 3499 bytes --]

      reply	other threads:[~2020-12-28 23:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 14:49 Suggest: Byte-Compile package-quickstart on a separate thread? T.V Raman
2020-12-28 16:31 ` Stefan Monnier
2020-12-28 17:34   ` Stefan Kangas
2020-12-28 18:26   ` T.V Raman via Emacs development discussions.
2020-12-28 18:38     ` T.V Raman
2020-12-28 19:19       ` Eli Zaretskii
2020-12-28 19:52         ` T.V Raman via Emacs development discussions.
2020-12-28 19:58           ` Eli Zaretskii
2020-12-28 20:34       ` Andrea Corallo via Emacs development discussions.
2020-12-28 21:50         ` T.V Raman via Emacs development discussions.
2020-12-28 23:47           ` arthur miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR06MB6577CBEFD9DEC2AFC215543F96D90@AM0PR06MB6577.eurprd06.prod.outlook.com \
    --to=arthur.miller@live.com \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.