From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sat, 16 Dec 2023 17:07:22 -0800 Message-ID: References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <83v8a3qh6m.fsf@gnu.org> <834jhadvkt.fsf@gnu.org> <7aee7e42-c07d-9131-18a9-4806f07d4267@gutov.dev> <83a5qw7izt.fsf@gnu.org> <172531702081590@mail.yandex.ru> <212931702208489@mail.yandex.ru> <0c6e2e14-b494-a8cb-3893-ffb39577baf9@gutov.dev> <7b17c99d-6e4b-43b3-af93-993901a3a4ea@gmail.com> <95071702343720@mail.yandex.ru> <78ffdcf3-e322-49ea-a0d5-d0485ade9e73@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Denis Zubarev , "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 02:08:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEfdm-0004tJ-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 02:08:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEfdS-0005pm-P4; Sat, 16 Dec 2023 20:08:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEfdR-0005pe-EY for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 20:08:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEfdR-0004zq-60 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 20:08:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEfdR-0003sy-Ot for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 20:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 01:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.170277526514908 (code B ref 67061); Sun, 17 Dec 2023 01:08:01 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 17 Dec 2023 01:07:45 +0000 Original-Received: from localhost ([127.0.0.1]:56386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfdB-0003sM-5O for submit@debbugs.gnu.org; Sat, 16 Dec 2023 20:07:45 -0500 Original-Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]:45232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfd7-0003s2-On for 67061@debbugs.gnu.org; Sat, 16 Dec 2023 20:07:43 -0500 Original-Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1fb33059466so1403044fac.2 for <67061@debbugs.gnu.org>; Sat, 16 Dec 2023 17:07:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702775254; x=1703380054; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k6btj+CiaUQxXiY4FFW5EsXw5DeRUA4DhuFXBQEN+TA=; b=VBgaiwap+3g8BMLGaxkXYuuSB4jX8n90HT7kFgnEpc6YXdB4V360+kVi66rakRNPR0 jmn+ZmwrkyRwQY2KDew+EepHiQyAnhfODXfxA4xlGsxWUjv0QCnUxAq4u98dRiSweqgj ju/GNlvG6hWcGhNiWgSRXLQKaIGDizBQ9K/QKI2rjID3wYf9a1KKAFiIXa49UmkZVNJg yJA3FrG5N1Vahh7YAShyE8qilwQxtFDEu8zOlWIyVP7Pr2o/yCQvx7XwHsd1Iv2YbvTs qCrk4rqJ00Ai5tXt9UVYdtEbt64CSbcg576ZUzveWBfO7luMYLaJAxXZUCRBOLl97IWe /QCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702775254; x=1703380054; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k6btj+CiaUQxXiY4FFW5EsXw5DeRUA4DhuFXBQEN+TA=; b=XtO9eWo7J8s8x7SNCg53wZetEi0og693aMybar0pf6mfauew1cXdZqxBrErpnyb3GC KEPuR6tjH0EoguF7XtbgN1+4s6MZ+vOMGlnpxO8UBAqBDHe7BJ5JzTX8I3dIc0OEZqZj 9+ux0PWOmmpnD+fEiP/LvTOJQSscw/jnArxIPXGoy0dOO4q11HpycPNsr9SFMB7m8lJB gmhcPpiKHpFOLtXcbETj9KE0nQbvtWh3FMaMUbsPWh7NGnHWvOkG7r9eAGfT3Gz8ewrT PYPOYFuQwb6koOlRzXmjg5H+2MXsU0ABTaWeknMmwrVlc+gOgTf4RfFagB/Ifse2AWB5 0Qxg== X-Gm-Message-State: AOJu0YwXNtD3i4FniDoN3unYN66KuzBsoYJe1TR4dxRmil0qiwDRUTZv X5lqZ4kU0Cbvpog95vszvwE= X-Google-Smtp-Source: AGHT+IGUYC9zEW0Phi/px/WEwHXEXZAUBktKRODSabMGit4Bx8IRkQNUZEFOzD2ArbQhbH2WablQJA== X-Received: by 2002:a05:6870:9720:b0:203:96a3:162d with SMTP id n32-20020a056870972000b0020396a3162dmr1736126oaq.19.1702775254489; Sat, 16 Dec 2023 17:07:34 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k24-20020a170902761800b001d395e5c800sm2038542pll.289.2023.12.16.17.07.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Dec 2023 17:07:34 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276398 Archived-At: > On Dec 14, 2023, at 3:51 AM, Dmitry Gutov wrote: >=20 > On 14/12/2023 07:54, Yuan Fu wrote: >>> I think the 'definition' feature is good for it (going by the name, = since it's an implicit variable declaration), but it could be split off = into a separate feature too. >> As long as it=E2=80=99s not added to the definition feature, because, = again, definition is at level 1 and I don=E2=80=99t want to keep level 1 = minimal. >> Maybe we can use local-definition, or something similar, to signify = that this feature highlights scoped definitions. >=20 > But you think function parameters should be in 'definition'? They are = also "scoped", I would say. I don=E2=80=99t think function parameters should be in =E2=80=98definition= =E2=80=99. In fact, in my head, only the variable/function/class name of = top-level constructs should be in =E2=80=98definition=E2=80=99. Now I = can see that the name =E2=80=98definition=E2=80=99 is too vague for my = original intent, and most ts modes probably don=E2=80=99t share the same = interpretation as I do... Maybe we can allow definition to include more things and move it to = level 3, and add a more restricted =E2=80=99top-level-definition=E2=80=99 = to level 1 to take it=E2=80=99s current role. WDYT? Yuan=