From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59617: 29.0.50; Add indent styles to all tree-sitter modes Date: Wed, 30 Nov 2022 13:44:39 -0800 Message-ID: References: <87r0xp4k4p.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15047"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Theodor Thornhill , 59617@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 22:45:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0UtR-0003dT-3L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 22:45:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0Ut6-00067A-HM; Wed, 30 Nov 2022 16:45:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0Ut5-00066w-2b for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 16:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0Ut4-0005OW-PC for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 16:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0Ut4-00028f-4E for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 16:45:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87r0xp4k4p.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59617 X-GNU-PR-Package: emacs Original-Received: via spool by 59617-submit@debbugs.gnu.org id=B59617.16698446928198 (code B ref 59617); Wed, 30 Nov 2022 21:45:02 +0000 Original-Received: (at 59617) by debbugs.gnu.org; 30 Nov 2022 21:44:52 +0000 Original-Received: from localhost ([127.0.0.1]:35284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Ust-00028A-KL for submit@debbugs.gnu.org; Wed, 30 Nov 2022 16:44:51 -0500 Original-Received: from mail-pg1-f169.google.com ([209.85.215.169]:37428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Uso-000284-U8 for 59617@debbugs.gnu.org; Wed, 30 Nov 2022 16:44:50 -0500 Original-Received: by mail-pg1-f169.google.com with SMTP id v3so17301147pgh.4 for <59617@debbugs.gnu.org>; Wed, 30 Nov 2022 13:44:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=AY7A2r7SnF5hfdzf0lwa+tgHBYT51sTMfKvD0TbziSk=; b=QJagwIP/+iqMZPSMwRDcR01gOfHwfkPV72qjfYhRywlyPbJqipV9+NXsCHOp3/cjkM iQeNo7goiqpfwUs+7dYv7Oy9LpSIOJjHn2MKeMLhJRqZarexmqsAw8YRyO52KgHfy6Zy cWTgdE1bzFy76/gJJFdYPYKcrKWeXm+7DCdXdEO0atNoEnNnOlhfVGNjj4YOx0APeL3Q 7IrgjNvEbNCknkB0VBZ+gA8S7Z+sllrowRvIeJ6DwllOBuW4/8nBBzF9yd7/xR0OsYat FKzK3nYJNJ60al7ZILwc0Tm6sZ0Bm2wepo0S5IfPIMdGD3QkTCXIZfjgvSUBJMkATq6M aMSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AY7A2r7SnF5hfdzf0lwa+tgHBYT51sTMfKvD0TbziSk=; b=6ZHG+DvueScQY4wJj0YBD3BQikJyAvSB3/rm3StsyaYz8Xan9rUzNlv7EFdMiFubZ6 rWwb/8Xl9zSN8ah2i/wfFQ9hZ3lOJ3KVk27yK8+ntbko1wUvXwzHYi6B7UDxUc4gLXRn RfFTCegeEasLFFIgLCmmqr3JK8ChwrlA4iubxZuxkblrSKvM/+Ufv3yUyt+a1VXzSB6r y8yM4bcCOKPBvg+ZJ34S8mJbLOprNnIBQCK0iDT5Cy9mj3NS2h5aC1WZdtiLTBIY3UYx xwIYosPoZfWLTlK1XE8sUAoq2ZElDKjP8TCSAGiRvx9Rn/xVclCSfy9OQPIg97vqCJao Ktaw== X-Gm-Message-State: ANoB5pkd0Ka+Dqq96qaymDu1JrMbBFrXqGuLuFPZK5jn0FALoDW8UkS7 oLffr5Y3toL4oqXgIgLLS7w= X-Google-Smtp-Source: AA0mqf6/mgTS1tlT3Nxi4/Yin/H1SpsavORdF5ZIcOBtnok+I1Fhu8Q9Oh1y8MBzr0UUFTCZow5xog== X-Received: by 2002:a65:6a01:0:b0:477:693f:b8d3 with SMTP id m1-20020a656a01000000b00477693fb8d3mr38285872pgu.333.1669844681026; Wed, 30 Nov 2022 13:44:41 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id i9-20020a17090a058900b00210039560c0sm3508223pji.49.2022.11.30.13.44.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2022 13:44:40 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249575 Archived-At: Eli Zaretskii writes: >> From: Theodor Thornhill >> Cc: casouri@gmail.com, 59617@debbugs.gnu.org >> Date: Tue, 29 Nov 2022 16:19:26 +0100 >>=20 >> Theodor Thornhill writes: >>=20 >> > Rebased on emacs-29. >> > >>=20 >> Is this good to go or should I change something here? > > Good to go from my POV, but I wanted also to hear from Yuan. > > Thanks. Hey sorry, I was busy with some other things. I=E2=80=99ve looked at the = patch, it seems adding a hook that sets treesit-simple-indent-rules would have the same effect, no? (Ie, user already can set a custom indent style) Like instead of (defvar my-personal-csharp-mode-indent-rules (...)) (setq csharp-ts-mode-indent-style (lambda () my-personal-csharp-mode-indent-rules)) you can just do (defvar my-personal-csharp-mode-indent-rules (...)) (add-hook 'csharp-mode-hook (lambda () (setq treesit-simple-indent-rules my-personal-csharp-mode-indent-rules))) This way there is no need to define a custom option and a function for each mode. And users can use the same variable treesit-simple-indent-rules, just in different major mode hooks. Yuan