From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter api Date: Sun, 26 Sep 2021 21:42:36 -0700 Message-ID: References: <83r1f7hydn.fsf@gnu.org> <83r1dselyo.fsf@gnu.org> <6A4CE984-6ACE-4E66-8EF2-F3D351C02248@gmail.com> <83r1dscpt2.fsf@gnu.org> <83o88wcof9.fsf@gnu.org> <83lf3zdh4z.fsf@gnu.org> <8965C4A0-79D3-4D77-A6BA-D07A6C93F7FE@gmail.com> <83ilz3cs4k.fsf@gnu.org> <04D19C1A-CD64-4156-B932-1C9FEEE4EC7B@gmail.com> <83zgsebc0r.fsf@gnu.org> <1F752923-F357-4A18-B6E2-0120F1B9BD37@gmail.com> <83fsu5bzem.fsf@gnu.org> <83zgsdad5j.fsf@gnu.org> <83sfy391ni.fsf@gnu.org> <03386E3C-A975-4ECD-BF89-6AC62F751725@gmail.com> <83ilyz8xdl.fsf@gnu.org> <86czp6ukpj.fsf@stephe-leake.org> <1AEED8A5-BF5E-45E5-AE22-9B405A710F9B@gmail.com> <83czp313tf.fsf@gnu.org> <7447C582-70CB-4599-BC76-AD5687D64250@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26894"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?B?VHXhuqVuLUFuaCBOZ3V54buFbg==?= , Theodor Thornhill , =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , Emacs developers , Stefan Monnier , Stephen Leake , John Yates To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 27 06:44:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUiVN-0006sr-2m for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Sep 2021 06:44:41 +0200 Original-Received: from localhost ([::1]:49798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUiVL-0006nI-TF for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Sep 2021 00:44:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUiTS-0004aA-DN for emacs-devel@gnu.org; Mon, 27 Sep 2021 00:42:42 -0400 Original-Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:42799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUiTQ-0003sS-J4; Mon, 27 Sep 2021 00:42:42 -0400 Original-Received: by mail-qk1-x733.google.com with SMTP id x12so2161148qkf.9; Sun, 26 Sep 2021 21:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Z/kil1Q1lHFYDaKMYZgfLkXvRmdbOg56IAZj0LXwET4=; b=Q5k2NR13c+nZPxClBSGlcOcb1zycTyrwH593RVYPEBcSuklmgtb57Gogk4kI1mmFBD 3Y3P1T49wopK68UMHDdaKZV/IfxnHI5tPw+R1nXV/SBp8npDgRayFzy3Fe4MLOuQ5drD wmjgmYKQ118otrAZOyIDdxyrnyC9TLp+kYKYQ6H178pBtLn1W975qYpMMbQWvL1fbhcH RChQUfI/oEyMVsJ4KHNR1laFVFEaWS7ArTbVTy1ieEgQZZw6X9tVry7EGpjgqESwB0d4 Jpf8N6gCAC2RiWi6so0EbFCrg3SCBu9uuoZ3azo3dJcPaS/ECVc6IZa+edUp7DXKZE8F eZog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Z/kil1Q1lHFYDaKMYZgfLkXvRmdbOg56IAZj0LXwET4=; b=3vdHRrnANERe1s11b0VCQ57Sfq0fGkIPKkMIPjMjS2HqNW86ANtVUCXh+TxGFV91Rd EcPoFztDWglGcfhfykqbNniU5/Bcv+HfgyVhgyEUDhw9o+0ojjY+EQM22DZ/+4IC5noQ 2H1EJB2nQzKrdbpxQJ3DlCMlv3tYwey5FYRncaEz7vrRkrYCuKMfPJ9uPkddPMe3WpDj RCG+kcwumYa/tk1IcJBZ0VjSHtgqd7wiPZqvISiYRAYJMW8pgAcmYLNNeO5i+sJABLd7 9eTWAkmSyBs5liouxXWHbxJAYNUfKlAW3IXa4M0XQQPt30/EfdMopooAgvUDB6457dSm 4cSA== X-Gm-Message-State: AOAM5320IjQsD7niLJCVM75Uqr8Jd0tgKa72PvMORp7Bwky3SPkB4Ufr b/aXWW04ZhY0o888jNY7Cwf5+EII1PgoBQ== X-Google-Smtp-Source: ABdhPJzkYemWFMAS1EFXqPeXfpyUgmBtqkraqnxvrIHa5NtKPRNZ06hCuB6chMKj2577TFZE31ODIw== X-Received: by 2002:a05:620a:54d:: with SMTP id o13mr22171883qko.265.1632717758412; Sun, 26 Sep 2021 21:42:38 -0700 (PDT) Original-Received: from smtpclient.apple ([2600:1700:2ec7:8c9f:c95c:f98c:63f8:fcf4]) by smtp.gmail.com with ESMTPSA id i18sm5368811qtx.60.2021.09.26.21.42.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Sep 2021 21:42:38 -0700 (PDT) In-Reply-To: <7447C582-70CB-4599-BC76-AD5687D64250@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.13) Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=casouri@gmail.com; helo=mail-qk1-x733.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275551 Archived-At: Currently, because font-lock.el uses functions and variables defined in = tree-sitter.el, it needs to require tree-sitter.el. Should we require = tree-sitter.el by default? Then what do we do when tree-sitter is not = available on the system? Should I wrap every reference to tree-sitter in = font-lock.el with (when (featurep =E2=80=99tree-sitter))? Or is there = better ways to deal with this? Another approach is to define everything tree-sitter related in = tree-sitter.el, and make tree-sitter.el require font-lock.el instead of = the other way around. Would that be better? Yuan=