From: Victor Orlikowski <vjo@duke.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH] Fixes to allow erc-dcc-get-filter to work properly
Date: Sun, 10 Feb 2019 16:07:51 +0000 [thread overview]
Message-ID: <AE5455C2-4553-4816-9FD5-A02530662AA2.notmuch@neverland> (raw)
In-Reply-To: <83lg2pnveh.fsf@gnu.org>
On Sat, Feb 09, 2019, at 04:49 AM, Eli Zaretskii wrote:
> As you see, the process whose filter is erc-dcc-get-filter is set up
> so that the name of its process-buffer is derived from
> erc-dcc-file-name, but I don't see the buffer-file-name of that buffer
> being set anywhere. If I'm right, then your change should use
> buffer-name (the function) instead of buffer-file-name. Can you
> verify that buffer-name returns the name of erc-dcc-file-name, and
> that using that return value resolves the problems you saw?
I can confirm that using '(buffer-name)' instead of
'erc-dcc-file-name' works *perfectly*.
Shall I submit a new patch, using that instead?
Thanks,
Victor
--
Victor J. Orlikowski <> vjo@(ee.|cs.)?duke.edu
next prev parent reply other threads:[~2019-02-10 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 17:47 [PATCH] Fixes to allow erc-dcc-get-filter to work properly Victor Orlikowski
2019-02-08 7:59 ` Eli Zaretskii
2019-02-08 22:00 ` Victor Orlikowski
2019-02-09 9:49 ` Eli Zaretskii
2019-02-10 16:07 ` Victor Orlikowski [this message]
2019-02-10 16:41 ` Eli Zaretskii
2019-02-10 19:02 ` Victor Orlikowski
2019-02-10 19:14 ` [PATCH] v2: " Victor Orlikowski
2019-02-15 8:18 ` Eli Zaretskii
2019-02-17 18:57 ` Victor Orlikowski
2019-02-17 19:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE5455C2-4553-4816-9FD5-A02530662AA2.notmuch@neverland \
--to=vjo@duke.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.