From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Line height issues with display-line-number-mode Date: Tue, 07 May 2019 21:49:30 +0200 Message-ID: References: <6fd496f0-7dd5-6c0e-5121-b618e7dca831@gmail.com> <83sgtqi02k.fsf@gnu.org> <83r29ahyz2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----LNAEICTKCG4FMYA2I8VQIJLA3SU58U" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="232403"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android To: emacs-devel@gnu.org,Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 21:51:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO67R-000yLW-WD for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 21:51:18 +0200 Original-Received: from localhost ([127.0.0.1]:52321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO67R-0005uD-01 for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 15:51:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO65v-0005rR-H6 for emacs-devel@gnu.org; Tue, 07 May 2019 15:49:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO65t-0004IC-Ho for emacs-devel@gnu.org; Tue, 07 May 2019 15:49:43 -0400 Original-Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:41647) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hO65q-0003zB-CD for emacs-devel@gnu.org; Tue, 07 May 2019 15:49:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1557258575; bh=VQb3buHXGbm8j/wuHe3c3xhi/z5ZVAxSwXeWP87mWgc=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=CqToSAkZj3pw5oxDS2VGuvrJatt7n0wYvWFKB34Q++19X01pMqKEetYR4WN78yJgBTiLsL4lcFQDl875Rb2EV3C9hpOylm4PBl69u2fdUNffKc+DYvDFRN6P2I5/3G0RWrxWVWFdPKESnnGK24ari601f5g+EjMQ8VJWERHLdYTzvKqXIjhR9IE7TvcmbSXN0//zS7uYhjG4qNSHlexCDi7r+YBJFXYknIuk8Ntu41slRNZhtbd6Sv9CNyDrCt3zYiSqqYbTcq9OMg62RUc+2/0FPeVHKvmFiTE0JGbk9goMmYwXvTPIDcuCDTtz/3fQu96QsA9dl/16SjIHFm16kw== X-YMail-OSG: yC4pjAAVM1k4umJkoY61Kj2._6SuRefddjNi5A_KHKn0.Judr7RLz5pFxI1WZnc UYp.kW9AmjRmDoCCmyZgLS7jwArD9WrU0yL.osfRWVmjVpEmzJp2.wN.e776Bi95auhrn.h029KS s8veuSPlUC6_NdN.IntREfgYYi2GETiYtsIDw6czthXGbi4Lp9syo9VTaAeP7e.u6_x1mYElJeYP Mhd47mRrzMCANHWCeIRBXZV9UQvjRIfaip02gEnL6_gwDBVAkZW2aOiMmDEFe.2YVL6ChGOhPgJx K49_YHFyR3jYE4E44n0OPj71jfd4QhpPIJtZUILJ0oPHgmmpIQdDskNnVNQG0_AVodYl3XJ8DFdH pMTNuQ1SJTPtBwaAOIXgNxuN0SKUSSXIr0.Gq04AY.RTcMF5Kbgi7eBUSyH8rEGdkgofRiD_bOAs EZJB_35ybB8YrCgerWjHUZcdxNgCHLUKf5MtxjLiw.C6mQPCkfSqdNFzBh_mp3unQrhTFOEIHoA1 k5O.4YeGRQtLXjXw52gcqiyVdHj9IjKSAFX_Fj.AbyxQkRla6IctVemWil0kTTg5yR3dsZTPtyo8 dxEtz5oOm2HAr8NMxyLj1kChR9w3wScrI54dyGHmPHzYoMpLojpx2sFCcvH4p.urTrqNE0V.o5WM h20pPSj1BpZEeEu9pJLWxpbGK46vw4KN0qBuSTjTeLpFkquFBL_.02Hx3poVQNjP5odnBwlTJDtT .FRH6r4fECb9VANUjCHPM17gt2t53oqNg9.inGtTkNBM4gnQihbRLXlGiPx0jyATDc4gy15tNkVb MeDhPFTauhbbtgkQfk_QzjC.rJhySQpAIt68ltRi4m Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Tue, 7 May 2019 19:49:35 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO [192.168.1.44]) ([2.152.205.184]) by smtp423.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c8c69de6ad1ce05431225af028ddf17c; Tue, 07 May 2019 19:49:33 +0000 (UTC) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236259 Archived-At: ------LNAEICTKCG4FMYA2I8VQIJLA3SU58U Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable If you go for this solution then, please tell it here if you push the patch= , to check if we don't have the same issue with the fill-column-indicator= =2E On May 7, 2019 9:09:23 PM GMT+02:00, Stefan Monnier wrote: >>> If you a re thinking about clipping characters on display in some >way, >> Or maybe we could have an option not to put a number on a screen line >> that starts with a display or overlay string=2E > >Not sure what would be the ideal behavior for compact-docstrings (no >line-number? Truncated line-number? smaller line-number?), but for >those "text lines turned into thin graphical lines" as in >describe-symbol, *vc-log*, and friends, I think the better behavior >would be to not display a line number at all=2E > >Rather than try and guess it based on the presence of a >display/overlay, >maybe we could require a specific text-property like `no-line-number`? > > > Stefan > =20 > >BTW: in nlinum-mode (and presumably linum-mode as well), the > line-numbers are clipped, so I guess this is a difference between > text-in-the-margin and text-in-the-"main"-area=2E --=20 Enviado desde mi dispositivo Android con K-9 Mail=2E Por favor, disculpa m= i brevedad=2E ------LNAEICTKCG4FMYA2I8VQIJLA3SU58U Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable If you go for this solution then, please tell it h= ere if you push the patch, to check if we don't have the same issue with th= e fill-column-indicator=2E

On May 7, 2019= 9:09:23 PM GMT+02:00, Stefan Monnier <monnier@iro=2Eumontreal=2Eca> = wrote:
If you a re thinking about cl=
ipping characters on display in some way,
Or maybe we could=
 have an option not to put a number on a screen line
that starts with a =
display or overlay string=2E

Not sure what would be the= ideal behavior for compact-docstrings (no
line-number? Truncated line-= number? smaller line-number?), but for
those "text lines turned into th= in graphical lines" as in
describe-symbol, *vc-log*, and friends, I thin= k the better behavior
would be to not display a line number at all=2E
Rather than try and guess it based on the presence of a display/overla= y,
maybe we could require a specific text-property like `no-line-number`= ?


Stefan


BTW: in nlinum-mode (and pre= sumably linum-mode as well), the
line-numbers are clipped, so I gue= ss this is a difference between
text-in-the-margin and text-in-the-= "main"-area=2E



--
Enviado desde= mi dispositivo Android con K-9 Mail=2E Por favor, disculpa mi brevedad=2E<= /body> ------LNAEICTKCG4FMYA2I8VQIJLA3SU58U--