From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59677: 30.0.50; Error when calling (treesit-end-of-defun) Date: Thu, 1 Dec 2022 21:17:44 -0800 Message-ID: References: <87lenuko4o.fsf@kraus.my> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20080"; mail-complaints-to="usenet@ciao.gmane.io" Cc: daniel@kraus.my, 59677@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 06:18:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0yRB-0004zL-0E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 06:18:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0yR2-00063P-Gy; Fri, 02 Dec 2022 00:18:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0yR0-00062s-Gv for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 00:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0yR0-0001SY-96 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 00:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0yR0-0007Yk-4q for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 00:18:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87lenuko4o.fsf@kraus.my> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 05:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59677 X-GNU-PR-Package: emacs Original-Received: via spool by 59677-submit@debbugs.gnu.org id=B59677.166995827729052 (code B ref 59677); Fri, 02 Dec 2022 05:18:02 +0000 Original-Received: (at 59677) by debbugs.gnu.org; 2 Dec 2022 05:17:57 +0000 Original-Received: from localhost ([127.0.0.1]:44152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0yQv-0007YW-BI for submit@debbugs.gnu.org; Fri, 02 Dec 2022 00:17:57 -0500 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:54999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0yQq-0007YQ-0c for 59677@debbugs.gnu.org; Fri, 02 Dec 2022 00:17:56 -0500 Original-Received: by mail-pj1-f51.google.com with SMTP id o12so3893001pjo.4 for <59677@debbugs.gnu.org>; Thu, 01 Dec 2022 21:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=nGDBlIBt994vV04p9418t6Io01MiAszj7+QFuRMvnEQ=; b=Y7KWy5rhWdY3ya3IhJR6CtQOisJMslFtGZVp08WvJHEThuM0xP0ORGVtnw/65QTKTC Jlv7eCGBcr1TN2Uw1lyiDcY0YQ5zyM4Snk8+cWmWD91KKqVCrEVrYrwqYIiNF6JmuG1v nC9BuPVRKDvBbEGCAjPkPwbEZIo96ZDCoj//73VqYOET1VuGRZBCCz/6ymXS+AxPCEBU On7UZMtP215vGuNX+pDXPq/54JU9b90vE7+Jz6cqYYb6ff6slV6oy1XNDYVs3MD7NrHE BbA12Tz+GFLYiKZKtVoV8zxe7qH01OLMCLZ9sr3b+BKqtIfNSetMHspS/9uscgKfh8sB Zy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nGDBlIBt994vV04p9418t6Io01MiAszj7+QFuRMvnEQ=; b=lj+TCCvpYbYV2PG5n/amo1a8smMQqTEf0vilryn7T11HB+56JyjCO53CrAaUPAJmaq mZh/r5FOFcpdF72C1pV9Cn/YxifbkIkP/cNgy9OrpzYEbKNxP3Jbll3ArgOK72hUsha+ 4FPItql1FznOf4sTLjdMGCKGqc0QIWvoe6g6uoyior/eehqtFktGjSMzm3m7FjzMBCSE nfmEbickDOBPXf9ZUgmX4lN9cd2HvV4IMFLMgjQOnjP4N5FK9hGohT/gmRi/XWNk9Pg/ 4z4dlIdkFbwwHbQM02d9mbe1HF3031gs4Y/KxTBuUXkysH+8JGVWsT/ZddhWPL+Czsah xMLQ== X-Gm-Message-State: ANoB5pkhmtLSPI3BETC2hR16US2Vs3yeVpdxwCWMpd/QpO2nu/ixTvPi lC9xvamch/ixeoX28BuTUqsmijnQaQADhg== X-Google-Smtp-Source: AA0mqf6I9z3ppTZWt7XVcQfeBEb+kkgcrrt2aoDCF6VR+tny3ANIDHHjCvwI5w3eNLn+5L0RDrVqsQ== X-Received: by 2002:a17:902:b20f:b0:188:fd02:5462 with SMTP id t15-20020a170902b20f00b00188fd025462mr52423682plr.36.1669958266328; Thu, 01 Dec 2022 21:17:46 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o13-20020a170902d4cd00b001782aab6318sm4594396plg.68.2022.12.01.21.17.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2022 21:17:46 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249701 Archived-At: Daniel Mart=C3=ADn writes: > Daniel Kraus writes: > >> Hi, >> >> I tried the latest -ts-modes and ran into a problem with the >> symbol-overlay ( https://github.com/wolray/symbol-overlay ) >> package. >> >> The problem is that `(end-of-defun)` calls `(treesit-end-of-defun)` >> when in a ...-ts-mode and this function seems to raise an error when >> point is not inside a function. >> >> Steps to reproduce: >> - emacs -Q >> - find-file "foo.py" >> - Then if you run `M-: (end-of-defun)` it works as expected. >> - After switching to `M-x python-ts-mode`, >> the same command raises an error. > > The error is signaled by the goto-char call in treesit-end-of-defun. > Protecting it from possible nil node positions fixes the issue for me > (there is a similar check in treesit-beginning-of-defun): > Thanks, I applied this patch. Tho technically end-of-defun shouldn=E2=80=99= t call end-of-defun-function unless point is on the beginning of a defun. So we should really fix end-of-defun instead. I tried to fix it earlier but that fix didn=E2=80=99t cover all cases where we call = end-of-defun-function. Anyway, I applied the patch and this particular problem should be gone now :-) Yuan