From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix section id on HTML export when no custom id is present
Date: Sun, 19 Apr 2009 22:33:44 +0200 [thread overview]
Message-ID: <ACB0B7F7-C474-4765-84D3-CF059BCAD7DC@gmail.com> (raw)
In-Reply-To: <1240158544-8214-2-git-send-email-bernt@norang.ca>
Yes, a bug, but your fix is not the right one, see the discussions
with Sebastian about the naming of containers and IDs.
Fixed, in a different way.
Thanks.
- Carsten
On Apr 19, 2009, at 6:29 PM, Bernt Hansen wrote:
> This fixes a bug where section ids were all set to 'nil'.
> suffix and href were identical so suffix is no more.
>
> Before this change the table of contents had the correct id but the
> heading levels all had id="nil"
> ---
>
> This patch is available at git://git.norang.ca/org-mode for-carsten
>
> lisp/org-html.el | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index 0f3d113..0c416af 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -1817,7 +1817,7 @@ When TITLE is nil, just close all open levels."
> (preferred (cdr (assoc target org-export-preferred-target-alist)))
> (remove (or preferred target))
> (l org-level-max)
> - snumber href suffix)
> + snumber href)
> (setq extra-targets (remove remove extra-targets))
> (setq extra-targets
> (mapconcat (lambda (x)
> @@ -1874,12 +1874,11 @@ When TITLE is nil, just close all open
> levels."
> level snumber)
> " " title)))
> (unless (= head-count 1) (insert "\n</div>\n"))
> - (setq href (cdr (assoc (concat "sec-" snumber) org-export-
> preferred-target-alist)))
> - (setq suffix (or href (concat "sec-" snumber)))
> + (setq href (or (cdr (assoc (concat "sec-" snumber) org-export-
> preferred-target-alist)) (concat "sec-" snumber)))
> (insert (format "\n<div id=\"outline-container-%s\" class=\"outline-
> %d\">\n<h%d id=\"%s\">%s%s</h%d>\n<div class=\"outline-text-%d\" id=
> \"text-%s\">\n"
> - suffix level level href
> + href level level href
> extra-targets
> - title level level suffix))
> + title level level href))
> (org-open-par)))))
>
> (defun org-export-html-get-tag-class-name (tag)
> --
> 1.6.3.rc1
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2009-04-19 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 16:29 [PATCH] Fix CUSTOM_ID completion for PROPERTY drawers Bernt Hansen
2009-04-19 16:29 ` [PATCH] Fix section id on HTML export when no custom id is present Bernt Hansen
2009-04-19 20:33 ` Carsten Dominik [this message]
2009-04-20 2:16 ` Bernt Hansen
2009-04-19 20:33 ` [PATCH] Fix CUSTOM_ID completion for PROPERTY drawers Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ACB0B7F7-C474-4765-84D3-CF059BCAD7DC@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.