From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#6256: 24.0.50; read-event in `repeat' command Date: Fri, 22 Oct 2010 11:43:32 -0700 Message-ID: References: <058F2FC300154C1AB894694655B2A968@us.oracle.com><90A72397ABF34D84A3ACB3B6DE18F74A@us.oracle.com><0658C0CCC79D466BA9DE233F5980CAE5@us.oracle.com><8E5430CB43B84B91BB47DB3C0C710C44@us.oracle.com><02C729C63ABB48A898C742329EE4ADB0@us.oracle.com><08402D206B354E10BD8F86D4CD5FA9E8@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1287778102 27599 80.91.229.12 (22 Oct 2010 20:08:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 22 Oct 2010 20:08:22 +0000 (UTC) Cc: 6256@debbugs.gnu.org To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 22 22:08:20 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P9NuV-0004la-8C for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Oct 2010 22:08:19 +0200 Original-Received: from localhost ([127.0.0.1]:45159 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9NUU-0002T1-4A for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Oct 2010 15:41:26 -0400 Original-Received: from [140.186.70.92] (port=49557 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9N2m-0005ZV-5t for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 15:12:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9N2k-00087V-RP for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 15:12:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9N2k-00087Q-Pp for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 15:12:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P9MY2-0005lv-8g; Fri, 22 Oct 2010 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Oct 2010 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6256-submit@debbugs.gnu.org id=B6256.128777283522180 (code B ref 6256); Fri, 22 Oct 2010 18:41:02 +0000 Original-Received: (at 6256) by debbugs.gnu.org; 22 Oct 2010 18:40:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9MXb-0005lh-0e for submit@debbugs.gnu.org; Fri, 22 Oct 2010 14:40:35 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9MXY-0005lb-4x for 6256@debbugs.gnu.org; Fri, 22 Oct 2010 14:40:32 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o9MIiOqL018966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Oct 2010 18:44:25 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o9MIASLo006452; Fri, 22 Oct 2010 18:44:23 GMT Original-Received: from abhmt009.oracle.com by acsmt355.oracle.com with ESMTP id 708232961287773011; Fri, 22 Oct 2010 11:43:31 -0700 Original-Received: from dradamslap1 (/10.159.219.235) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 22 Oct 2010 11:43:31 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: ActwvIGPyJF8/eAURkq4UavBPesXRwBVu1Ag X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 22 Oct 2010 14:41:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41078 Archived-At: > >> You could also try > >> (while (let ((evt (read-event))) > >> (message "EVT: %S, R-R-CHAR: %S" evt repeat-repeat-char) > >> (and (equal (event-basic-type evt) > >> (event-basic-type repeat-repeat-char)) > >> (equal (event-modifiers evt) > >> (event-modifiers repeat-repeat-char)))) > >> (repeat repeat-arg)) > > Or adding the suggested `message' calls before/after read-key or > elsewhere to try and see what are the values of repeat-repeat-char at > various places rather than try and guess them. OK, I retested, and I no longer see the problem. In the last few days I've changed some of the code I use, but not in any way that I would expect would make a difference here (i.e., in presumably unrelated areas). So I don't understand it. But the good news is that your code works for me now. If I had to guess, I'd guess that the problem was that I was loading the new code but then when I used the mouse-wheel commands the library they were defined in invoked `(require repeat.el)', and that redefined the function `repeat' as it was originally. That would be my guess. But I could have sworn that I used `C-M-x' several times during testing (e.g. after adding a call to `message'), so I should have at some point tested with the new definition. When I tested before, it systematically did not work. Anyway, it works now. Sorry for not testing correctly the first time. I checked also that it works with modifiers (e.g. C-S-wheel-up). (I assume that you tested that also on GNU.) So I'm OK with your fix. The only disadvantage wrt my fix, for my use (on Windows), is that it will not work for Emacs prior to 23.2, when `read-key' was introduced. (I know you don't care about that.) Thx. What changes will I need to make to my code, if any, after you move to the new implementation that uses `set-temporary-overlay-map'? I think you said none, since I changed the let bindings to setq. Can you confirm or let me know what will need to change?