From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Sun, 9 Oct 2022 17:01:45 -0700 Message-ID: References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel , Alan Mackenzie To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 02:02:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohgFm-0003BK-En for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 02:02:42 +0200 Original-Received: from localhost ([::1]:34788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohgFk-0001G4-5K for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 20:02:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohgEx-0000ZD-Jf for emacs-devel@gnu.org; Sun, 09 Oct 2022 20:01:51 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:33652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohgEv-00052U-RE; Sun, 09 Oct 2022 20:01:51 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id f193so9109091pgc.0; Sun, 09 Oct 2022 17:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0+itMZXG+k7JMVS7GjXRnuAbgGs7JJdlYJQTsfUIruA=; b=nAKuLXVaZIUEiKuch9bidyMlvjl0HZaG/Yyg5c2Iq+BkRQQlGLb3+eZaKUNQ16fFnN 839avAWZKTAO4EEMNgWz22yNtzbcrMR2yzsIZFoYCXo5iO02yUxdMFL7pcVEz3NIHlah Brqnuz/RHRn6x42Jtqw+7dH9yXEwk0EN//jJHzeQTYCR/62OtIHsPVxokCnSovX3GA2O qtNc5wJ4o8GbJqedPjGpXydwZYfhI2PWKF1twzGluVNtAxAfhYUXJEiKutxdzVweWzdG In9nr+oN3xAof1Rl8b0HrP6lSozSbnLGGCKk/jfYom3Qj5lrKzdprS3IAZ82dcdMkEst 3Isg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0+itMZXG+k7JMVS7GjXRnuAbgGs7JJdlYJQTsfUIruA=; b=3rZ4u9HHb2mzLCpETUvbaVP/jB7drIB+skj61tebcPz2kF7VYCG4sJMPVKpcjvn/M/ 9w5+7ix4Vq+h8kq+hXLy1auC4UDsX7kqe/XOTNeGtY7DHnPCfvQAvLPTt5xes+aFIom7 3utIT+AT9kP3Yi3oDYN62l8HCCkwH5h6Wf+LJjqZhBCaiyy2L5oip0DIPFd/2Rts0hUj Rjp8JyuOxYy3pG5GdGpGfNo0LxnGTLXJqQznxS3YPJiwh5/htfaJfsjK06Zp5mxAmhyx E6mKZMlGuQWmyeBmR07YylD6m+q2JOUnykBq+qJ8blAEqokfL5q6qmawxe9wdpEbGZj+ 9kHA== X-Gm-Message-State: ACrzQf3xLwyPaW4a+kq90pusv97rratjLsIIymeTaJeFCmxOyH7mwQBR fOHrRxIi+z9z5YqPGBWU9Go= X-Google-Smtp-Source: AMsMyM4+prdlg/i5hFbBTYymRfmW8RandeHR8jNkWTpYpbDNACV8l+9mlXngLBUW/baEirboPJfbDQ== X-Received: by 2002:aa7:8687:0:b0:560:3299:a6c0 with SMTP id d7-20020aa78687000000b005603299a6c0mr16814451pfo.81.1665360107783; Sun, 09 Oct 2022 17:01:47 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z5-20020a17090a7b8500b001faf7a88138sm4815088pjc.42.2022.10.09.17.01.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Oct 2022 17:01:47 -0700 (PDT) In-Reply-To: <878rlo7on0.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=casouri@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297301 Archived-At: > On Oct 9, 2022, at 1:01 PM, Theodor Thornhill = wrote: >=20 > Eli Zaretskii writes: >=20 >>=20 >> Some of the popular major modes for which we would like to see >> tree-sitter support in Emacs 29 are: >>=20 >> c-mode >> c++-mode >> emacs-lisp-mode >> js-mode >> js-json-mode >> ruby-mode >> shell-script-mode >>=20 >=20 > I'd like to add in Java support here as well. But since java is part = of > cc-mode.el, maybe it'd be best if it got its own mode, say > java-treesitter-mode.el, so that we don't add a dependency into = cc-mode? > If you agree, I can create such a major-mode as well. I think we can use the same major mode, just skip the cc-mode = initialization and only enable tree-sitter stuff if java-use-tree-sitter = is true. But I want to know Alan=E2=80=99s thought on this. I included = him in CC. > Also, how should we mandate what modes get the new tree-sitter = support? > It is pretty fast to add new modes, and adding support for languages = not > already supported in core, such as say, golang, should be very = feasible. > But maybe that is something that should live in elpa? If you want to add tree-sitter support for some built-in mode, go for = it. But I would focus on the modes we already have in core. For modes = like golang where there is a widely used mode out there (in this case on = ELPA), we should either ask to move it into core first, or ask the = author to maybe add tree-sitter support, or submit a patch to him/her, = rather than creating a duplicate go-mode in core just for the sake of = tree-sitter. Yuan=