From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: The unwarranted scrolling assumption Date: Thu, 17 Jun 2010 21:14:04 +0200 Message-ID: References: <87ocfcj7r4.fsf@mail.jurta.org> <87631jvpzg.fsf@gmail.com> <4C18211C.3070106@harpegolden.net> <87vd9j5neu.fsf@kfs-lx.rd.rdm> <83sk4misf2.fsf@gnu.org> <83iq5hiiin.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276802082 27797 80.91.229.12 (17 Jun 2010 19:14:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Jun 2010 19:14:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 17 21:14:40 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OPKXs-00045Z-Ew for ged-emacs-devel@m.gmane.org; Thu, 17 Jun 2010 21:14:36 +0200 Original-Received: from localhost ([127.0.0.1]:55846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPKXr-0007ID-Hr for ged-emacs-devel@m.gmane.org; Thu, 17 Jun 2010 15:14:35 -0400 Original-Received: from [140.186.70.92] (port=55481 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPKXi-0007Ex-I3 for emacs-devel@gnu.org; Thu, 17 Jun 2010 15:14:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPKXh-0005Y7-EV for emacs-devel@gnu.org; Thu, 17 Jun 2010 15:14:26 -0400 Original-Received: from mail-gx0-f169.google.com ([209.85.161.169]:37611) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPKXh-0005Y1-CG; Thu, 17 Jun 2010 15:14:25 -0400 Original-Received: by gxk3 with SMTP id 3so206745gxk.0 for ; Thu, 17 Jun 2010 12:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=zmxUseW9gKE3auPiYCXhvyjGstKQLI3gUF1YaD4prCo=; b=nTdnYFL5g71UBE2JADB8VeCdU7cvUQkbNBjdjhlGV42knhw7CyYpaJyUG6hPcH/ofV zNMZVZXqNHh+0mxbi1AKeWVuLTP9RyN0YT1wMqeWh6kfgjvhZvj9J7OQLYjhZH8/boEa XoZYqyfplgXuGtocoPRH3iroxM5s0+NOvd7kA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=RzXm8RDFYeTr5ony1wxLFe+6r1PEYp4ErihX4RX02v2u0VKr8Am3yQyLK+WRDFzFz4 O+68CqpAOXZHLD3KcDYEMvXq7jm20asqCvka0fCY8fqBjpC06mPa2mopkhES0u6COqRT ymrIQxxiO8xS21qfYVTg7tCCYNH1vaKMfFXSY= Original-Received: by 10.101.145.16 with SMTP id x16mr8951458ann.226.1276802064857; Thu, 17 Jun 2010 12:14:24 -0700 (PDT) Original-Received: by 10.100.154.15 with HTTP; Thu, 17 Jun 2010 12:14:04 -0700 (PDT) In-Reply-To: <83iq5hiiin.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126088 Archived-At: On Thu, Jun 17, 2010 at 9:08 PM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Thu, 17 Jun 2010 20:44:26 +0200 >> Cc: emacs-devel@gnu.org >> >> - The path try_scrolling is not taken. >> - This is because clip_changed is 1. >> - narrow_to_region set it to 1. >> - reconsider_clip_changes gets a chance to reset it to 0, but it does >> not in this case. >> - reconsider_clip_changes does not however set it to 1. >> >> The reason that reconsider_clip_changes does not set clip_changed to 0 i= s that >> >> =C2=A0 =C2=A0!NILP (w->window_end_valid), >> >> which looks like window_end_valid is non-nil. > > Thanks, this is a start, but something is still missing. =C2=A0We have th= is > code at the beginning of reconsider_clip_changes: > > =C2=A0if (b->clip_changed > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && !NILP (w->window_end_valid) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && w->current_matrix->buffer =3D=3D b > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && w->current_matrix->zv =3D=3D BUF_ZV= (b) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 && w->current_matrix->begv =3D=3D BUF_= BEGV (b)) > =C2=A0 =C2=A0b->clip_changed =3D 0; > > So, if b->clip_changed is non-zero at entry to reconsider_clip_changes, > and w->window_end_valid is non-nil, as you say, this code should have > reset b->clip_changed to zero. =C2=A0And yet you say it didn't. =C2=A0Why= not? > what prevented it from doing so? I thought so first too, but please see the message I just sent with an explanation of the patches I sent. There might be some problem in the part above too, but my patches are for another part of the problem. However the first question I gave to you in the message I mention above may be a bit related to what you ask here.