all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Christoph <cschol2112@googlemail.com>
Cc: 6602@debbugs.gnu.org
Subject: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 03:01:15 +0200	[thread overview]
Message-ID: <AANLkTinwg6zjVwBWb-C0Mnw9_z+YQoPaS4F=TLQrLqF5@mail.gmail.com> (raw)
In-Reply-To: <4C4B66D7.8010105@gmail.com>

On Sun, Jul 25, 2010 at 00:19, Christoph <cschol2112@googlemail.com> wrote:

> After testing it in the trunk I remembered: one thing I never was quite sure
> how to fix best is the fact that when you run `make dist' on the trunk, the
> root directory the zip file contains is `trunk' (or whatever you named your
> bzr checkout), but it should be `emacs-VERSION'.

I noticed, but it was always possible to make a branch emacs-VERSION
and build the dist from here.
I suppose this change is for better, but it makes more difficult to
create a dist with a root directory named other than emacs-VERSION
(for my own use, for example, I call them just VERSION, ie., 23.1,
23.2, 24.0.50, etc.). It'd be nice to have a way to customize this,
but don't lose time over it; "unzip & rename dir" is just a command
away :-)

> The main change is that it copies all necessary files to a temporary
> directory and then creates the zip files from that. After that the temporary
> directory is removed.

It is highly unlikely for the user to have a directory
nt/emacs-VERSION, but you overwrite it and then remove it, so it'd be
nice to check and refuse to do anything if it already exists. Another
option would be to write to %TEMP%/%TMP_DIST_DIR% instead of
./%TMP_DIST_DIR%

> There is also a minor bugfix: README.W32 was not copied to the install
> directory when using `make install'.

In fact, there's still a minor issue: README.W32 gets copied to
INSTALL_DIR and not removed. For example, I do all installations
in-place, and after make dist I end with a README.W32 at the root of
my trunk branch. (I've added exclusions to .(bzr|git)ignore, so it's
not much of an issue, but still...).

    Juanma





  reply	other threads:[~2010-07-25  1:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-10 14:00 bug#6602: [PATCH] make dist target for Windows Christoph
2010-07-22  9:19 ` Juanma Barranquero
2010-07-22  9:20   ` Juanma Barranquero
2010-07-22 10:01   ` Juanma Barranquero
2010-07-23  1:14     ` Christoph
2010-07-23  1:22       ` Juanma Barranquero
2010-07-24  3:18         ` Christoph
2010-07-24 13:28           ` Juanma Barranquero
2010-07-24 13:31             ` Juanma Barranquero
2010-07-24 22:19             ` Christoph
2010-07-25  1:01               ` Juanma Barranquero [this message]
2010-07-25  2:04                 ` Christoph
2010-07-25  2:55                   ` Juanma Barranquero
2010-07-25  3:18                     ` Christoph
2010-07-25  3:58                       ` Juanma Barranquero
2010-07-25  4:44                         ` Christoph
2010-07-25 12:30                       ` Sean Sieger
2010-07-25 14:09                         ` Christoph
2010-07-25 17:36                           ` Sean Sieger
2010-07-27 22:25                           ` Sean Sieger
2010-07-27 23:04                             ` Juanma Barranquero
2010-07-27 23:32                               ` Christoph
2010-07-28  1:31                               ` Sean Sieger
2010-07-27 23:25                             ` Christoph
2010-07-28  1:33                               ` Sean Sieger
2010-07-27  1:48                         ` Christoph
2010-07-27 21:08                           ` Sean Sieger
2010-07-27 22:59                             ` Juanma Barranquero
2010-07-28  1:34                               ` Sean Sieger
2010-07-27 23:08                             ` Christoph
2010-07-28  1:38                               ` Sean Sieger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTinwg6zjVwBWb-C0Mnw9_z+YQoPaS4F=TLQrLqF5@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=6602@debbugs.gnu.org \
    --cc=cschol2112@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.