From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fran Litterio Newsgroups: gmane.emacs.bugs Subject: bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and completion-cycle-threshold is nil Date: Thu, 28 Oct 2010 17:40:43 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1288304296 29738 80.91.229.12 (28 Oct 2010 22:18:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Oct 2010 22:18:16 +0000 (UTC) Cc: 7266@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 29 00:18:15 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBan1-0004zw-Qz for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Oct 2010 00:18:14 +0200 Original-Received: from localhost ([127.0.0.1]:41938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBakh-0000ct-QZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Oct 2010 18:15:19 -0400 Original-Received: from [140.186.70.92] (port=40075 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBakV-0000SJ-13 for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2010 18:15:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBaiY-00044Z-OA for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2010 18:13:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBaiY-00044V-LW for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2010 18:13:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PBaP8-0004rZ-J3; Thu, 28 Oct 2010 17:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Fran Litterio Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2010 21:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7266-submit@debbugs.gnu.org id=B7266.128830273618681 (code B ref 7266); Thu, 28 Oct 2010 21:53:02 +0000 Original-Received: (at 7266) by debbugs.gnu.org; 28 Oct 2010 21:52:16 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PBaOM-0004rG-QA for submit@debbugs.gnu.org; Thu, 28 Oct 2010 17:52:15 -0400 Original-Received: from mail-yw0-f44.google.com ([209.85.213.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PBa9W-0004ku-58 for 7266@debbugs.gnu.org; Thu, 28 Oct 2010 17:36:55 -0400 Original-Received: by ywp6 with SMTP id 6so1667511ywp.3 for <7266@debbugs.gnu.org>; Thu, 28 Oct 2010 14:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Umcr6yedMlSKkIhr0FpWUqqM1hJbI1Qg24Kja10c0U4=; b=mDDQgS2JDhcYHHBuFgBuchY6N6kMSXMsEh9PZyKYi2vYHfXR7K+LhJy7dy6a6yZH9N bB5wavVvf8xCnCjxdjp6/EF1+3HkkFWgnU+4BUfFJrxByUVFkZerq8QXhq8XP73BceL1 E4F626HL46NaD2bODQDEhChbn08j9wJxMzDFQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=GSzA0QliWkwdbVAlb9LSUKB0sCw6l2yWiiECZjb9ra9eBKCTaLTvemH2zGaMqGkOBW edM+eiLHxQbM6zZNr5HlnCFmLHky/xWnf8bcBnrGV+VIKa/bt89eQGwHFE8EFex785Ke bajmQ7I/o/+hTO5aH99WQ+h+UIgDdOTm12qd0= Original-Received: by 10.42.41.7 with SMTP id n7mr3771766ice.381.1288302064020; Thu, 28 Oct 2010 14:41:04 -0700 (PDT) Original-Received: by 10.42.176.7 with HTTP; Thu, 28 Oct 2010 14:40:43 -0700 (PDT) In-Reply-To: X-Mailman-Approved-At: Thu, 28 Oct 2010 17:52:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 28 Oct 2010 17:53:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41208 Archived-At: On Wed, Oct 27, 2010 at 10:23 PM, Stefan Monnier wrote: >> 2. Type: ESC ESC : (icomplete-mode 1) RET C-h v mini TAB TAB > >> Notice that minibuffer-complete (which is bound to TAB at this point) >> is cycling through the completion choices instead of popping up a >> window to display the completion choices. > Thanks very much. =A0Indeed, there's a problem here, but... [...] > Hmm... AFAICT if completion-cycle-threshold is nil, then comps will also > be nil, so this change should not make any difference. Oddly, my change _did_ fix the problem for me. > It goes a bit further than that: even if completion-cycle-threshold is > non-nil and completion-all-sorted-completions is set, it may still be > wrong to call minibuffer-force-complete since > completion-all-sorted-completions may only be set because of icomplete > rather than because we're cycling (e.g. the completion list may be > larger than the threshold). > > So I've installed the patch below instead. =A0Please confirm that it fixe= s > the problem. I've verified that your patch does indeed fix the problem. Thanks, Stefan! -- Fran