From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Yair F Newsgroups: gmane.emacs.bugs Subject: bug#6621: Emacs crash when trying to report emacs crash Date: Sun, 25 Jul 2010 01:05:44 +0300 Message-ID: References: <83d3urshi9.fsf@gnu.org> <834og3s1r0.fsf@gnu.org> <83pqyqqx9y.fsf@gnu.org> <83k4oxhk1c.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1280009263 30966 80.91.229.12 (24 Jul 2010 22:07:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Jul 2010 22:07:43 +0000 (UTC) Cc: 6621@debbugs.gnu.org To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 25 00:07:39 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocmsb-0000Ez-Np for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jul 2010 00:07:38 +0200 Original-Received: from localhost ([127.0.0.1]:54403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ocmsb-0005cZ-6z for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 18:07:37 -0400 Original-Received: from [140.186.70.92] (port=46133 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcmsV-0005cT-7X for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 18:07:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcmsT-00051e-Mv for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 18:07:31 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42849) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcmsT-00051X-Jk for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 18:07:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Ocmr4-0001ih-9J; Sat, 24 Jul 2010 18:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yair F Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jul 2010 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6621-submit@debbugs.gnu.org id=B6621.12800091496602 (code B ref 6621); Sat, 24 Jul 2010 22:06:02 +0000 Original-Received: (at 6621) by debbugs.gnu.org; 24 Jul 2010 22:05:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocmqq-0001iQ-Ju for submit@debbugs.gnu.org; Sat, 24 Jul 2010 18:05:49 -0400 Original-Received: from mail-ww0-f42.google.com ([74.125.82.42]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocmqo-0001iJ-6v for 6621@debbugs.gnu.org; Sat, 24 Jul 2010 18:05:46 -0400 Original-Received: by wwf26 with SMTP id 26so1822698wwf.3 for <6621@debbugs.gnu.org>; Sat, 24 Jul 2010 15:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=GzJJPi6vqR3HCFvqP71ApxQZf5NQxR51ZDDB/diyLEc=; b=GwzXVVNrCnB/epx1ztdUrc8pROWzFrp7jpcFW7ebHj1wCj11a2WGPRzdZVeh45jvor 2RD/Vsxm4bDxgfrf4UEgcjTe7/j0p7QeJg7lk9Y+muqwTF3dqkpO4VadDQHT05XsGGwY sKm1PeUB8SxezSxPYJ1jNvtufKJLN5WmtChQg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=fxyFgmVmGhFaUDEG3FZvbobvRY7oJKvTNbKp4mm/xP5fBZshKfxqjbBp9WmH4YI81E /VGXTWLSbu2NNo1manb6YocfcKDUmOKu6ecKEaK5VHrKFKncR2w5jS7ocfdyJjk2fxrr gz1e+1O1CM9ad2uY4nr2zTGbr4bJFrEwkllN8= Original-Received: by 10.216.178.196 with SMTP id f46mr5326239wem.62.1280009144796; Sat, 24 Jul 2010 15:05:44 -0700 (PDT) Original-Received: by 10.216.164.133 with HTTP; Sat, 24 Jul 2010 15:05:44 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 24 Jul 2010 18:06:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38881 Archived-At: I can confirm that this fix resolves the bugs (two forms I found). Thank you, Yair > I found a suspicious code in Ffont_shape_gstring, and the > attached patch will fix the bug. =A0Could you please try it? > I have not yet committed it because I have not yet fully > traced the impact of the change to the other places.. > > =3D=3D=3D modified file 'src/font.c' > --- src/font.c =A02010-07-14 03:40:47 +0000 > +++ src/font.c =A02010-07-23 12:31:43 +0000 > @@ -4492,6 +4492,8 @@ > =A0 =A0 } > =A0 if (i =3D=3D 3 || XINT (n) =3D=3D 0) > =A0 =A0 return Qnil; > + =A0if (XINT (n) < LGSTRING_GLYPH_LEN (gstring)) > + =A0 =A0LGSTRING_SET_GLYPH (gstring, XINT (n), Qnil); > > =A0 glyph =3D LGSTRING_GLYPH (gstring, 0); > =A0 from =3D LGLYPH_FROM (glyph); > > --- > Kenichi Handa > handa@m17n.org >