[PATCH] rcirc.el (rcirc-connect): Make process name configurable.

[PATCH] rcirc.el (rcirc-connect): Make process name configurable.

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

When using rcirc to connect to a proxy that uses several ports on the
same host, one will get confusing results if joining a channel with the
same name on several servers.

If the proxy is running on localhost, one will get buffers (and log
files) named e.g. #emacs@localhost, #emacs@localhost<1> etc.

The attached patch changes (rcirc-connect) so that one can specify what
name the connecting process will have.

Thanks,
Stefan Kangas


[-- Attachment #2: rcirc-configure-process.txt --]
[-- Type: text/plain, Size: 2773 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: skangas@skangas.se-20110114011521-glws2d6ojsa0fyjp
# target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk
# testament_sha1: bae2aee2a7aea3671fed35dae50f3a0c64c34f28
# timestamp: 2011-01-14 02:28:45 +0100
# base_revision_id: monnier@iro.umontreal.ca-20110113231430-\
#   chaw2vxixdrrj3g4
# 
# Begin patch
=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el	2011-01-13 23:14:30 +0000
+++ lisp/net/rcirc.el	2011-01-14 01:15:21 +0000
@@ -471,7 +471,7 @@
 
 ;;;###autoload
 (defun rcirc-connect (server &optional port nick user-name
-                             full-name startup-channels password)
+                             full-name startup-channels password process-name)
   (save-excursion
     (message "Connecting to %s..." server)
     (let* ((inhibit-eol-conversion)
@@ -484,7 +484,9 @@
 	   (user-name (or user-name rcirc-default-user-name))
 	   (full-name (or full-name rcirc-default-full-name))
 	   (startup-channels startup-channels)
-           (process (make-network-process :name server :host server :service port-number)))
+           (process (make-network-process
+                     :name (if process-name process-name server)
+                     :host server :service port-number)))
       ;; set up process
       (set-process-coding-system process 'raw-text 'raw-text)
       (switch-to-buffer (rcirc-generate-new-buffer-name process nil))

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWQ9MrSEAAYj/gACQICBQc//3
UgoIAL////BQA4170b3ncpddde9hJRBpk1MkeDQVPIymm0QekGIYSkajSeVP1NPUyaaEZoCDE0NG
hgaaEE0T1MoeoGmhoPUAaeo0AGSk/SjTTGk00epoHqNAAAABJIEMiYmRop6nqehqPUekeoA0PSe/
MedfTtZJt9H7wT5sNyC/Gqmd8qJs96SaHSO7rj0tYEjP1Tc8zoVRwQVyK7rrNlR7/u3ZLCwrIexi
4wYKOIX2W7T+KaxEl3Mfwt2a3df7NsPQKhTkbA22Fm/Egx/6hxXDhGk7AoE0vIM9VraqU0kmGCni
DnrxYRAIeCgCBIDblmLCw7X9mK4G0DES9QRSrwrhlqiEYKxOAIRrshO3KtCuWQdjSkRZec+kzwxk
qi3XdCGb8sbS5CgtopSis1EGi6G680iUzji8NmJxFgX7z/Bg/INYSJpWUzjgSvvh/AmUKC2DJzwc
KpVa6vHY70SgQkyR6rwya+gU9xHYMpuUPdc1KzHjhtrldRIi0lVODB9RQoj1mmFxqD4U0+EEWpjE
e1wux0C1wZrZILOKpKidFaX3saWjEVYPIYSbLS0Liaus9J840YI0GQ2zXkkFoBZQ+Qjlw2Yqcjz7
X6wO1EdNkx+XUPK19GCrrA4g8TwuM4YGvvtnmYt131EYG1jg9f7SHncldzd7dBLGO9DvJJNiqA8O
52ejVSxv+XBFiNHFN2fQJ8OtXmLKf7InFCazvoiU2a8D5fWEVxFUnPUS5VSHNvO4SwuWh9OfJ4YC
dA66Fw4v5cffOEeZybGoIcswbl2OXlnWrXMpkaFkOIaRvYz+NKLTmmJg+WVeoZRYm2ikVqsHKai7
lYGnf4qagoVriv3z5vYn6N7BfYIpLUj4CnkZgyKygZGOe5qT7pnA7/rLAUr2hF1lKyCQnUJBuzeg
OWsP0T1EerIiW42hoFbwcEAe4N3gxnLzxaVXUWy5RqSzmb17AQAgogrgNdqALwA1ROecnhFERogO
xA+kvQ4JOUnLjqB6ZLsLSIdHGIETkFCxdB67XegYathhixiY0mpme7synCrBX4MQOeGuAn5SYyFP
aE0P4XFvt0CsLQxFOLuYRqajk5bB7cWTkt4mJs3gVsbyZmhA5JWgJUTQKAjM8hnhjJbPBJCQ1iZ5
82Ns66xwztfgW0RhEeEAFYl9sbUwXDrQpfr3pOpqYdgvDkq7MRXK8OgWKavFOJD1F3JFOFCQD0yt
IQ==

Re: [PATCH] rcirc.el (rcirc-connect): Make process name configurable.

[Deniz Dogan]

2011/1/14 Stefan Kangas <skangas@skangas.se>:
> When using rcirc to connect to a proxy that uses several ports on the
> same host, one will get confusing results if joining a channel with the
> same name on several servers.
>
> If the proxy is running on localhost, one will get buffers (and log
> files) named e.g. #emacs@localhost, #emacs@localhost<1> etc.
>
> The attached patch changes (rcirc-connect) so that one can specify what
> name the connecting process will have.
>
> Thanks,
> Stefan Kangas
>
>
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: skangas@skangas.se-20110114011521-glws2d6ojsa0fyjp
> # target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk
> # testament_sha1: bae2aee2a7aea3671fed35dae50f3a0c64c34f28
> # timestamp: 2011-01-14 02:28:45 +0100
> # base_revision_id: monnier@iro.umontreal.ca-20110113231430-\
> #   chaw2vxixdrrj3g4
> #
> # Begin patch
> === modified file 'lisp/net/rcirc.el'
> --- lisp/net/rcirc.el   2011-01-13 23:14:30 +0000
> +++ lisp/net/rcirc.el   2011-01-14 01:15:21 +0000
> @@ -471,7 +471,7 @@
>
>  ;;;###autoload
>  (defun rcirc-connect (server &optional port nick user-name
> -                             full-name startup-channels password)
> +                             full-name startup-channels password process-name)
>   (save-excursion
>     (message "Connecting to %s..." server)
>     (let* ((inhibit-eol-conversion)
> @@ -484,7 +484,9 @@
>           (user-name (or user-name rcirc-default-user-name))
>           (full-name (or full-name rcirc-default-full-name))
>           (startup-channels startup-channels)
> -           (process (make-network-process :name server :host server :service port-number)))
> +           (process (make-network-process
> +                     :name (if process-name process-name server)
> +                     :host server :service port-number)))
>       ;; set up process
>       (set-process-coding-system process 'raw-text 'raw-text)
>       (switch-to-buffer (rcirc-generate-new-buffer-name process nil))
>
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWQ9MrSEAAYj/gACQICBQc//3
> UgoIAL////BQA4170b3ncpddde9hJRBpk1MkeDQVPIymm0QekGIYSkajSeVP1NPUyaaEZoCDE0NG
> hgaaEE0T1MoeoGmhoPUAaeo0AGSk/SjTTGk00epoHqNAAAABJIEMiYmRop6nqehqPUekeoA0PSe/
> MedfTtZJt9H7wT5sNyC/Gqmd8qJs96SaHSO7rj0tYEjP1Tc8zoVRwQVyK7rrNlR7/u3ZLCwrIexi
> 4wYKOIX2W7T+KaxEl3Mfwt2a3df7NsPQKhTkbA22Fm/Egx/6hxXDhGk7AoE0vIM9VraqU0kmGCni
> DnrxYRAIeCgCBIDblmLCw7X9mK4G0DES9QRSrwrhlqiEYKxOAIRrshO3KtCuWQdjSkRZec+kzwxk
> qi3XdCGb8sbS5CgtopSis1EGi6G680iUzji8NmJxFgX7z/Bg/INYSJpWUzjgSvvh/AmUKC2DJzwc
> KpVa6vHY70SgQkyR6rwya+gU9xHYMpuUPdc1KzHjhtrldRIi0lVODB9RQoj1mmFxqD4U0+EEWpjE
> e1wux0C1wZrZILOKpKidFaX3saWjEVYPIYSbLS0Liaus9J840YI0GQ2zXkkFoBZQ+Qjlw2Yqcjz7
> X6wO1EdNkx+XUPK19GCrrA4g8TwuM4YGvvtnmYt131EYG1jg9f7SHncldzd7dBLGO9DvJJNiqA8O
> 52ejVSxv+XBFiNHFN2fQJ8OtXmLKf7InFCazvoiU2a8D5fWEVxFUnPUS5VSHNvO4SwuWh9OfJ4YC
> dA66Fw4v5cffOEeZybGoIcswbl2OXlnWrXMpkaFkOIaRvYz+NKLTmmJg+WVeoZRYm2ikVqsHKai7
> lYGnf4qagoVriv3z5vYn6N7BfYIpLUj4CnkZgyKygZGOe5qT7pnA7/rLAUr2hF1lKyCQnUJBuzeg
> OWsP0T1EerIiW42hoFbwcEAe4N3gxnLzxaVXUWy5RqSzmb17AQAgogrgNdqALwA1ROecnhFERogO
> xA+kvQ4JOUnLjqB6ZLsLSIdHGIETkFCxdB67XegYathhixiY0mpme7synCrBX4MQOeGuAn5SYyFP
> aE0P4XFvt0CsLQxFOLuYRqajk5bB7cWTkt4mJs3gVsbyZmhA5JWgJUTQKAjM8hnhjJbPBJCQ1iZ5
> 82Ns66xwztfgW0RhEeEAFYl9sbUwXDrQpfr3pOpqYdgvDkq7MRXK8OgWKavFOJD1F3JFOFCQD0yt
> IQ==
>
>

Thanks for the patch!

However, I'm a bit reluctant to introducing new parameters such as
process-name to such a central function. Since process-name is
essentially used as an argument to make-network-process, maybe it
would be better if we replace the process-name parameter by a plist
which is passed to make-network-process containing :name.

What do you think?

-- 
Deniz Dogan

Re: [PATCH] rcirc.el (rcirc-connect): Make process name configurable.

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Deniz Dogan <deniz.a.m.dogan@gmail.com> writes:

>                                          Since process-name is
> essentially used as an argument to make-network-process, maybe it
> would be better if we replace the process-name parameter by a plist
> which is passed to make-network-process containing :name.

How about the attached patch?

Regards,
Stefan Kangas


[-- Attachment #2: rcirc-configure-process-v2.txt --]
[-- Type: text/plain, Size: 3002 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: skangas@skangas.se-20110116000355-aavl1epdl3fvv9su
# target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk
# testament_sha1: 54e6a9181465f0576d5ab92676c4d626dcd69f0f
# timestamp: 2011-01-16 01:10:22 +0100
# base_revision_id: rgm@gnu.org-20110115232357-ja3ha94kwuroxwso
# 
# Begin patch
=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el	2011-01-15 23:16:57 +0000
+++ lisp/net/rcirc.el	2011-01-16 00:03:55 +0000
@@ -472,9 +472,11 @@
 
 ;;;###autoload
 (defun rcirc-connect (server &optional port nick user-name
-                             full-name startup-channels password)
+                             full-name startup-channels password process-plist)
   (save-excursion
     (message "Connecting to %s..." server)
+    (when (not (plist-get process-plist :name))
+      (setq (plist-put process-plist :name server)))
     (let* ((inhibit-eol-conversion)
            (port-number (if port
 			    (if (stringp port)
@@ -485,7 +487,8 @@
 	   (user-name (or user-name rcirc-default-user-name))
 	   (full-name (or full-name rcirc-default-full-name))
 	   (startup-channels startup-channels)
-           (process (make-network-process :name server :host server :service port-number)))
+           (process (apply 'make-network-process :host server
+                           :service port-number process-plist)))
       ;; set up process
       (set-process-coding-system process 'raw-text 'raw-text)
       (switch-to-buffer (rcirc-generate-new-buffer-name process nil))

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWRBHxhoAAbH/gFCQAKBQ8//3
UgkIAL////BQA/p73erRzzW167263DJBNNFPBDTaTFPRPQmmQ0ANAGUEaYTBCanpDQ0GgAAADJMS
ZKY2pPU8hPKaA0AA0aABtSTTUwyp6aNRp6JtQeoA9QANACSIU9AmqexU21J6ntU8ieZU9QAZM0gi
aYjIfW35GHCrpukWbRmBF76sWnHGLfFVCAFI/Wfd06fN3OZAiGL3LmR1qYNrFhEUgrTPNGEfu/F+
v1m9t+a9HOlETWhbERQhq01VYZuRUhFwOSZZT7DGgopYLJVTj4BqSibhenC+jezqmg848VDcGRGv
KL9tgWhEDb6qI2U138dA5MJzYhEHjmBPSMG+FgoBNOeD+nUoCmJtFQZcftMprCHQnNEkYquAps3i
RIyMCQzyWvAeYYZYHRqyRKzwxwy49Rk0QH0Mbwax1FF0BEEqOIUuaAaXKpdfMWa87b7ARyDVcwzV
iBgeCc1clDbGao5jCREa4gxOvepgjUKTLyxoDLCzUBigqumjQWH+zK4IW3wupSmnDSxOSVN8O0lk
OpqCoavbwvrWmw2wcNGaxQU5ZMhpkBiFXLzYkIaEuRchInMiIedrXtS+Sl/eUrRMLku90Yh43rbC
xxbg5bTRixKC0XOC1/oO5IdAodfKiOCx6goMUUKtY8BfjcEhwDmI8A/LB9Utm2/wjmHQB6mTHk9Z
xshWwT4RNo4bNv9XDIgSUi85Zix16Uj1W9A7DpeF+qXXQAu8rNaMSn6oDnGcxA8NKsbNGwOv3nEH
QC7c8SQ8e8nUvCiQFzJmtDU6r8BuGt8piMoVjEGmA5RutADaZjxdYaCdYRnJwbJZhku59BxJewCe
3OuVaNO/nedmKOKbu8DY61E/ZItplUchSk0grvTZbRbYhwECZRbOGoJgPt5i4CF1VYUBhWu4OWxd
cs+VznPzawWASQHvROAegMduLME09HVrEMxhdwovh+lGLNggoqFdwEOzKSqgNBkB0k8K0xOltRpA
GJeH4XYFLBWL1imEYhuWHcKrS5tU5W5d4H5JjKZ/kgL8ov53YcVkWcB9KZ2cCqKbdsg8SAIcJwy4
qwU2DAKIKh1cBin3yDR5HcFXzBilbhh456trzCiGMLUQosVgtfoA0ihyWSsaGgSKpoPPwmkYUUsr
0R2cTNKDUCbCxPSmSequd6zsaAte7QPg03TpsCDd7BRAAZ470otXYNs2va1t4N8AMDAI46rDs4zP
LQAUUWoArTA8QUtjVAXVQwQcqwXXBdJy5khv9dae2euu0pCpWMRZbHgRC5SB725EMy18DDFGRmKy
tKxHrFE3JiRkuAzmRdQMb8jd127rdQf/i7kinChICCPjDQA=