From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] rcirc.el (rcirc-connect): Make process name configurable. Date: Sat, 15 Jan 2011 12:14:39 +0100 Message-ID: References: <87aaj3ny3i.fsf@skangas.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1295090151 5562 80.91.229.12 (15 Jan 2011 11:15:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 15 Jan 2011 11:15:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Kangas , Ryan Yeske Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 15 12:15:47 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pe46k-0005kI-MX for ged-emacs-devel@m.gmane.org; Sat, 15 Jan 2011 12:15:47 +0100 Original-Received: from localhost ([127.0.0.1]:55369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pe46j-0008OU-Nk for ged-emacs-devel@m.gmane.org; Sat, 15 Jan 2011 06:15:45 -0500 Original-Received: from [140.186.70.92] (port=55267 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pe46M-0008JR-6b for emacs-devel@gnu.org; Sat, 15 Jan 2011 06:15:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pe46B-0001CL-4v for emacs-devel@gnu.org; Sat, 15 Jan 2011 06:15:21 -0500 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:42256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pe46A-0001Bz-VO for emacs-devel@gnu.org; Sat, 15 Jan 2011 06:15:11 -0500 Original-Received: by iwn40 with SMTP id 40so3654695iwn.0 for ; Sat, 15 Jan 2011 03:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=Y1C4Ao+k3aZjaDwoYQw4mw9SAiEmz42Ev3kcx2h1jMw=; b=dJgKQBAwmpad3yY67t7h8K8/5/FQ22mNIwSRggXgQnhzixkZrVFHVs+a/bPTlGyUpW MtjxOZl40aOklO0pvVmRel8oikTDKXFHD7M2kq5vlYPDAVK+8cEpoEzNVvsHZvlgpMNc 0PRWnhaTQAtbx7UaEH425ozj54Nwg/Asidj5A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=A7O6wx58veRhJ49FDS5Gn8ZMkFBapiFQlbC6nkvwOhk9iHSVYxLm+wUD0qJ7ThCz9D mUFpDa6nmusLONW7iuMn4knGUUDA3g8G/9VQu3gVbgpRNN4O+xVGQqFkhJX4yy8LK9Vc dNRHcDL914XBvrFnd5KD95NSAzrzNlwoJnEzE= Original-Received: by 10.231.145.68 with SMTP id c4mr1852685ibv.47.1295090109764; Sat, 15 Jan 2011 03:15:09 -0800 (PST) Original-Received: by 10.231.32.197 with HTTP; Sat, 15 Jan 2011 03:14:39 -0800 (PST) In-Reply-To: <87aaj3ny3i.fsf@skangas.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134570 Archived-At: 2011/1/14 Stefan Kangas : > When using rcirc to connect to a proxy that uses several ports on the > same host, one will get confusing results if joining a channel with the > same name on several servers. > > If the proxy is running on localhost, one will get buffers (and log > files) named e.g. #emacs@localhost, #emacs@localhost<1> etc. > > The attached patch changes (rcirc-connect) so that one can specify what > name the connecting process will have. > > Thanks, > Stefan Kangas > > > # Bazaar merge directive format 2 (Bazaar 0.90) > # revision_id: skangas@skangas.se-20110114011521-glws2d6ojsa0fyjp > # target_branch: http://bzr.savannah.gnu.org/r/emacs/trunk > # testament_sha1: bae2aee2a7aea3671fed35dae50f3a0c64c34f28 > # timestamp: 2011-01-14 02:28:45 +0100 > # base_revision_id: monnier@iro.umontreal.ca-20110113231430-\ > # =A0 chaw2vxixdrrj3g4 > # > # Begin patch > =3D=3D=3D modified file 'lisp/net/rcirc.el' > --- lisp/net/rcirc.el =A0 2011-01-13 23:14:30 +0000 > +++ lisp/net/rcirc.el =A0 2011-01-14 01:15:21 +0000 > @@ -471,7 +471,7 @@ > > =A0;;;###autoload > =A0(defun rcirc-connect (server &optional port nick user-name > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 full-name start= up-channels password) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 full-name start= up-channels password process-name) > =A0 (save-excursion > =A0 =A0 (message "Connecting to %s..." server) > =A0 =A0 (let* ((inhibit-eol-conversion) > @@ -484,7 +484,9 @@ > =A0 =A0 =A0 =A0 =A0 (user-name (or user-name rcirc-default-user-name)) > =A0 =A0 =A0 =A0 =A0 (full-name (or full-name rcirc-default-full-name)) > =A0 =A0 =A0 =A0 =A0 (startup-channels startup-channels) > - =A0 =A0 =A0 =A0 =A0 (process (make-network-process :name server :host s= erver :service port-number))) > + =A0 =A0 =A0 =A0 =A0 (process (make-network-process > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 :name (if process-name process-= name server) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 :host server :service port-numb= er))) > =A0 =A0 =A0 ;; set up process > =A0 =A0 =A0 (set-process-coding-system process 'raw-text 'raw-text) > =A0 =A0 =A0 (switch-to-buffer (rcirc-generate-new-buffer-name process nil= )) > > # Begin bundle > IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWQ9MrSEAAYj/gACQICBQc= //3 > UgoIAL////BQA4170b3ncpddde9hJRBpk1MkeDQVPIymm0QekGIYSkajSeVP1NPUyaaEZoCDE= 0NG > hgaaEE0T1MoeoGmhoPUAaeo0AGSk/SjTTGk00epoHqNAAAABJIEMiYmRop6nqehqPUekeoA0P= Se/ > MedfTtZJt9H7wT5sNyC/Gqmd8qJs96SaHSO7rj0tYEjP1Tc8zoVRwQVyK7rrNlR7/u3ZLCwrI= exi > 4wYKOIX2W7T+KaxEl3Mfwt2a3df7NsPQKhTkbA22Fm/Egx/6hxXDhGk7AoE0vIM9VraqU0kmG= Cni > DnrxYRAIeCgCBIDblmLCw7X9mK4G0DES9QRSrwrhlqiEYKxOAIRrshO3KtCuWQdjSkRZec+kz= wxk > qi3XdCGb8sbS5CgtopSis1EGi6G680iUzji8NmJxFgX7z/Bg/INYSJpWUzjgSvvh/AmUKC2DJ= zwc > KpVa6vHY70SgQkyR6rwya+gU9xHYMpuUPdc1KzHjhtrldRIi0lVODB9RQoj1mmFxqD4U0+EEW= pjE > e1wux0C1wZrZILOKpKidFaX3saWjEVYPIYSbLS0Liaus9J840YI0GQ2zXkkFoBZQ+Qjlw2Yqc= jz7 > X6wO1EdNkx+XUPK19GCrrA4g8TwuM4YGvvtnmYt131EYG1jg9f7SHncldzd7dBLGO9DvJJNiq= A8O > 52ejVSxv+XBFiNHFN2fQJ8OtXmLKf7InFCazvoiU2a8D5fWEVxFUnPUS5VSHNvO4SwuWh9OfJ= 4YC > dA66Fw4v5cffOEeZybGoIcswbl2OXlnWrXMpkaFkOIaRvYz+NKLTmmJg+WVeoZRYm2ikVqsHK= ai7 > lYGnf4qagoVriv3z5vYn6N7BfYIpLUj4CnkZgyKygZGOe5qT7pnA7/rLAUr2hF1lKyCQnUJBu= zeg > OWsP0T1EerIiW42hoFbwcEAe4N3gxnLzxaVXUWy5RqSzmb17AQAgogrgNdqALwA1ROecnhFER= ogO > xA+kvQ4JOUnLjqB6ZLsLSIdHGIETkFCxdB67XegYathhixiY0mpme7synCrBX4MQOeGuAn5SY= yFP > aE0P4XFvt0CsLQxFOLuYRqajk5bB7cWTkt4mJs3gVsbyZmhA5JWgJUTQKAjM8hnhjJbPBJCQ1= iZ5 > 82Ns66xwztfgW0RhEeEAFYl9sbUwXDrQpfr3pOpqYdgvDkq7MRXK8OgWKavFOJD1F3JFOFCQD= 0yt > IQ=3D=3D > > Thanks for the patch! However, I'm a bit reluctant to introducing new parameters such as process-name to such a central function. Since process-name is essentially used as an argument to make-network-process, maybe it would be better if we replace the process-name parameter by a plist which is passed to make-network-process containing :name. What do you think? --=20 Deniz Dogan