all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 7822@debbugs.gnu.org
Subject: bug#7822: 24.0.50; `fit-window-to-buffer': take display artefacts into account
Date: Wed, 12 Jan 2011 12:33:28 +0100	[thread overview]
Message-ID: <AANLkTinf4F3THNjvx-KooeWKWsmQ9PUFU772WkRwrXOj@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=Jfu5i_Z9ME+8q81qVunn7mn0QBEjVdLW-KdYg@mail.gmail.com>

On Wed, Jan 12, 2011 at 11:40 AM, Lennart Borgman
<lennart.borgman@gmail.com> wrote:
> On Wed, Jan 12, 2011 at 4:16 AM, Drew Adams <drew.adams@oracle.com> wrote:
>>> Try first to adjust window below and if that is not enough window
>>> above.
>>
>> I looked only at the doc string.  Whatever we do for `fit-window-to-buffer', it
>> should _not_ take any other windows into account or have any effect on any other
>> windows.  This is only about fitting a window to its buffer as displayed.
>> Whatever effects that might have on other windows are derivative, and not to be
>> taken into account in this function.
>>
>> It sounds like you are doing something different from what this bug is about.
>
> Not really, but your answer makes me realize that my solution above is
> not enough.
>
> And I actually have a better solution in winsize.el, but it is quite a
> bit more elaborate and probably not what we want.

To be more clear: I was taking into account to few windows. All
windows below and above must be taken into account.

And I somehow forgot to implement this in resize-windows (which is in
winsize.el). It is a little bit complicated so I can't do it that
quickly.

> Instead I believe we want a variant of enlarge-window that is not
> allowed to delete-windows. Building on that we can make a more simple
> solution.

Perhaps that is wrong. That would only mean pushing the logic above to
the C level.





  reply	other threads:[~2011-01-12 11:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11  0:21 bug#7822: 24.0.50; `fit-window-to-buffer': take display artefacts into account Drew Adams
2011-01-11  4:40 ` Lennart Borgman
2011-01-12  2:14   ` Lennart Borgman
2011-01-12  3:16     ` Drew Adams
2011-01-12 10:40       ` Lennart Borgman
2011-01-12 11:33         ` Lennart Borgman [this message]
2011-01-12 15:11           ` Drew Adams
2011-01-12 17:55             ` Lennart Borgman
2011-01-12 18:24               ` Drew Adams
  -- strict thread matches above, loose matches on Subject: below --
2008-11-14 22:46 bug#1348: set-frame-width and set-frame-position seem buggy on at least MSWindows Themba Fletcher
2014-09-21 18:02 ` martin rudalics
2014-09-22  9:02   ` bug#7822: 24.0.50; `fit-window-to-buffer': take display artefacts into account martin rudalics
2014-09-22 14:02     ` Drew Adams
2014-09-22 17:42       ` martin rudalics
2014-09-22 18:24         ` Drew Adams
2014-09-22 19:31           ` Stefan Monnier
2014-09-22 20:24             ` Drew Adams
2014-09-22 20:54               ` Stefan Monnier
2014-09-22 21:04                 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinf4F3THNjvx-KooeWKWsmQ9PUFU772WkRwrXOj@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=7822@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.