From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Sun, 25 Jul 2010 19:30:48 +0200 Message-ID: References: <86iq4379w0.fsf@red.stonehenge.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1280079083 1120 80.91.229.12 (25 Jul 2010 17:31:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2010 17:31:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Randal L. Schwartz" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 19:31:21 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Od52m-0002Ep-JJ for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 19:31:20 +0200 Original-Received: from localhost ([127.0.0.1]:45652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od52l-0004iX-Ph for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 13:31:19 -0400 Original-Received: from [140.186.70.92] (port=60642 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od52e-0004i6-R2 for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:31:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Od52b-0003UC-U2 for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:31:12 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:33763) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od52b-0003TO-PX for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:31:09 -0400 Original-Received: by bwz9 with SMTP id 9so2948576bwz.0 for ; Sun, 25 Jul 2010 10:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=nz1vKV3w58NYNoxHIH/yikUTejUpig45gcPoazfpHDY=; b=ZGYbN6xH6sLyxJmiaVpNDFkYUS2K45FwvTRkksW13Go03DudPYh8z6x9bQNNweDQ9/ dCkJJ0c406Kr9AUqBNfL3di+bSd1HAfGdxA1FEwQNs592WgZ/0C+WAgHL9bsE0q0AcJE 8D+n972v0lWWU2L+ttQGGusM2+EK5RGXoc0+Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=fLl9UPbaVUPkv4cuT3HFhTfTLumdgQc68Ly9tGdyeOPeP28W82Ab9BWV1s12uzKJ7U 8JYJKMw3qqa9veFixXEu24xC+JsR1fczL/eDiBgd1o9k+9AdxJym/Cru4I1o6XVFhCNn vTNyY5PHPodBmdOYZ61+6u4VQ+wSUGqMkiqt8= Original-Received: by 10.204.178.146 with SMTP id bm18mr4485436bkb.99.1280079068114; Sun, 25 Jul 2010 10:31:08 -0700 (PDT) Original-Received: by 10.204.180.136 with HTTP; Sun, 25 Jul 2010 10:30:48 -0700 (PDT) In-Reply-To: <86iq4379w0.fsf@red.stonehenge.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127775 Archived-At: On Sun, Jul 25, 2010 at 19:23, Randal L. Schwartz w= rote: > =C2=A0 =C2=A0-extern DIR *opendir (); > =C2=A0 =C2=A0-extern struct direct *readdir (); > =C2=A0 =C2=A0+extern DIR *opendir (char *); > =C2=A0 =C2=A0+extern struct direct *readdir (DIR *); > Needs to be backed out, or made more portable. Sure. I'd prefer to make it more portable (that already compiles on Windows / MinGW and Ubuntu / GCC). What is the right prototype in your system? (You didn't attach the error output, BTW). Could you send a patch with the relevant #ifdef? =C2=A0 =C2=A0 Juanma