From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: The unwarranted scrolling assumption Date: Fri, 18 Jun 2010 17:36:45 +0200 Message-ID: References: <87631jvpzg.fsf@gmail.com> <4C18211C.3070106@harpegolden.net> <87vd9j5neu.fsf@kfs-lx.rd.rdm> <83sk4misf2.fsf@gnu.org> <83iq5hiiin.fsf@gnu.org> <83fx0lihov.fsf@gnu.org> <83aaqsiyb6.fsf@gnu.org> <83zkysh2hb.fsf@gnu.org> <83vd9gh0s6.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1276875517 32287 80.91.229.12 (18 Jun 2010 15:38:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Jun 2010 15:38:37 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 18 17:38:34 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OPdeM-0006lL-6K for ged-emacs-devel@m.gmane.org; Fri, 18 Jun 2010 17:38:34 +0200 Original-Received: from localhost ([127.0.0.1]:36073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPdeL-00050f-IN for ged-emacs-devel@m.gmane.org; Fri, 18 Jun 2010 11:38:33 -0400 Original-Received: from [140.186.70.92] (port=58554 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPdcy-0003En-EP for emacs-devel@gnu.org; Fri, 18 Jun 2010 11:37:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPdcx-00044C-Bh for emacs-devel@gnu.org; Fri, 18 Jun 2010 11:37:08 -0400 Original-Received: from mail-gw0-f41.google.com ([74.125.83.41]:49054) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPdcx-000446-6Z; Fri, 18 Jun 2010 11:37:07 -0400 Original-Received: by gwj23 with SMTP id 23so912813gwj.0 for ; Fri, 18 Jun 2010 08:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=LZlscM0gUDsQlDb7sWebVW3+npJ5nGuLHKL4wCeu+XE=; b=mNSZKTvz77IUBLvRtxj7+n7AukHl22PLgVfMlCFfp53HBuXsiW40DSwdeZ6p3qbdLl pz5/HSqmsCXD6LKMo9htQ91z1IAqPRzFi7PB5XJ5mXbGNcNgXMPEfHBd9lLHo0MnY23T sNhqGNOHCf4amSmefR0GJhXAePPA3yp8rusek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=wsASifcczA7A0yYDp8CCdmFbCIDTkWdwajysh6yCv3GtaUd2VHpXNaYv43J1H8DwrM EPzX+SMn14QYMMe1Mr5Q6MRhs2fquHHeiy3QZJbv8mghKZ7kgGgU2AMpngwNld57gajn S/IDrWSepLB2mn5iNKzUf11+7DncMIx0eO8bM= Original-Received: by 10.100.246.13 with SMTP id t13mr989352anh.183.1276875426406; Fri, 18 Jun 2010 08:37:06 -0700 (PDT) Original-Received: by 10.100.154.15 with HTTP; Fri, 18 Jun 2010 08:36:45 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126181 Archived-At: On Fri, Jun 18, 2010 at 5:29 PM, Lennart Borgman wrote: > > My patch fixes this by letting redisplay have the whole responsibility > for clip_changed. There are of course other ways to do it, but from a > logic point that seems the best and I think it gives much cleaner > code. A little bit more explicit: If I am not misreading/misremember the code currently this will lead to a redisplay in some cases: (save-excursion (widen)) Why would redisplay have to investigate cases like that?