From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: shawn boles Newsgroups: gmane.emacs.bugs Subject: bug#6957: url-cookie-expired-p Redux Date: Tue, 31 Aug 2010 15:51:38 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0015174c1a887dcac0048f266cd2 X-Trace: dough.gmane.org 1283296222 30266 80.91.229.12 (31 Aug 2010 23:10:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Aug 2010 23:10:22 +0000 (UTC) To: 6957@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 01 01:10:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OqZy7-0006he-4V for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Sep 2010 01:10:19 +0200 Original-Received: from localhost ([127.0.0.1]:46997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqZy6-0005Rk-FH for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Aug 2010 19:10:18 -0400 Original-Received: from [140.186.70.92] (port=37658 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqZxY-0005AG-MH for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2010 19:09:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqZxX-0001fU-MY for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2010 19:09:44 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35374) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqZxX-0001fP-IC for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2010 19:09:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OqZgP-0004Ap-SW; Tue, 31 Aug 2010 18:52:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: shawn boles Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Aug 2010 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6957-submit@debbugs.gnu.org id=B6957.128329507916035 (code B ref 6957); Tue, 31 Aug 2010 22:52:01 +0000 Original-Received: (at 6957) by debbugs.gnu.org; 31 Aug 2010 22:51:19 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqZfj-0004Aa-1v for submit@debbugs.gnu.org; Tue, 31 Aug 2010 18:51:19 -0400 Original-Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqZeS-00049Z-2F for 6957@debbugs.gnu.org; Tue, 31 Aug 2010 18:50:00 -0400 Original-Received: by eyd10 with SMTP id 10so3805685eyd.3 for <6957@debbugs.gnu.org>; Tue, 31 Aug 2010 15:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=m9ZiFZ7rJScBj/m+3rhWsjw1uyMSlU34VJPRc6UzqNk=; b=iG7SkJhV+wN3WVAPAe6nOpPFPQuYTOHKwxt5Xt5X8lZVrNXR36oPxMNGHq3yAdRL9K in/hE7xvMlcJE8uEhbBavWu0hDN8DOOyxtrLdCu9U5BDPh0bG79tAfbQn79E8oT+j5HA gDneipPQjM5P8vNd8AneGUqUaojYsbBPDSIpY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=l/UMGGM9guAE2389TPNBMCokn1yHClt5SvgZyQnTaGGdxv/JeHh1r1qzuDsuBSyfcu 8RPjBO16gyPRnqR2snkN9M7U/eGPLBLJloBJsaoIm6atmQsLd6F51iMQ/359hQQ40B9R spPIHeTh1bJNF5XCL+GnQezculikuMKgEHW+s= Original-Received: by 10.213.9.195 with SMTP id m3mr10606409ebm.83.1283295098554; Tue, 31 Aug 2010 15:51:38 -0700 (PDT) Original-Received: by 10.14.124.71 with HTTP; Tue, 31 Aug 2010 15:51:38 -0700 (PDT) X-Mailman-Approved-At: Tue, 31 Aug 2010 18:51:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 31 Aug 2010 18:52:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39873 Archived-At: --0015174c1a887dcac0048f266cd2 Content-Type: text/plain; charset=ISO-8859-1 So this is buggier than I thought. First, the hour normalization is still incorrect: there are 3600 seconds in an hour, not 360. Second, the cookie expiration time is GMT, per the cookie spec. As is, url-cookie-expired-p compares current time (no GMT adjustment) with a GMT expiration time. Please see the attached patch. I fixed the hour normalization. I added a function called url-cookie-gmt-time-string that returns the current time adjusted to GMT. Please check this function. While I believe my implementation is correct, there may be a better way to adjust a time to GMT in Emacs. I updated url-cookie-expire-p so that it compares local time as GMT with the expiration time, also as GMT. Thanks! shawn --0015174c1a887dcac0048f266cd2 Content-Type: application/octet-stream; name="url-cookie.el.patch" Content-Disposition: attachment; filename="url-cookie.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gdjco7r30 LS0tIC9jeWdkcml2ZS9jL3NyYy9FbWFjcy9lbWFjcy0yMy4yL2VtYWNzLTIzLjIvbGlzcC91cmwv dXJsLWNvb2tpZS5lbAkyMDEwLTA4LTMxIDEwOjUzOjA4Ljg2MDA5MTkwMCAtMDcwMAorKysgdXJs LWNvb2tpZS5lbAkyMDEwLTA4LTMxIDE1OjM4OjU1LjA2MjQ5MjcwMCAtMDcwMApAQCAtMTkzLDYg KzE5MywxMiBAQAogICAgICAgICh0CiAJKHNldHEgdXJsLWNvb2tpZS1zdG9yYWdlIChsaXN0IChs aXN0IGRvbWFpbiB0bXApKSkpKSkpKQogCisoZGVmdW4gdXJsLWNvb2tpZS1nbXQtdGltZS1zdHJp bmcgKCkKKwkiUmV0dXJucyB0aGUgY3VycmVudCB0aW1lLCBhZGp1c3RlZCB0byBHTVQsIGFzIGEg dGltZSBzdHJpbmciCisJKGxldCogKChvZmZzZXQgKC0gMCAoY2FyIChjdXJyZW50LXRpbWUtem9u ZSkpKSkKKwkJCQkoZ210ICgrIG9mZnNldCAoZmxvYXQtdGltZSkpKSkKKwkJKHNlY29uZHMtdG8t dGltZSBnbXQpKSkKKwogKGRlZnVuIHVybC1jb29raWUtZXhwaXJlZC1wIChjb29raWUpCiAgIChs ZXQqICgKIAkgKGV4cCAodXJsLWNvb2tpZS1leHBpcmVzIGNvb2tpZSkpCkBAIC0yMTIsMTUgKzIx OCwxNiBAQAogICAgICAoKG5vdCBleHApCW5pbCkJCQk7IE5vIGV4cGlyeSA9PSBleHBpcmVzIGF0 IGJyb3dzZXIgcXVpdAogICAgICAoKDwgZGlmZi1pbi1kYXlzIDApIG5pbCkJCTsgRXhwaXJlcyBz b21ldGltZSBhZnRlciB0b2RheQogICAgICAoKD4gZGlmZi1pbi1kYXlzIDApIHQpCQk7IEV4cGly ZWQgYmVmb3JlIHRvZGF5Ci0gICAgICh0CQkJCQk7IEV4cGlyZXMgc29tZXRpbWUgdG9kYXksIGNo ZWNrIHRpbWVzCi0gICAgICAobGV0KiAoKGN1ci10aW1lICh0aW1lem9uZS1wYXJzZS10aW1lIChh cmVmIGN1ci1kYXRlIDMpKSkKKyAgICAgKHQJCQkJCTsgRXhwaXJlcyBzb21ldGltZSB0b2RheSwg Y2hlY2sgdGltZXMgKEdNVCkKKyAgICAgIChsZXQqICgoZ210LXRpbWUgKGZvcm1hdC10aW1lLXN0 cmluZyAiJVQiICh1cmwtY29va2llLWdtdC10aW1lLXN0cmluZykpKQorCQkJCQkJIChjdXItdGlt ZSAodGltZXpvbmUtcGFyc2UtdGltZSBnbXQtdGltZSkpCiAJICAgICAoZXhwLXRpbWUgKHRpbWV6 b25lLXBhcnNlLXRpbWUgKGFyZWYgZXhwLWRhdGUgMykpKQotCSAgICAgKGN1ci1ub3JtICgrICgq IDM2MCAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBjdXItdGltZSAyKSkpCisJICAgICAoY3VyLW5v cm0gKCsgKCogMzYwMCAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBjdXItdGltZSAwKSkpCiAJCQkg ICgqICA2MCAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBjdXItdGltZSAxKSkpCi0JCQkgICgqICAg MSAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBjdXItdGltZSAwKSkpKSkKLQkgICAgIChleHAtbm9y bSAoKyAoKiAzNjAgKHN0cmluZy10by1udW1iZXIgKGFyZWYgZXhwLXRpbWUgMikpKQorCQkJICAo KiAgIDEgKHN0cmluZy10by1udW1iZXIgKGFyZWYgY3VyLXRpbWUgMikpKSkpCisJICAgICAoZXhw LW5vcm0gKCsgKCogMzYwMCAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBleHAtdGltZSAwKSkpCiAJ CQkgICgqICA2MCAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBleHAtdGltZSAxKSkpCi0JCQkgICgq ICAgMSAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBleHAtdGltZSAwKSkpKSkpCisJCQkgICgqICAg MSAoc3RyaW5nLXRvLW51bWJlciAoYXJlZiBleHAtdGltZSAyKSkpKSkpCiAJKD4gKC0gY3VyLW5v cm0gZXhwLW5vcm0pIDEpKSkpKSkKIAogKGRlZnVuIHVybC1jb29raWUtcmV0cmlldmUgKGhvc3Qg Jm9wdGlvbmFsIGxvY2FscGFydCBzZWN1cmUpCg== --0015174c1a887dcac0048f266cd2--