From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6385: A slightly less aggressive fit-window-to-buffer Date: Sun, 13 Jun 2010 17:23:51 +0200 Message-ID: References: <4C12383E.5030405@gmx.at> <4C133EBB.5090702@gmx.at> <4C1396B9.6080705@gmx.at> <4C148E06.2040308@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276442921 16591 80.91.229.12 (13 Jun 2010 15:28:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 13 Jun 2010 15:28:41 +0000 (UTC) Cc: 6385@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 13 17:28:39 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ONp6y-0002mb-Q9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jun 2010 17:28:37 +0200 Original-Received: from localhost ([127.0.0.1]:46053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONp6y-00025E-5Y for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jun 2010 11:28:36 -0400 Original-Received: from [140.186.70.92] (port=49911 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONp6q-00023L-Ar for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2010 11:28:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONp6n-0004Qx-ND for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2010 11:28:28 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57077) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONp6n-0004Qr-KU for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2010 11:28:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1ONp3V-0005SO-Pz; Sun, 13 Jun 2010 11:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jun 2010 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6385-submit@debbugs.gnu.org id=B6385.127644266020965 (code B ref 6385); Sun, 13 Jun 2010 15:25:01 +0000 Original-Received: (at 6385) by debbugs.gnu.org; 13 Jun 2010 15:24:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONp2p-0005S6-49 for submit@debbugs.gnu.org; Sun, 13 Jun 2010 11:24:20 -0400 Original-Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONp2m-0005Rz-AO for 6385@debbugs.gnu.org; Sun, 13 Jun 2010 11:24:16 -0400 Original-Received: by gyh4 with SMTP id 4so2019452gyh.3 for <6385@debbugs.gnu.org>; Sun, 13 Jun 2010 08:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Jljfzr8L4IsushgrCFmvEKhXv5OTjyPr/EVvFv4ZeMQ=; b=a/qLtKDE9CdPk51m1y2pO9wtn2TiLDpb0tIunkssUcN5o7DDmySuv52YkBu0VVwT2T euLodAWfVBEJ77qUhyoLU0e4oaQiWFuvt+/TC3VlW7RA2AzPHGDeDYIARaMPuHKEXYpJ B8QCafD+UTADdH9YftzAk0GW0fN0qaPoM/KJc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=cwsVk6+5GnxliRkJT/ovKfhbuit+u+u8dXR3PkPGpcaGm0uygnXCMJauhpAMorIWKq mUEY0inz3WcSuWgGMA5i+sc/9D77E8CgY8EFveF9eSrQVaJCLNyYD4HCh1cJ+D3jM3Lf VJkjupG7aWEITPvtpZTsh92jvX+M0ZmfFYTT8= Original-Received: by 10.101.132.15 with SMTP id j15mr3663484ann.124.1276442651114; Sun, 13 Jun 2010 08:24:11 -0700 (PDT) Original-Received: by 10.100.154.15 with HTTP; Sun, 13 Jun 2010 08:23:51 -0700 (PDT) In-Reply-To: <4C148E06.2040308@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 13 Jun 2010 11:25:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37743 Archived-At: On Sun, Jun 13, 2010 at 9:51 AM, martin rudalics wrote: >> Can't we just throw in a better code instead of fit-window-to-buffer? >> (And rename fit-window-to-buffer to killing-window-fit-to-buffer if >> someone really wants it.) >> >> It does not have to be perfect. Just good enough. We can surely make >> it better later if we need to. > > I suppose there's no need for a `killing-window-fit-to-buffer'. =C2=A0Wri= ting > a non-killing one with Emacs 23 means can be done in a number of ways: > > (1) Use `adjust-window-trailing-edge'. =C2=A0IIRC that's what you already= did > =C2=A0 =C2=A0when you wrote your window balancing algorithm so you know h= ow to do > =C2=A0 =C2=A0that. > > (2) Save the window configuration and the number of windows around the > =C2=A0 =C2=A0`enlarge-window' call in `fit-window-to-buffer' and restore = the > =C2=A0 =C2=A0configuration when a window got deleted. =C2=A0That's more o= r less what > =C2=A0 =C2=A0`adjust-window-trailing-edge' does internally. > > (3) Adjust enlarge_window so it doesn't delete windows. > > Since I don't understand enlarge_window any more I can't give you advice > on (3). =C2=A0If you want to try (1) or (2) ask me if you encounter probl= ems. Thanks. Writing the code is probably not a big problem, keeping another patch in my patched Emacs is. So I will write a new version and send it here. (I wonder if I had not written it already and threw it away to avoid keeping another patch.)